HBASE-28501 Support non-SPNEGO authentication methods and implement s… #5881

stoty · 2024-05-08T12:10:15Z

…ession handling in REST java client library

petersomogyi · 2024-05-15T10:52:58Z

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java

   * @param trustStorePath     custom trust store to use for SSL connections
   * @param trustStorePassword password to use for custom trust store
   * @param trustStoreType     type of custom trust store
   * @throws ClientTrustStoreInitializationException if the trust store file can not be loaded
   */
-  public Client(Cluster cluster, Configuration conf, String trustStorePath,
+  public Client(Cluster cluster, Configuration conf, boolean sslEnabled, String trustStorePath,


The sslEnabled argument is not mentioned in the Javadoc nor used in the constructor either.

The comment is also incorrect, as this sets sticky to false.
I will fix the comment as well.

petersomogyi · 2024-05-15T11:56:44Z

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java

+    throws IOException, KeyStoreException, NoSuchAlgorithmException, CertificateException {
+    String tmpdir =
+      Files.createTempDirectory("hbase_rest_client_truststore").toFile().getAbsolutePath();
+    String trustStoreLocation = tmpdir + File.separator + "truststore.jks";


How about using Path for concatenation?

petersomogyi · 2024-05-15T11:57:26Z

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java

+        throw new IOException(e);
+      }
+      if (stickyContext != null) {
+        // We set the cookie twice, but it shouldn't be a problem


As we discussed this comment is invalid.

Apache-HBase · 2024-05-15T12:56:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 1s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	checkstyle	0m 13s	master passed
+1 💚	spotless	0m 46s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 44s	the patch passed
+1 💚	compile	0m 28s	the patch passed
+1 💚	javac	0m 28s	the patch passed
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	4m 49s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 43s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		20m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5881
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0fd279317db0 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ca34010`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-15T12:58:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 51s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	5m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 30s	hbase-rest in the patch passed.
		22m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5881
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2b103ef53031 5.4.0-174-generic #193-Ubuntu SMP Thu Mar 7 14:29:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ca34010`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/testReport/
Max. process+thread count	1468 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-15T12:58:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	5m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 24s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 10s	hbase-rest in the patch passed.
		22m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5881
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a45e85747b46 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ca34010`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/testReport/
Max. process+thread count	1651 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-05-15T12:58:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 3s	master passed
+1 💚	compile	0m 20s	master passed
+1 💚	shadedjars	5m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 53s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 53s	hbase-rest in the patch passed.
		23m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5881
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 16a359000a32 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ca34010`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/testReport/
Max. process+thread count	2023 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5881/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi

lgtm

…ession handling in REST java client library

stoty · 2024-05-16T06:53:27Z

I forgot to add the signed-off header.
I will add it for the backports.

…ession handling in REST java client library (#5881) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 716adf5)

…ession handling in REST java client library (apache#5881)

…ession handling in REST java client library (apache#5881) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 716adf5) (cherry picked from commit cc0bcb4) "This commit does not contain secrets"

This comment was marked as outdated.

Sign in to view

petersomogyi reviewed May 15, 2024

View reviewed changes

stoty requested a review from petersomogyi May 15, 2024 12:34

petersomogyi approved these changes May 15, 2024

View reviewed changes

HBASE-28501 Support non-SPNEGO authentication methods and implement s…

697c093

…ession handling in REST java client library

stoty force-pushed the HBASE-28501 branch from 322be97 to 697c093 Compare May 16, 2024 06:52

stoty merged commit 716adf5 into apache:master May 16, 2024

stoty added a commit that referenced this pull request May 16, 2024

HBASE-28501 Support non-SPNEGO authentication methods and implement s…

1d421e3

…ession handling in REST java client library (#5881) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 716adf5)

stoty added a commit that referenced this pull request May 16, 2024

HBASE-28501 Support non-SPNEGO authentication methods and implement s…

3165e38

…ession handling in REST java client library (#5881) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 716adf5)

stoty added a commit that referenced this pull request May 16, 2024

HBASE-28501 Support non-SPNEGO authentication methods and implement s…

6af1823

…ession handling in REST java client library (#5881) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 716adf5)

stoty added a commit that referenced this pull request May 16, 2024

HBASE-28501 Support non-SPNEGO authentication methods and implement s…

cc0bcb4

…ession handling in REST java client library (#5881) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 716adf5)

stoty added a commit that referenced this pull request May 16, 2024

HBASE-28501 Support non-SPNEGO authentication methods and implement s…

1d94943

…ession handling in REST java client library (#5881) Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 716adf5)

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request May 21, 2024

HBASE-28501 Support non-SPNEGO authentication methods and implement s…

ee69002

…ession handling in REST java client library (apache#5881)

HBASE-28501 Support non-SPNEGO authentication methods and implement s… #5881

HBASE-28501 Support non-SPNEGO authentication methods and implement s… #5881

Uh oh!

Conversation

stoty commented May 8, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

petersomogyi May 15, 2024

Choose a reason for hiding this comment

Uh oh!

stoty May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stoty May 15, 2024

Choose a reason for hiding this comment

Uh oh!

petersomogyi May 15, 2024

Choose a reason for hiding this comment

Uh oh!

stoty May 15, 2024

Choose a reason for hiding this comment

Uh oh!

petersomogyi May 15, 2024

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented May 15, 2024

Uh oh!

Apache-HBase commented May 15, 2024

Uh oh!

Apache-HBase commented May 15, 2024

Uh oh!

Apache-HBase commented May 15, 2024

Uh oh!

petersomogyi left a comment

Choose a reason for hiding this comment

Uh oh!

stoty commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

stoty May 15, 2024 •

edited

Loading

stoty commented May 16, 2024 •

edited

Loading