Skip to content

HBASE-22724 Add a emoji on the vote table for pre commit result on gi… #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

HBASE-22724 Add a emoji on the vote table for pre commit result on gi… #568

merged 1 commit into from
Sep 4, 2019

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Aug 31, 2019

…thub

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 38s Docker mode activated.
💔 yetus 0m 6s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/1/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/1/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Aug 31, 2019

Interesting. It can't get far enough to load the new personality.

Do we no longer need skip-dir? I haven't looked that one up to see why it's gone now.

@Apache9
Copy link
Contributor Author

Apache9 commented Aug 31, 2019

It should be skip-dirs and I tried to remove it when testing on the branch HBASE-22724 and nothing went wrong, so...

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 35s Docker mode activated.
💔 yetus 0m 6s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/2/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/2/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Sep 1, 2019

I think it'll only go wrong if there's a change to dev-support and a change to some Java file. Basically we'll do unit tests for the whole project instead of just the one that changed.

@Apache9
Copy link
Contributor Author

Apache9 commented Sep 1, 2019

#535

Here I just modified a file under the dev-support directory and the pre commit was fine.

So I do not think this is a big deal? We do not use this in the past, it is copied from the Jenkins file in hadoop.

So if no other concerns, let’s merge this to master and try it first? If it is fine, then cherry pick to other branches.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 57s Docker mode activated.
💔 yetus 0m 6s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/3/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/3/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Sep 1, 2019

No, that doesn't test the issue. To get the conditions I'm talking about you need a file under dev-support and a Java file in a small module. e.g. hbase-endpoint.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 36s Docker mode activated.
💔 yetus 0m 6s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/4/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/4/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 40s Docker mode activated.
💔 yetus 0m 5s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/5/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/5/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Sep 2, 2019

OK, let me try a new PR on HBASE-22724 branch.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 2m 13s Docker mode activated.
💔 yetus 0m 5s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/6/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/6/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 2m 0s Docker mode activated.
💔 yetus 0m 6s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/7/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/7/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 17s Docker mode activated.
💔 yetus 0m 6s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/8/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/8/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Sep 2, 2019

OK, seems you are right.

https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/view/change-requests/job/PR-573/1/console

Here we will run all the UTs although we only modified the hbase-common module.

Let me add the skip-dirs option.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 35s Docker mode activated.
💔 yetus 0m 6s Unprocessed flag(s): --quick-hadoopcheck --skip-errorprone
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/9/artifact/out/Dockerfile
GITHUB PR #568
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-568/9/console
versions git=2.11.0
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 mentioned this pull request Sep 4, 2019
Closed
@Apache9
Copy link
Contributor Author

Apache9 commented Sep 4, 2019

The pre commit result in #573 is fine, the skip-dirs works as expected.

Let me merge this.

@Apache9 Apache9 merged commit da14488 into apache:master Sep 4, 2019
asfgit pushed a commit that referenced this pull request Sep 4, 2019
@Apache9
HBASE-22724 Add a emoji on the vote table for pre commit result on gi…
48f0b18 
…thub (#568)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Sep 4, 2019
@Apache9
HBASE-22724 Add a emoji on the vote table for pre commit result on gi…
c3ad579 
…thub (#568)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Sep 4, 2019
@Apache9
HBASE-22724 Add a emoji on the vote table for pre commit result on gi…
587d744 
…thub (#568)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Sep 4, 2019
@Apache9
HBASE-22724 Add a emoji on the vote table for pre commit result on gi…
157ffae 
…thub (#568)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Sep 4, 2019
@Apache9
HBASE-22724 Add a emoji on the vote table for pre commit result on gi…
8b3536a 
…thub (#568)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Sep 4, 2019
@Apache9
HBASE-22724 Add a emoji on the vote table for pre commit result on gi…
bab7bd6 
…thub (#568)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@Apache9
HBASE-22724 Add a emoji on the vote table for pre commit result on gi…
f229a5b 
…thub (apache#568)

Signed-off-by: Sean Busbey <busbey@apache.org>
Signed-off-by: Stack <stack@apache.org>
(cherry picked from commit c3ad579)

Change-Id: Ia8c5d75918f8c547b00155d9695494e4f8cfc67b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busbey busbey busbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @busbey