HBASE-22944 Space Quota: TableNotFoundException: hbase:quota is thrown when region server is restarted. #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shardul-cr7
force-pushed
the
HBASE-22944
branch
from
2ac2927 to
d8045ef
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Hi @jatsakthi, Can you review this? :) |
the-sakthi
reviewed
Aug 30, 2019
Member
the-sakthi
left a comment
the-sakthi
left a comment
There was a problem hiding this comment.
Skimmed through it. Looks good to me. Will come back to take a look again.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
anoopsjohn
reviewed
Sep 4, 2019
| protected void chore() { | ||
| try { | ||
| // check whether Quota table is present or not. | ||
| if (!checkQuotaTableExists()) { |
Contributor
There was a problem hiding this comment.
This will result in a META read. This can be done only once in the life time of an RS right if we found Quota table exists? A Boolean state can help here.
Why do you think we should do a WARN log? It can be just INFO at max IMO.
Contributor
Author
There was a problem hiding this comment.
Hi @anoopsjohn , Thanks for the review. Added a boolean state to avoid the Meta read again and added info level log.
|
🎊 +1 overall
This message was automatically generated. |
shardul-cr7
changed the title
saintstack
reviewed
Sep 14, 2019
| // check whether Quota table is present or not. | ||
| if (!quotaTablePresent && !checkQuotaTableExists()) { | ||
| LOG.info("Quota table not found, skipping quota manager cache refresh."); | ||
| quotaTablePresent = true; |
Contributor
There was a problem hiding this comment.
Is this right? Setting it to true? Should it be false? The table was 'not found'.
Contributor
Author
There was a problem hiding this comment.
ohh yes..I should set it after the if condition...my bad :)
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. Made the changes. :)
shardul-cr7
force-pushed
the
HBASE-22944
branch
from
c908fd3 to
e66e8b4
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Sep 16, 2019
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Good by me. Another for your list @joshelser Thanks boss.
joshelser
approved these changes
Sep 18, 2019
Member
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
LGTM. Nice little trick on the if-block.
Let me try to get this in.
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2019
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes #559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2019
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes #559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2019
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes #559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
pankaj72981
reviewed
Sep 21, 2019
| return; | ||
| } | ||
| // since quotaTable is present so setting the flag as true. | ||
| quotaTablePresent = true; |
Contributor
There was a problem hiding this comment.
Better we move flag setting inside checkQuotaTableExists().
Sorry for the late review.
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes apache#559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…herChore During startup, it's possible that quotas are enabled but the Master has not yet created the hbase:quotas table. Closes apache#559 Signed-off-by: stack <stack@apache.org> Signed-off-by: Josh Elser <elserj@apache.org> (cherry picked from commit f1682a1) Change-Id: Iedb0bfe9591c0957a151acc8d2b3bd31a91237d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Master startup if quota feature is enabled and region server is running TableNotFoundException occurs in regionServer logs
SpaceQuotaRefresherChore does not checks whether hbase:quota table is present,before starting its operation which sometimes may result to TableNotFoundExceptions.
This is because master has not created the hbase:quota table and SpaceQuotaRefresherChore is running.
This is little tricky and will happen in below scenario: