-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28186 Rebase CacheAwareBalance related commits into master branch #5519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
mostly good but can you fix all build failures? |
#5339) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Reviewew-by: Kota-SH <shanmukhaharipriya@gmail.com>
591e01b
to
ae45634
Compare
🎊 +1 overall
This message was automatically generated. |
// If two servers have same region cache ratio, then the server currently hosting the | ||
// region | ||
// should retain the region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format.
toPB(Map<String, Boolean> prefetchedHfileNames) { | ||
return PersistentPrefetchProtos.PrefetchedHfileName.newBuilder() | ||
.putAllPrefetchedFiles(prefetchedHfileNames).build(); | ||
toPB(Map<String, Pair<String, Long>> prefetchedHfileNames) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is hard for me to find out what is in Map<String, Pair<String, Long>>
. Is it possible to replaces at least Pair<String, Long>
with a class?
🎊 +1 overall
This message was automatically generated. |
Thanks @taklwu @meszibalu for the suggestions. I'm trying to get the PR passing build first by pushing each commit individually, please hold on from reviewing it for now until I have all the four commits passing. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
It looks like the pre-commit build fails to acknowledge the protobuf changes, ain't sure why. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
1797e44
to
ae45634
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.