Skip to content

HBASE-28184 Tailing the WAL is very slow if there are multiple peers #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2023
Merged

HBASE-28184 Tailing the WAL is very slow if there are multiple peers #5505

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f30fab
HBASE-28184 Tailing the WAL is very slow if there are multiple peers
shahrs87 Nov 6, 2023
7cfc57f
Merge branch 'branch-2.5' of https://github.com/apache/hbase into HBA…
shahrs87 Nov 6, 2023
78a74be
Addressing review comments
shahrs87 Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,13 @@ private void dequeueCurrentLog() throws IOException {
private boolean readNextEntryAndRecordReaderPosition() throws IOException {
Entry readEntry = reader.next();
long readerPos = reader.getPosition();
OptionalLong fileLength = walFileLengthProvider.getLogFileSizeIfBeingWritten(currentPath);
OptionalLong fileLength;
if (logQueue.getQueueSize(walGroupId) > 1) {
fileLength = OptionalLong.empty();
} else {
// if there is only one file in queue, check whether it is still being written to
fileLength = walFileLengthProvider.getLogFileSizeIfBeingWritten(currentPath);
}
if (fileLength.isPresent() && readerPos > fileLength.getAsLong()) {
// See HBASE-14004, for AsyncFSWAL which uses fan-out, it is possible that we read uncommitted
// data, so we need to make sure that we do not read beyond the committed file length.
Expand Down