Skip to content

HBASE-22928 ScanMetrics counter update may not happen in case of exception in TableRecordReaderImpl #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

pankaj72981
Copy link
Contributor

Updating the counter in multiple exception scenario.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 118 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 593 master passed
+1 compile 67 master passed
+1 checkstyle 39 master passed
+1 shadedjars 314 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 19 master passed
0 spotbugs 53 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 52 master passed
_ Patch Compile Tests _
+1 mvninstall 351 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
+1 checkstyle 21 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 284 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1085 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 63 the patch passed
_ Other Tests _
+1 unit 1145 hbase-mapreduce in the patch passed.
+1 asflicense 19 The patch does not generate ASF License warnings.
4657
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/1/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux eeea8ca53c00 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / 5106f28
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/1/testReport/
Max. process+thread count 5460 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 385 master passed
+1 compile 26 master passed
+1 checkstyle 22 master passed
+1 shadedjars 283 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 54 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 51 master passed
_ Patch Compile Tests _
+1 mvninstall 313 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
+1 checkstyle 20 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 303 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 991 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 53 the patch passed
_ Other Tests _
+1 unit 1116 hbase-mapreduce in the patch passed.
+1 asflicense 20 The patch does not generate ASF License warnings.
4080
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/2/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f8c0782ae278 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / f2425c7
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/2/testReport/
Max. process+thread count 5686 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 324 master passed
+1 compile 28 master passed
+1 checkstyle 22 master passed
+1 shadedjars 273 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 50 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 47 master passed
_ Patch Compile Tests _
+1 mvninstall 299 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
+1 checkstyle 20 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 272 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 927 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 55 the patch passed
_ Other Tests _
-1 unit 1098 hbase-mapreduce in the patch failed.
+1 asflicense 19 The patch does not generate ASF License warnings.
3851
Reason Tests
Failed junit tests hadoop.hbase.snapshot.TestExportSnapshotNoCluster
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/3/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 756d432de555 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / 56980fb
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/3/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/3/testReport/
Max. process+thread count 5500 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 54 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 380 master passed
+1 compile 31 master passed
+1 checkstyle 25 master passed
+1 shadedjars 344 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 23 master passed
0 spotbugs 61 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 58 master passed
_ Patch Compile Tests _
+1 mvninstall 390 the patch passed
+1 compile 33 the patch passed
+1 javac 33 the patch passed
+1 checkstyle 24 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 353 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1240 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 66 the patch passed
_ Other Tests _
+1 unit 1346 hbase-mapreduce in the patch passed.
+1 asflicense 18 The patch does not generate ASF License warnings.
4889
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/4/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0ac1b4422676 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / 56980fb
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/4/testReport/
Max. process+thread count 5616 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 363 master passed
+1 compile 34 master passed
+1 checkstyle 25 master passed
+1 shadedjars 305 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 19 master passed
0 spotbugs 58 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 55 master passed
_ Patch Compile Tests _
+1 mvninstall 330 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
+1 checkstyle 19 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 305 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1027 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 68 the patch passed
_ Other Tests _
-1 unit 1051 hbase-mapreduce in the patch failed.
+1 asflicense 15 The patch does not generate ASF License warnings.
4101
Reason Tests
Failed junit tests hadoop.hbase.snapshot.TestExportSnapshotNoCluster
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c86f95a7766a 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / 83e7794
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/testReport/
Max. process+thread count 5211 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 386 master passed
+1 compile 31 master passed
+1 checkstyle 25 master passed
+1 shadedjars 346 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 61 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 59 master passed
_ Patch Compile Tests _
+1 mvninstall 378 the patch passed
+1 compile 30 the patch passed
+1 javac 30 the patch passed
+1 checkstyle 20 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 337 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1202 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 65 the patch passed
_ Other Tests _
-1 unit 1227 hbase-mapreduce in the patch failed.
+1 asflicense 20 The patch does not generate ASF License warnings.
4661
Reason Tests
Failed junit tests hadoop.hbase.snapshot.TestExportSnapshotNoCluster
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8b39a855cf12 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / f6a4c66
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/testReport/
Max. process+thread count 5441 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/6/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 381 master passed
+1 compile 26 master passed
+1 checkstyle 22 master passed
+1 shadedjars 271 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 19 master passed
0 spotbugs 53 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 50 master passed
_ Patch Compile Tests _
+1 mvninstall 298 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
+1 checkstyle 20 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 271 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 917 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 55 the patch passed
_ Other Tests _
-1 unit 1131 hbase-mapreduce in the patch failed.
+1 asflicense 18 The patch does not generate ASF License warnings.
3930
Reason Tests
Failed junit tests hadoop.hbase.snapshot.TestExportSnapshotNoCluster
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/7/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2543fc0a893c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / 090c55f
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/7/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/7/testReport/
Max. process+thread count 5518 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/7/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 323 master passed
+1 compile 27 master passed
+1 checkstyle 23 master passed
+1 shadedjars 272 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 52 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 51 master passed
_ Patch Compile Tests _
+1 mvninstall 299 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
+1 checkstyle 19 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 271 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 940 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 52 the patch passed
_ Other Tests _
+1 unit 1068 hbase-mapreduce in the patch passed.
+1 asflicense 20 The patch does not generate ASF License warnings.
3839
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/8/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 939f91dfdb5a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / ee5cf0d
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/8/testReport/
Max. process+thread count 5450 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/8/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 94 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 335 master passed
+1 compile 25 master passed
+1 checkstyle 20 master passed
+1 shadedjars 281 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 61 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 59 master passed
_ Patch Compile Tests _
+1 mvninstall 358 the patch passed
+1 compile 32 the patch passed
+1 javac 32 the patch passed
+1 checkstyle 23 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 375 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1269 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 71 the patch passed
_ Other Tests _
+1 unit 1348 hbase-mapreduce in the patch passed.
+1 asflicense 14 The patch does not generate ASF License warnings.
4839
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/9/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6a81f37419f1 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / b642ee0
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/9/testReport/
Max. process+thread count 5270 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/9/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 327 master passed
+1 compile 29 master passed
+1 checkstyle 21 master passed
+1 shadedjars 286 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 51 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 50 master passed
_ Patch Compile Tests _
+1 mvninstall 305 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
+1 checkstyle 20 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 271 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 939 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 17 the patch passed
+1 findbugs 62 the patch passed
_ Other Tests _
+1 unit 1127 hbase-mapreduce in the patch passed.
+1 asflicense 18 The patch does not generate ASF License warnings.
3921
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/10/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux fbc3c719b850 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / 97fbaa6
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/10/testReport/
Max. process+thread count 5506 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/10/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 375 master passed
+1 compile 28 master passed
+1 checkstyle 21 master passed
+1 shadedjars 304 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 57 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 55 master passed
_ Patch Compile Tests _
+1 mvninstall 333 the patch passed
+1 compile 30 the patch passed
+1 javac 30 the patch passed
+1 checkstyle 20 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 302 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1041 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 63 the patch passed
_ Other Tests _
-1 unit 1118 hbase-mapreduce in the patch failed.
+1 asflicense 17 The patch does not generate ASF License warnings.
4203
Reason Tests
Failed junit tests hadoop.hbase.snapshot.TestExportSnapshotNoCluster
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/11/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ecc3228657d4 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / 345c21d
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/11/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/11/testReport/
Max. process+thread count 5143 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/11/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 386 master passed
+1 compile 28 master passed
+1 checkstyle 21 master passed
+1 shadedjars 269 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 51 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 48 master passed
_ Patch Compile Tests _
+1 mvninstall 296 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
+1 checkstyle 19 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 270 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 920 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 53 the patch passed
_ Other Tests _
+1 unit 1099 hbase-mapreduce in the patch passed.
+1 asflicense 18 The patch does not generate ASF License warnings.
3891
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/12/artifact/out/Dockerfile
GITHUB PR #546
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 23213d370d1d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-546/out/precommit/personality/provided.sh
git revision master / a5ef6b2
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/12/testReport/
Max. process+thread count 5604 (vs. ulimit of 10000)
modules C: hbase-mapreduce U: hbase-mapreduce
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-546/12/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Reidddddd Reidddddd merged commit 13b2edc into apache:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants