Skip to content

HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l… #5425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l… #5425

merged 1 commit into from
Sep 26, 2023

Conversation

@NihalJain
Copy link
Contributor

@NihalJain NihalJain commented Sep 21, 2023

…ang.ClassCastException

@nikita15p @NihalJain
HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…
92cfcef 
…ang.ClassCastException (apache#5346)

Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
@NihalJain NihalJain added the backport This PR is a back port of some issue or issues already committed to master label Sep 21, 2023
@NihalJain
Copy link
Contributor Author

NihalJain commented Sep 21, 2023

Backports #5346
Raised on behalf of @nikita15p

@Apache-HBase
Copy link

Apache-HBase commented Sep 21, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 2m 48s branch-2 passed
+1 💚 compile 0m 14s branch-2 passed
+1 💚 shadedjars 4m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 14s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 10s the patch passed
+1 💚 compile 0m 13s the patch passed
+1 💚 javac 0m 13s the patch passed
+1 💚 shadedjars 4m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 11s the patch passed
_ Other Tests _
+1 💚 unit 1m 37s hbase-examples in the patch passed.
19m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5425
Optional Tests javac javadoc unit shadedjars compile
uname Linux a0396a4c779e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3ddadcf
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/testReport/
Max. process+thread count 1654 (vs. ulimit of 30000)
modules C: hbase-examples U: hbase-examples
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 21, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 17s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 28s branch-2 passed
+1 💚 compile 0m 19s branch-2 passed
+1 💚 shadedjars 5m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 18s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 46s the patch passed
+1 💚 compile 0m 17s the patch passed
+1 💚 javac 0m 17s the patch passed
+1 💚 shadedjars 4m 54s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s the patch passed
_ Other Tests _
+1 💚 unit 1m 40s hbase-examples in the patch passed.
20m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5425
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1105512afd9c 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3ddadcf
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/testReport/
Max. process+thread count 1478 (vs. ulimit of 30000)
modules C: hbase-examples U: hbase-examples
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Sep 21, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+1 💚 mvninstall 3m 52s branch-2 passed
+1 💚 compile 0m 26s branch-2 passed
+1 💚 checkstyle 0m 12s branch-2 passed
+1 💚 spotless 0m 55s branch has no errors when running spotless:check.
+1 💚 spotbugs 0m 33s branch-2 passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 22s the patch passed
+1 💚 compile 0m 25s the patch passed
-0 ⚠️ javac 0m 25s hbase-examples generated 1 new + 13 unchanged - 0 fixed = 14 total (was 13)
+1 💚 checkstyle 0m 10s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 16m 50s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚 spotless 0m 45s patch has no errors when running spotless:check.
+1 💚 spotbugs 0m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
30m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5425
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 5f19ff8d6f4e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3ddadcf
Default Java Eclipse Adoptium-11.0.17+8
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-examples.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-examples U: hbase-examples
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5425/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@NihalJain
Copy link
Contributor Author

NihalJain commented Sep 21, 2023

Will merge this to branch-2 tomorrow!

Also as mentioned earlier in #5346 MultiThreadedClientExample is broken on branch-2.x . This patch fixes the issue and adds a test for ensuring it does not break again in future. Please let me know if we would want this in branch-2.5, branch-2.4
CC: @Apache9 , @ndimiduk, @petersomogyi

@NihalJain NihalJain merged commit 8caebc3 into apache:branch-2 Sep 26, 2023
NihalJain added a commit that referenced this pull request Sep 26, 2023
@NihalJain @nikita15p
HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…
70d136b 
…ang.ClassCastException (#5346) (#5425)

Co-authored-by: Nikita Pande <nikita15p@gmail.com>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 8caebc3)
NihalJain added a commit that referenced this pull request Sep 26, 2023
@NihalJain @nikita15p
HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…
ae7dc1d 
…ang.ClassCastException (#5346) (#5425)

Co-authored-by: Nikita Pande <nikita15p@gmail.com>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 8caebc3)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@NihalJain @nikita15p @petersomogyi
HBASE-27991 [hbase-examples] MultiThreadedClientExample throws java.l…
15524d7 
…ang.ClassCastException (apache#5346) (apache#5425)

Co-authored-by: Nikita Pande <nikita15p@gmail.com>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit 8caebc3)
(cherry picked from commit ae7dc1d)
Change-Id: I219fe1b66e224291193c0c41d72056e8004731c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees

No one assigned

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NihalJain @Apache-HBase @Apache9 @nikita15p