HBASE-28025 Enhance ByteBufferUtils.findCommonPrefix to compare 8 bytes each time [addendum] #5362

petersomogyi · 2023-08-21T07:38:15Z

Remove the "@test" annotation from the "TestBytes" class due to its reliance on "TestCase" from JUnit 3.

@test

…es each time [addendum] Remove the "@test" annotation from the "TestBytes" class due to its reliance on "TestCase" from JUnit 3.

Apache-HBase · 2023-08-21T07:52:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
-1 ❌	mvninstall	0m 48s	root in branch-2.4 failed.
-1 ❌	compile	0m 13s	hbase-common in branch-2.4 failed.
-1 ❌	shadedjars	0m 46s	branch has 20 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 55s	the patch passed
+1 💚	compile	0m 15s	the patch passed
+1 💚	javac	0m 15s	hbase-common generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚	shadedjars	3m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 38s	hbase-common in the patch passed.
		11m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5362
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e5a4f2aee684 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `6596ef6`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk8-hadoop2-check/output/branch-compile-hbase-common.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/testReport/
Max. process+thread count	333 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-21T07:54:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.4 Compile Tests _
-1 ❌	mvninstall	1m 0s	root in branch-2.4 failed.
-1 ❌	compile	0m 15s	hbase-common in branch-2.4 failed.
-1 ❌	shadedjars	1m 6s	branch has 20 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	branch-2.4 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	hbase-common generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚	shadedjars	4m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 32s	hbase-common in the patch passed.
		14m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5362
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aebbd3fd3eef 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `6596ef6`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-common.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/testReport/
Max. process+thread count	340 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-21T08:05:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.4 Compile Tests _
-1 ❌	mvninstall	1m 0s	root in branch-2.4 failed.
-1 ❌	compile	0m 23s	hbase-common in branch-2.4 failed.
+1 💚	checkstyle	0m 11s	branch-2.4 passed
+1 💚	spotless	0m 38s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 11s	hbase-common in branch-2.4 failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	0m 27s	the patch passed
-0 ⚠️	javac	0m 27s	hbase-common generated 68 new + 99 unchanged - 4 fixed = 167 total (was 103)
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 10s	Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.5.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		24m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5362
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ffd165fba07b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.4 / `6596ef6`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-general-check/output/branch-compile-hbase-common.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-common.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-common U: hbase-common
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5362/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi · 2023-08-21T08:24:37Z

The build failures reported for branch-2.4 are expected.

@test

…es each time [addendum] (apache#5362) Remove the "@test" annotation from the "TestBytes" class due to its reliance on "TestCase" from JUnit 3. Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 312f5ee) Change-Id: Ie07880a697a631a9798e22de74af89ef3a397744

HBASE-28025 Enhance ByteBufferUtils.findCommonPrefix to compare 8 byt…

395abcb

…es each time [addendum] Remove the "@test" annotation from the "TestBytes" class due to its reliance on "TestCase" from JUnit 3.

petersomogyi requested a review from Apache9 August 21, 2023 07:38

Apache9 approved these changes Aug 21, 2023

View reviewed changes

petersomogyi merged commit 312f5ee into apache:branch-2.4 Aug 21, 2023

petersomogyi deleted the HBASE-28025-branch-2.4 branch August 21, 2023 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28025 Enhance ByteBufferUtils.findCommonPrefix to compare 8 bytes each time [addendum] #5362

HBASE-28025 Enhance ByteBufferUtils.findCommonPrefix to compare 8 bytes each time [addendum] #5362

petersomogyi commented Aug 21, 2023

Uh oh!

Apache-HBase commented Aug 21, 2023

Uh oh!

Apache-HBase commented Aug 21, 2023

Uh oh!

Apache-HBase commented Aug 21, 2023

Uh oh!

petersomogyi commented Aug 21, 2023

Uh oh!

Uh oh!

HBASE-28025 Enhance ByteBufferUtils.findCommonPrefix to compare 8 bytes each time [addendum] #5362

HBASE-28025 Enhance ByteBufferUtils.findCommonPrefix to compare 8 bytes each time [addendum] #5362

Conversation

petersomogyi commented Aug 21, 2023

Uh oh!

Apache-HBase commented Aug 21, 2023

Uh oh!

Apache-HBase commented Aug 21, 2023

Uh oh!

Apache-HBase commented Aug 21, 2023

Uh oh!

petersomogyi commented Aug 21, 2023

Uh oh!

Uh oh!