HBASE-27851 Fix TestListTablesByState which is silently failing due to a surefire bug #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a surefire bug surefire version 3.0.0-M6 has a bug where tests end up being removed from the test results if they fail with a long exception message. See: https://issues.apache.org/jira/browse/SUREFIRE-2079 TestListTablesByState is currently failing due to an error. However, it is being missed because of the surefire bug. I found this while testing the final surfire 3.0.0 version which fixes the bug and the test then shows up as failing. Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Two tests failed in the precommit checks but I don't think they are related to my changes which are just in one test class. Failed tests:
|
|
org.apache.hadoop.hbase.master.TestListTablesByState is now showing up in the test results: |
Apache9
approved these changes
May 11, 2023
Apache9
pushed a commit
that referenced
this pull request
May 11, 2023
…o a surefire bug (#5227) surefire version 3.0.0-M6 has a bug where tests end up being removed from the test results if they fail with a long exception message. See: https://issues.apache.org/jira/browse/SUREFIRE-2079 TestListTablesByState is currently failing due to an error. However, it is being missed because of the surefire bug. I found this while testing the final surfire 3.0.0 version which fixes the bug and the test then shows up as failing. Co-authored-by: Jonathan Albrecht <jonathan.albrecht@ibm.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 55aff4c)
|
Thanks for reviewing and merging @Apache9! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surefire version 3.0.0-M6 has a bug where tests end up being removed from the test results if they fail with a long exception message. See:
https://issues.apache.org/jira/browse/SUREFIRE-2079
TestListTablesByState is currently failing due to an error. However, it is being missed because of the surefire bug. I found this while testing the final surfire 3.0.0 version which fixes the bug and the test then shows up as failing.