HBASE-27728 Implement a tool to migrate replication peer data between… #5179

Apache9 · 2023-04-13T15:54:33Z

… different storage implementation

Apache-HBase · 2023-04-13T16:37:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	master passed
+1 💚	compile	1m 15s	master passed
+1 💚	checkstyle	0m 29s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 14s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
-0 ⚠️	checkstyle	0m 13s	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	12m 56s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		37m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5179
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
uname	Linux b26929185804 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a711059`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-client hbase-replication hbase-mapreduce U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-13T16:38:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 26s	master passed
+1 💚	compile	0m 51s	master passed
+1 💚	shadedjars	4m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 18s	hbase-client in the patch passed.
+1 💚	unit	0m 34s	hbase-replication in the patch passed.
+1 💚	unit	13m 56s	hbase-mapreduce in the patch passed.
		37m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5179
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9fe672878999 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a711059`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/testReport/
Max. process+thread count	2738 (vs. ulimit of 30000)
modules	C: hbase-client hbase-replication hbase-mapreduce U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-13T16:41:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 25s	master passed
+1 💚	compile	1m 5s	master passed
+1 💚	shadedjars	6m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	4m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 14s	hbase-client in the patch passed.
+1 💚	unit	0m 28s	hbase-replication in the patch passed.
+1 💚	unit	13m 56s	hbase-mapreduce in the patch passed.
		40m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5179
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bfd7e6258207 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a711059`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/testReport/
Max. process+thread count	2688 (vs. ulimit of 30000)
modules	C: hbase-client hbase-replication hbase-mapreduce U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

...lication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerMigrationTool.java

hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java

...lication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerMigrationTool.java

Apache-HBase · 2023-04-14T16:50:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 1s	Shelldocs was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 30s	master passed
+1 💚	compile	6m 45s	master passed
+1 💚	checkstyle	1m 38s	master passed
+1 💚	spotless	0m 59s	branch has no errors when running spotless:check.
+1 💚	spotbugs	11m 57s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	5m 29s	the patch passed
+1 💚	javac	5m 29s	the patch passed
-0 ⚠️	checkstyle	1m 8s	root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shellcheck	0m 2s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	12m 52s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	7m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		69m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5179
Optional Tests	dupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname	Linux 85c619455819 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `856fa14`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
Max. process+thread count	176 (vs. ulimit of 30000)
modules	C: hbase-client hbase-replication . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/2/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… different storage implementation

Apache9 · 2023-04-17T04:05:40Z

Any other concerns? @2005hithlj @wchevreuil

Thanks.

2005hithlj · 2023-04-17T05:28:25Z

LGTM

Apache-HBase · 2023-04-17T05:48:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 40s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 44s	master passed
+1 💚	compile	6m 2s	master passed
+1 💚	checkstyle	1m 38s	master passed
+1 💚	spotless	1m 1s	branch has no errors when running spotless:check.
+1 💚	spotbugs	11m 2s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 4s	the patch passed
+1 💚	compile	8m 5s	the patch passed
+1 💚	javac	8m 5s	the patch passed
+1 💚	checkstyle	1m 30s	the patch passed
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	20m 16s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	1m 7s	patch has no errors when running spotless:check.
+1 💚	spotbugs	12m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		88m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5179
Optional Tests	dupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname	Linux 0449032dfafd 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b098b0`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	176 (vs. ulimit of 30000)
modules	C: hbase-client hbase-replication . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/console
versions	git=2.34.1 maven=3.8.6 shellcheck=0.8.0 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-17T09:27:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s	master passed
+1 💚	compile	1m 51s	master passed
+1 💚	shadedjars	4m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	1m 50s	the patch passed
+1 💚	javac	1m 50s	the patch passed
+1 💚	shadedjars	4m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	274m 20s	root in the patch passed.
		307m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5179
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c459b7324373 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b098b0`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/testReport/
Max. process+thread count	4610 (vs. ulimit of 30000)
modules	C: hbase-client hbase-replication . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-17T10:58:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 45s	master passed
+1 💚	compile	2m 11s	master passed
+1 💚	shadedjars	5m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 19s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	shadedjars	6m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 41s	the patch passed
		_ Other Tests _
-1 ❌	unit	361m 13s	root in the patch failed.
		398m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5179
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 66f4a3e62123 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b098b0`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/testReport/
Max. process+thread count	2191 (vs. ulimit of 30000)
modules	C: hbase-client hbase-replication . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5179/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… different storage implementation (#5179) Signed-off-by: Liangjun He <heliangjun@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 31c4aea) Conflicts: hbase-client/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationPeerConfig.java hbase-replication/src/test/java/org/apache/hadoop/hbase/replication/ReplicationPeerStorageTestBase.java

Apache9 self-assigned this Apr 13, 2023

Apache9 requested a review from 2005hithlj April 13, 2023 15:54

2005hithlj reviewed Apr 14, 2023

View reviewed changes

...lication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerMigrationTool.java Show resolved Hide resolved

2005hithlj reviewed Apr 14, 2023

View reviewed changes

hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Driver.java Outdated Show resolved Hide resolved

wchevreuil reviewed Apr 14, 2023

View reviewed changes

Apache9 force-pushed the HBASE-27728 branch from 6960335 to 1d11ce9 Compare April 14, 2023 15:32

HBASE-27728 Implement a tool to migrate replication peer data between…

92099a3

… different storage implementation

Apache9 force-pushed the HBASE-27728 branch from 1d11ce9 to 92099a3 Compare April 17, 2023 04:05

2005hithlj approved these changes Apr 17, 2023

View reviewed changes

wchevreuil approved these changes Apr 17, 2023

View reviewed changes

Apache9 merged commit 31c4aea into apache:master Apr 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-27728 Implement a tool to migrate replication peer data between… #5179

HBASE-27728 Implement a tool to migrate replication peer data between… #5179

Uh oh!

Apache9 commented Apr 13, 2023

Uh oh!

Apache-HBase commented Apr 13, 2023

Uh oh!

Apache-HBase commented Apr 13, 2023

Uh oh!

Apache-HBase commented Apr 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Apr 14, 2023

Uh oh!

Apache9 commented Apr 17, 2023

Uh oh!

2005hithlj commented Apr 17, 2023

Uh oh!

Apache-HBase commented Apr 17, 2023

Uh oh!

Apache-HBase commented Apr 17, 2023

Uh oh!

Apache-HBase commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HBASE-27728 Implement a tool to migrate replication peer data between… #5179

HBASE-27728 Implement a tool to migrate replication peer data between… #5179

Uh oh!

Conversation

Apache9 commented Apr 13, 2023

Uh oh!

Apache-HBase commented Apr 13, 2023

Uh oh!

Apache-HBase commented Apr 13, 2023

Uh oh!

Apache-HBase commented Apr 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Apr 14, 2023

Uh oh!

Apache9 commented Apr 17, 2023

Uh oh!

2005hithlj commented Apr 17, 2023

Uh oh!

Apache-HBase commented Apr 17, 2023

Uh oh!

Apache-HBase commented Apr 17, 2023

Uh oh!

Apache-HBase commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants