Skip to content

HBASE-27274 Re-enable the disabled tests when implementing HBASE-27212 #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

2005hithlj
Copy link
Contributor

@2005hithlj 2005hithlj requested a review from Apache9 April 13, 2023 15:00
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚 mvninstall 3m 54s HBASE-27109/table_based_rqs passed
+1 💚 compile 2m 32s HBASE-27109/table_based_rqs passed
+1 💚 checkstyle 0m 35s HBASE-27109/table_based_rqs passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 29s HBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 32s the patch passed
+1 💚 compile 2m 31s the patch passed
+1 💚 javac 2m 31s the patch passed
+1 💚 checkstyle 0m 34s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 52s Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 34s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
40m 46s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5178
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux fc7a07503cb9 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-27109/table_based_rqs / 2ea9c59
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Apr 13, 2023

Let's wait for the pre commit result.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 54s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚 mvninstall 3m 44s HBASE-27109/table_based_rqs passed
+1 💚 compile 0m 45s HBASE-27109/table_based_rqs passed
+1 💚 shadedjars 4m 27s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 27s HBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 27s the patch passed
+1 💚 compile 0m 49s the patch passed
+1 💚 javac 0m 49s the patch passed
+1 💚 shadedjars 4m 24s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 26s the patch passed
_ Other Tests _
-1 ❌ unit 230m 23s hbase-server in the patch failed.
254m 18s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5178
Optional Tests javac javadoc unit shadedjars compile
uname Linux c3ed4bfcb5ef 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-27109/table_based_rqs / 2ea9c59
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/testReport/
Max. process+thread count 2679 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 28s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚 mvninstall 4m 46s HBASE-27109/table_based_rqs passed
+1 💚 compile 1m 8s HBASE-27109/table_based_rqs passed
+1 💚 shadedjars 6m 16s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 37s HBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 28s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 shadedjars 6m 42s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 31s the patch passed
_ Other Tests _
-1 ❌ unit 263m 47s hbase-server in the patch failed.
295m 42s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5178
Optional Tests javac javadoc unit shadedjars compile
uname Linux 821ba2606fbc 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-27109/table_based_rqs / 2ea9c59
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/testReport/
Max. process+thread count 2684 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5178/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@2005hithlj
Copy link
Contributor Author

There are some failed UTs, but I found that they are not related to TestHBaseFsckReplication.

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's dig on the replication related test failures later.

@2005hithlj
Copy link
Contributor Author

In my local environment, TestReplicationValueCompressedWAL will still fail, but TestReplicationDroppedTables will succeed.

@Apache9
Copy link
Contributor

Apache9 commented Apr 18, 2023

In my local environment, TestReplicationValueCompressedWAL will still fail, but TestReplicationDroppedTables will succeed.

Oh, you can reproduce the failure of TestReplicationValueCompressedWAL locally? It has been flaky for a long time but it is really hard to reproduce the failure locally so no big progress on the fixing...
If you can reproduce it locally, could you please try to find out the root cause?

Thanks.

@Apache9 Apache9 merged commit 042c1e7 into apache:HBASE-27109/table_based_rqs Apr 18, 2023
@2005hithlj
Copy link
Contributor Author

In my local environment, TestReplicationValueCompressedWAL will still fail, but TestReplicationDroppedTables will succeed.

Oh, you can reproduce the failure of TestReplicationValueCompressedWAL locally? It has been flaky for a long time but it is really hard to reproduce the failure locally so no big progress on the fixing... If you can reproduce it locally, could you please try to find out the root cause?

Thanks.

OK, I will try to find out.

Apache9 pushed a commit that referenced this pull request Apr 18, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Apr 21, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Apr 23, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Apr 24, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Apr 25, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Apr 27, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request Apr 28, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request May 1, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request May 4, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request May 6, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request May 8, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request May 13, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request May 14, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9 pushed a commit that referenced this pull request May 15, 2023
#5178)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants