Skip to content

HBASE-27536: Include more request information in slowlog for Scans #5166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2023
Merged

HBASE-27536: Include more request information in slowlog for Scans #5166

merged 5 commits into from
Apr 16, 2023

Conversation

@rmdmattingly
Copy link
Contributor

@rmdmattingly rmdmattingly commented Apr 8, 2023

PR to master: #5155, solves HBASE-27536

Currently slow logs only includes a barebones text format of the underlying protobuf Message fields. Gets and Puts are relatively straightforward from a query cost perspective, but the configuration of Scans can have very significant performance implications.

With that in mind, we think it would be valuable to include the JSON representation of a given Scan to the slow log that it may produce.

@Apache-HBase
Copy link

Apache-HBase commented Apr 8, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 55s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 38s branch-2 passed
+1 💚 compile 2m 0s branch-2 passed
+1 💚 shadedjars 4m 36s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 12s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 40s root in the patch failed.
-1 ❌ compile 0m 8s hbase-protocol-shaded in the patch failed.
-1 ❌ compile 0m 18s hbase-client in the patch failed.
-1 ❌ compile 0m 31s hbase-server in the patch failed.
-0 ⚠️ javac 0m 8s hbase-protocol-shaded in the patch failed.
-0 ⚠️ javac 0m 18s hbase-client in the patch failed.
-0 ⚠️ javac 0m 31s hbase-server in the patch failed.
-1 ❌ shadedjars 1m 28s patch has 51 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 9s hbase-protocol-shaded in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 9s hbase-protocol-shaded in the patch failed.
+1 💚 unit 2m 14s hbase-common in the patch passed.
-1 ❌ unit 0m 19s hbase-client in the patch failed.
-1 ❌ unit 0m 31s hbase-server in the patch failed.
22m 33s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5166
Optional Tests javac javadoc unit shadedjars compile
uname Linux 61d6d51e4a0e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a67a8f7
Default Java Eclipse Adoptium-11.0.17+8
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-protocol-shaded.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-protocol-shaded.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/testReport/
Max. process+thread count 243 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 8, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 56s branch-2 passed
+1 💚 compile 4m 7s branch-2 passed
+1 💚 checkstyle 1m 9s branch-2 passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
+1 💚 spotbugs 4m 37s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 36s root in the patch failed.
-1 ❌ compile 0m 6s hbase-protocol-shaded in the patch failed.
-1 ❌ compile 0m 15s hbase-client in the patch failed.
-1 ❌ compile 0m 26s hbase-server in the patch failed.
-0 ⚠️ cc 0m 6s hbase-protocol-shaded in the patch failed.
-0 ⚠️ cc 0m 15s hbase-client in the patch failed.
-0 ⚠️ cc 0m 26s hbase-server in the patch failed.
-0 ⚠️ javac 0m 6s hbase-protocol-shaded in the patch failed.
-0 ⚠️ javac 0m 15s hbase-client in the patch failed.
-0 ⚠️ javac 0m 26s hbase-server in the patch failed.
+1 💚 checkstyle 1m 4s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hadoopcheck 0m 8s The patch causes 51 errors with Hadoop v2.10.2.
-1 ❌ hadoopcheck 0m 17s The patch causes 51 errors with Hadoop v3.2.4.
-1 ❌ hadoopcheck 0m 26s The patch causes 51 errors with Hadoop v3.3.4.
-1 ❌ hbaseprotoc 0m 6s hbase-protocol-shaded in the patch failed.
-1 ❌ hbaseprotoc 0m 15s hbase-client in the patch failed.
-1 ❌ hbaseprotoc 0m 26s hbase-server in the patch failed.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
-1 ❌ spotbugs 0m 6s hbase-protocol-shaded in the patch failed.
-1 ❌ spotbugs 0m 13s hbase-client in the patch failed.
-1 ❌ spotbugs 0m 22s hbase-server in the patch failed.
_ Other Tests _
+1 💚 asflicense 0m 26s The patch does not generate ASF License warnings.
24m 22s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5166
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 5dabd6124247 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a67a8f7
Default Java Eclipse Adoptium-11.0.17+8
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
cc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
cc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
cc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-protocol-shaded.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-protocol-shaded.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-protocol-shaded.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count 85 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 8, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 52s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for branch
+1 💚 mvninstall 4m 8s branch-2 passed
+1 💚 compile 2m 3s branch-2 passed
+1 💚 shadedjars 5m 19s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 3s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 40s root in the patch failed.
-1 ❌ compile 0m 7s hbase-protocol-shaded in the patch failed.
-1 ❌ compile 0m 17s hbase-client in the patch failed.
-1 ❌ compile 0m 36s hbase-server in the patch failed.
-0 ⚠️ javac 0m 7s hbase-protocol-shaded in the patch failed.
-0 ⚠️ javac 0m 17s hbase-client in the patch failed.
-0 ⚠️ javac 0m 36s hbase-server in the patch failed.
-1 ❌ shadedjars 2m 1s patch has 51 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 10s hbase-protocol-shaded in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 9s hbase-protocol-shaded in the patch failed.
+1 💚 unit 3m 1s hbase-common in the patch passed.
-1 ❌ unit 0m 27s hbase-client in the patch failed.
-1 ❌ unit 0m 35s hbase-server in the patch failed.
26m 14s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5166
Optional Tests javac javadoc unit shadedjars compile
uname Linux c0add2382427 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a67a8f7
Default Java Temurin-1.8.0_352-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-protocol-shaded.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-protocol-shaded.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-javadoc-hbase-protocol-shaded.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-protocol-shaded.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/testReport/
Max. process+thread count 246 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@rmdmattingly rmdmattingly force-pushed the rmattingly/branch-2/HBASE-27536 branch from a66f623 to 982cfcd Compare April 10, 2023 16:16
@Apache-HBase
Copy link

Apache-HBase commented Apr 10, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 41s branch-2 passed
+1 💚 compile 4m 13s branch-2 passed
+1 💚 checkstyle 1m 17s branch-2 passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
+1 💚 spotbugs 4m 42s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 4m 15s the patch passed
+1 💚 cc 4m 15s the patch passed
-0 ⚠️ javac 0m 44s hbase-client generated 1 new + 107 unchanged - 1 fixed = 108 total (was 108)
+1 💚 checkstyle 1m 17s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 17m 44s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚 hbaseprotoc 1m 43s the patch passed
+1 💚 spotless 0m 41s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 14s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
52m 46s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5166
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux f054ff2d7669 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a67a8f7
Default Java Eclipse Adoptium-11.0.17+8
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 10, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 58s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 20s branch-2 passed
+1 💚 compile 2m 1s branch-2 passed
+1 💚 shadedjars 4m 34s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 10s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 22s the patch passed
+1 💚 compile 2m 7s the patch passed
+1 💚 javac 2m 7s the patch passed
+1 💚 shadedjars 4m 34s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 13s hbase-common in the patch passed.
+1 💚 unit 8m 9s hbase-client in the patch passed.
+1 💚 unit 214m 26s hbase-server in the patch passed.
254m 34s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5166
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9bdeb71c3753 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a67a8f7
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/testReport/
Max. process+thread count 2287 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 10, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 42s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 52s branch-2 passed
+1 💚 compile 1m 44s branch-2 passed
+1 💚 shadedjars 4m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 5s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 44s the patch passed
+1 💚 compile 1m 43s the patch passed
+1 💚 javac 1m 43s the patch passed
+1 💚 shadedjars 4m 8s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 5s the patch passed
_ Other Tests _
+1 💚 unit 0m 27s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 0s hbase-common in the patch passed.
+1 💚 unit 7m 56s hbase-client in the patch passed.
-1 ❌ unit 221m 23s hbase-server in the patch failed.
263m 23s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5166
Optional Tests javac javadoc unit shadedjars compile
uname Linux 50ff19988abf 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / a67a8f7
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/testReport/
Max. process+thread count 2233 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 10, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s branch-2 passed
+1 💚 compile 4m 16s branch-2 passed
+1 💚 checkstyle 1m 10s branch-2 passed
+1 💚 spotless 0m 44s branch has no errors when running spotless:check.
+1 💚 spotbugs 4m 39s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 4m 13s the patch passed
+1 💚 cc 4m 13s the patch passed
+1 💚 javac 4m 13s the patch passed
+1 💚 checkstyle 1m 7s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 19m 36s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚 hbaseprotoc 1m 39s the patch passed
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 8s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
54m 39s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5166
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool
uname Linux 43f306f2d6d6 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 0848936
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 11, 2023

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 0s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 3m 22s branch-2 passed
+1 💚 compile 2m 1s branch-2 passed
+1 💚 shadedjars 4m 34s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 10s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 25s the patch passed
+1 💚 compile 2m 2s the patch passed
+1 💚 javac 2m 2s the patch passed
+1 💚 shadedjars 4m 36s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 5s the patch passed
_ Other Tests _
+1 💚 unit 0m 35s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 11s hbase-common in the patch passed.
+1 💚 unit 8m 5s hbase-client in the patch passed.
+1 💚 unit 213m 51s hbase-server in the patch passed.
253m 48s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5166
Optional Tests javac javadoc unit shadedjars compile
uname Linux a8beea3de350 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 0848936
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/testReport/
Max. process+thread count 2265 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Apr 11, 2023

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 38s branch-2 passed
+1 💚 compile 1m 43s branch-2 passed
+1 💚 shadedjars 4m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 5s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 39s the patch passed
+1 💚 compile 1m 44s the patch passed
+1 💚 javac 1m 44s the patch passed
+1 💚 shadedjars 4m 11s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 4s the patch passed
_ Other Tests _
+1 💚 unit 0m 28s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 59s hbase-common in the patch passed.
+1 💚 unit 7m 49s hbase-client in the patch passed.
-1 ❌ unit 220m 24s hbase-server in the patch failed.
256m 58s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5166
Optional Tests javac javadoc unit shadedjars compile
uname Linux a3a53ca65193 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 0848936
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/testReport/
Max. process+thread count 2170 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5166/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani changed the title "HBASE-27536: add Scan to slow log payload" to branch-2 HBASE-27536: add Scan to slow log payload Apr 12, 2023
@virajjasani virajjasani added the backport This PR is a back port of some issue or issues already committed to master label Apr 12, 2023
@virajjasani virajjasani changed the title HBASE-27536: add Scan to slow log payload HBASE-27536: Include more request information in slowlog for Scans Apr 12, 2023
@bbeaudreault bbeaudreault merged commit 1ae057b into apache:branch-2 Apr 16, 2023
@bbeaudreault bbeaudreault deleted the rmattingly/branch-2/HBASE-27536 branch April 16, 2023 14:11
rmdmattingly added a commit to HubSpot/hbase that referenced this pull request Apr 18, 2023
@rmdmattingly
HBASE-27536: Include more request information in slowlog for Scans (a…
60cb5c4 
…pache#5166)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@rmdmattingly rmdmattingly mentioned this pull request Apr 18, 2023
Merged
rmdmattingly added a commit to HubSpot/hbase that referenced this pull request Apr 18, 2023
@rmdmattingly
HBASE-27536: Include more request information in slowlog for Scans (a…
bbb3324 
…pache#5166) (#51)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmdmattingly @Apache-HBase @bbeaudreault @virajjasani