HBASE-27775 Use a separate WAL provider for hbase:replication table #5157

Apache9 · 2023-04-04T11:25:23Z

No description provided.

Apache9 · 2023-04-04T11:26:58Z

This is for fixing the TestMultiSlaveReplication, and also to avoid generating a lot of useless data in hbase:replication table, while nothing written to the cluster.

The current implementation may still not enough as we may still track the WAL file for hbase:replication, but anyway it will not mess up the normal WAL files.

Will dig more and report back here.

Apache-HBase · 2023-04-04T12:32:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 55s	HBASE-27109/table_based_rqs passed
+1 💚	compile	3m 53s	HBASE-27109/table_based_rqs passed
+1 💚	checkstyle	1m 12s	HBASE-27109/table_based_rqs passed
+1 💚	spotless	1m 9s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 56s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 1s	the patch passed
+1 💚	compile	3m 39s	the patch passed
+1 💚	javac	3m 39s	the patch passed
+1 💚	checkstyle	0m 53s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 9s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	1m 7s	patch has no errors when running spotless:check.
+1 💚	spotbugs	3m 15s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		61m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 927a6af6ea18 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `49589ef`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-04-04T14:55:08Z

OK, confirmed, there is no problem. We will add a WALActionListener in Replication for tracking the WAL files which need to be replicated, and it will only add the listener to user space WALProvider, so we are safe here.

Apache-HBase · 2023-04-04T15:29:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 56s	HBASE-27109/table_based_rqs passed
+1 💚	compile	0m 44s	HBASE-27109/table_based_rqs passed
+1 💚	shadedjars	4m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 42s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	4m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 23s	hbase-replication in the patch passed.
+1 💚	unit	216m 56s	hbase-server in the patch passed.
		239m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 958c7f1fbd1c 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `49589ef`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/testReport/
Max. process+thread count	2700 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-04T15:38:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 50s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 28s	HBASE-27109/table_based_rqs passed
+1 💚	compile	1m 0s	HBASE-27109/table_based_rqs passed
+1 💚	shadedjars	4m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	4m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-replication in the patch passed.
-1 ❌	unit	222m 20s	hbase-server in the patch failed.
		247m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a7754d38a587 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `49589ef`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/testReport/
Max. process+thread count	2819 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-04T16:41:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 28s	HBASE-27109/table_based_rqs passed
+1 💚	compile	3m 38s	HBASE-27109/table_based_rqs passed
+1 💚	checkstyle	0m 47s	HBASE-27109/table_based_rqs passed
+1 💚	spotless	0m 51s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 9s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 47s	the patch passed
+1 💚	compile	4m 25s	the patch passed
+1 💚	javac	4m 25s	the patch passed
+1 💚	checkstyle	1m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 31s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	1m 3s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 59s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		62m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 4b92f3fd3627 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `49589ef`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-04T19:38:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s	HBASE-27109/table_based_rqs passed
+1 💚	compile	0m 44s	HBASE-27109/table_based_rqs passed
+1 💚	shadedjars	4m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	0m 43s	the patch passed
+1 💚	javac	0m 43s	the patch passed
+1 💚	shadedjars	4m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 22s	hbase-replication in the patch passed.
+1 💚	unit	217m 7s	hbase-server in the patch passed.
		239m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8bf5210e32d6 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `49589ef`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/2/testReport/
Max. process+thread count	3239 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-06T00:17:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 48s	HBASE-27109/table_based_rqs passed
+1 💚	compile	2m 45s	HBASE-27109/table_based_rqs passed
+1 💚	checkstyle	0m 41s	HBASE-27109/table_based_rqs passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 49s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	2m 40s	the patch passed
+1 💚	javac	2m 40s	the patch passed
+1 💚	checkstyle	0m 39s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 2s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 5s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		42m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 9171c915f202 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `f78fe59`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	81 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-06T12:16:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 46s	HBASE-27109/table_based_rqs passed
+1 💚	compile	3m 21s	HBASE-27109/table_based_rqs passed
+1 💚	checkstyle	0m 58s	HBASE-27109/table_based_rqs passed
+1 💚	spotless	0m 58s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 32s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 43s	the patch passed
+1 💚	compile	4m 15s	the patch passed
+1 💚	javac	4m 15s	the patch passed
+1 💚	checkstyle	1m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 6s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	1m 6s	patch has no errors when running spotless:check.
+1 💚	spotbugs	3m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 23s	The patch does not generate ASF License warnings.
		64m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 034e447686f5 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `f78fe59`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-06T15:33:33Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 34s	HBASE-27109/table_based_rqs passed
+1 💚	compile	1m 1s	HBASE-27109/table_based_rqs passed
+1 💚	shadedjars	4m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	4m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 28s	hbase-replication in the patch passed.
-1 ❌	unit	235m 26s	hbase-server in the patch failed.
		261m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ac3673b3d7e1 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `f78fe59`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/4/testReport/
Max. process+thread count	2859 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2023-04-07T02:14:20Z

@Apache9 sir.
Also, do we need to add a new UT to cover our newly added code?

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/LazyInitializedWALProvider.java

Apache9 · 2023-04-07T07:53:01Z

I think we could add a UT to confirm that we write the WAL for hbase:replication to a separated file.

Apache9 · 2023-04-07T13:02:24Z

I think we could add a UT to confirm that we write the WAL for hbase:replication to a separated file.

Done.

@2005hithlj PTAL.

Thanks.

Apache-HBase · 2023-04-07T14:00:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 1s	HBASE-27109/table_based_rqs passed
+1 💚	compile	3m 1s	HBASE-27109/table_based_rqs passed
+1 💚	checkstyle	0m 47s	HBASE-27109/table_based_rqs passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 0s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 51s	the patch passed
+1 💚	compile	2m 48s	the patch passed
+1 💚	javac	2m 48s	the patch passed
+1 💚	checkstyle	0m 42s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 16s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 11s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		44m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 6d3554003e64 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `f78fe59`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-04-07T17:29:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-27109/table_based_rqs Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s	HBASE-27109/table_based_rqs passed
+1 💚	compile	0m 59s	HBASE-27109/table_based_rqs passed
+1 💚	shadedjars	4m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	HBASE-27109/table_based_rqs passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	4m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-replication in the patch passed.
-1 ❌	unit	228m 57s	hbase-server in the patch failed.
		253m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5157
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c17ceca693c4 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-27109/table_based_rqs / `f78fe59`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/5/testReport/
Max. process+thread count	2465 (vs. ulimit of 30000)
modules	C: hbase-replication hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5157/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

2005hithlj · 2023-04-08T01:33:40Z

@Apache9 sir LTGM.
But some UTs failed, and it's unclear whether it's related to our code changes?

Apache9 · 2023-04-08T02:20:04Z

Let me check the test logs for the failed UT.

Apache9 · 2023-04-08T02:50:13Z

Posted the findings on HBASE-27277, TestRaceBetweenSCPAndTRSP is known to be flaky for a while, only in pre commit, anyway.

Let me merge this first.

We need to keep an eye on the nightly result for branch HBASE-27109, to fix the unstable tests.

Thanks.

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 requested a review from 2005hithlj April 4, 2023 11:25

Apache9 self-assigned this Apr 4, 2023

Apache9 force-pushed the HBASE-27775 branch from 10bc7ba to 68553cc Compare April 4, 2023 14:54

Apache9 force-pushed the HBASE-27109/table_based_rqs branch from ba5488b to f78fe59 Compare April 5, 2023 15:47

HBASE-27775 Use a separate WAL provider for hbase:replication table

d51981f

Apache9 force-pushed the HBASE-27775 branch from 68553cc to d51981f Compare April 5, 2023 15:48

2005hithlj reviewed Apr 7, 2023

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/LazyInitializedWALProvider.java Show resolved Hide resolved

add tests

39b1173

2005hithlj approved these changes Apr 8, 2023

View reviewed changes

Apache9 merged commit 2ea9c59 into apache:HBASE-27109/table_based_rqs Apr 8, 2023

Apache9 added a commit that referenced this pull request Apr 18, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

365aec3

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request Apr 21, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

545c1df

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request Apr 23, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

6f5d1cf

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request Apr 24, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

e96ce5d

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request Apr 25, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

9ccef17

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request Apr 27, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

2e1a5b2

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request Apr 28, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

e0ba400

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request May 1, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

0377142

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request May 4, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

c25a63f

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request May 6, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

2989713

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request May 8, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

e174938

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request May 13, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

081ac53

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request May 14, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

565ff49

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

Apache9 added a commit that referenced this pull request May 15, 2023

HBASE-27775 Use a separate WAL provider for hbase:replication table (#…

8fe691c

…5157) Signed-off-by: Liangjun He <heliangjun@apache.org>

HBASE-27775 Use a separate WAL provider for hbase:replication table #5157

HBASE-27775 Use a separate WAL provider for hbase:replication table #5157

Uh oh!

Conversation

Apache9 commented Apr 4, 2023

Uh oh!

Apache9 commented Apr 4, 2023

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

Apache9 commented Apr 4, 2023

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

Apache-HBase commented Apr 4, 2023

Uh oh!

Apache-HBase commented Apr 6, 2023

Uh oh!

Apache-HBase commented Apr 6, 2023

Uh oh!

Apache-HBase commented Apr 6, 2023

Uh oh!

2005hithlj commented Apr 7, 2023

Uh oh!

Uh oh!

Apache9 commented Apr 7, 2023

Uh oh!

Apache9 commented Apr 7, 2023

Uh oh!

Apache-HBase commented Apr 7, 2023

Uh oh!

Apache-HBase commented Apr 7, 2023

Uh oh!

2005hithlj commented Apr 8, 2023

Uh oh!

Apache9 commented Apr 8, 2023

Uh oh!

Apache9 commented Apr 8, 2023

Uh oh!

Uh oh!