-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-27599 Cleanup wrong dependency in dependencyManagement #4999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
bedacb4
to
5d1bcde
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@@ -151,6 +151,7 @@ | |||
<dependency> | |||
<groupId>org.apache.hadoop</groupId> | |||
<artifactId>hadoop-common</artifactId> | |||
<version>${hadoop.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the version in dependencyManagement section in the parent pom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the version in dependencyManagement section in the parent pom?
I tried to add it to root pom but found some other confusion.
We do have a hadoop-common in dependencyManagement:
Line 3918 in 8e72cc6
<type>test-jar</type> |
But there seems to be a problem with this way of writing. Why do you need to specify both classifier and type? It seems that the correct jar cannot be located with these way. Not only hadoop-common, hadoop-hdfs also has this problem.
So if I'm correct, this seems to be a bug? Should we remove the classifier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<classifier>tests</classifier>
<type>jar</type>
and
<type>test-jar</type>
can both work, but
<classifier>tests</classifier>
<type>test-jar</type>
can't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's do a cleanup in the dependencyManagement section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's do a cleanup in the dependencyManagement section?
I think so. If you don't mind, could we just merge this PR and #5000 at first? I'd like to open another ticket for the new problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Will push a new fix later.
🎊 +1 overall
This message was automatically generated. |
Please change the title of the jira? It is not 'add version of hadoop common test jar' any more... |
Done. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
No description provided.