HBASE-27395 Adding description to Prometheus metrics #4807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I5f76b741c3419c4f2d355252d9a958ee48784257
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
payert
reviewed
Oct 3, 2022
| String tmpStr = req.getParameter("description"); | ||
| boolean description = tmpStr != null && tmpStr.equals("true"); | ||
|
|
||
| writeMetrics(resp.getWriter(), description); |
There was a problem hiding this comment.
This could be compacted like this:
writeMetrics(resp.getWriter(), "true".equals(req.getParameter("description")));
There was a problem hiding this comment.
I totally agree, should have noticed that. Thank you!
| @@ -57,13 +60,19 @@ static String toPrometheusName(String metricRecordName, String metricName) { | |||
| */ | |||
| @RestrictedApi(explanation = "Should only be called in tests or self", link = "", | |||
| allowedOnPath = ".*/src/test/.*|.*/PrometheusHadoopServlet\\.java") | |||
| void writeMetrics(Writer writer) throws IOException { | |||
| void writeMetrics(Writer writer, boolean desc) throws IOException { | |||
There was a problem hiding this comment.
Maybe 'describe' is better argument name than 'desc'.
There was a problem hiding this comment.
I use 'desc', because 'description' is used as a local variable name in the function
|
|
||
| if (desc) { | ||
| String description = metrics.description(); | ||
| if (!description.isEmpty()) writer.append("# HELP ").append(description).append("\n"); |
There was a problem hiding this comment.
When you append a single char to the writer you can use the append(char c) instead if of append(CharSequence csq). I mean
.append('\n')
instead of
.append("\n")
Doesn't make much difference but slightly cheaper..
There was a problem hiding this comment.
I fixed it, thanks for the info!
Notes: - Made some improvements in the code based on the review
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
meszibalu
approved these changes
Oct 7, 2022
asfgit
pushed a commit
that referenced
this pull request
Oct 7, 2022
Signed-off-by: Tamas Payer <payert@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Tamas Payer <payert@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit f5df769) Change-Id: I7718263ee568a51bab9ed4ed03b0e26f915ab31c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can access metrics description while using '/prometheus' endpoint via "description=true" URL parameter.
Example:
http://HOSTNAME:16010/prometheus?description=trueApache JIRA: https://issues.apache.org/jira/browse/HBASE-27395