-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-27335 HBase shell hang for a minute when quiting #4737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Apache9 sir. Could you take a look? Thanks. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
When quiting, we will not close this connection? |
@Apache9 sir. Thanks for your review. |
I prefer we first find out why the daemon thread does not quit, because we do not close the connection? Or we have closed the connection but haven't shutdown the thread pool? |
I think the problem is that, we defined a shutdown method in hbase.rb where we close the connection in this method, but we never call it in our code base... I'm not a ruby expert so I'm not sure how to call shutdown when we see 'exit', as seems there is no 'exit' command defined in our code base... |
Apply this to branch-2.5 can make the shell quit immediately when typing 'exit' command, but when calling 'quit' command it will still hang there... I'm not sure how we do we deal with the 'quit' command... |
Yes, the 'quit' command is really a difficult thing to deal with. I searched the ruby IRB for info about the 'quit' command, and there is not much info to refer to. |
Anyway, let's apply this PR to fix the problem first. Please open another issue to track the 'releasing resources when quiting IRB' problem @2005hithlj . Thanks. |
@Apache9 OK, sir. |
I have created an issue to track this issue: |
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 6a7a91a)
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 6a7a91a)
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 6a7a91a)
https://issues.apache.org/jira/browse/HBASE-27335