-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-26553 OAuth Bearer authentication mech plugin for SASL #4733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall if we can reused the reviews in HBASE-26655, HBASE-26665, HBASE-26667 that merged into the feature branch of HBASE-26553, this is just the same commits with minor fixed for the loadJwkSet()
. But if you're looking a new round of reviews, please let me know.
below are two minor comments that isn't a blocker for this PR.
- [nit] HBASE-26655, HBASE-26665, HBASE-26667 was reviewed as part of the feature HBASE-26553 , but why HBASE-26655 does not have a link to HBASE-26553 OAuth Bearer authentication mech plugin for SASL (initial commit) #4019 ?
- [nit] for the minimum configuration mentioned in the description, don't we also need to configure the environment parameter of
HBASE_JWT
for the client? maybe we should tell the minimum configuration for the client and server separately in the doc ?
Thanks @taklwu , I've updated the minimum configuration in the description with more details. Sorry for the confusion, I've decided to abandon the feature branch to speed up the rebasing and the process. Please let me know if you think it would be better to go back and continue working on the feature branch instead.
I see the link in the jira. |
Adds a new SASL mech plugin for OAuthBearer (JWT) authentication.
Minimum configuration to enable JWT auth:
Server side:
Client side:
The client also has to be in possession of a valid JWT token which must set via environment variable:
cc @petersomogyi @meszibalu @joshelser @bbeaudreault @Apache9