Skip to content

HBASE-27017: MOB snapshot is broken when FileBased SFT is used #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2022
Merged

HBASE-27017: MOB snapshot is broken when FileBased SFT is used #4466

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e96c71
HBASE-27017: MOB snapshot is broken when FileBased SFT is used
BukrosSzabolcs May 26, 2022
45050ad
HBASE-27017: MOB snapshot is broken when FileBased SFT is used
BukrosSzabolcs May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
import org.apache.hadoop.hbase.client.RegionInfo;
import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.errorhandling.ForeignExceptionSnare;
Expand Down Expand Up @@ -310,7 +311,17 @@ protected void addRegion(Path tableDir, RegionInfo regionInfo, RegionVisitor vis
for (ColumnFamilyDescriptor cfd : htd.getColumnFamilies()) {
Object familyData = visitor.familyOpen(regionData, cfd.getName());
monitor.rethrowException();
StoreFileTracker tracker = StoreFileTrackerFactory.create(conf, htd, cfd, regionFs);
StoreFileTracker tracker = null;
if (isMobRegion) {
// MOB regions are always using the default SFT implementation
ColumnFamilyDescriptor defaultSFTCfd = ColumnFamilyDescriptorBuilder.newBuilder(cfd)
.setValue(StoreFileTrackerFactory.TRACKER_IMPL,
StoreFileTrackerFactory.Trackers.DEFAULT.name())
.build();
tracker = StoreFileTrackerFactory.create(conf, htd, defaultSFTCfd, regionFs);
} else {
tracker = StoreFileTrackerFactory.create(conf, htd, cfd, regionFs);
}
List<StoreFileInfo> storeFiles = tracker.load();
if (storeFiles.isEmpty()) {
LOG.debug("No files under family: {}", cfd.getNameAsString());
Expand Down