HBASE-26960 Another case for unnecessary replication suspending in Re… #4355

comnetwork · 2022-04-19T10:30:21Z

…gionReplicationSink

Apache-HBase · 2022-04-19T11:24:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 15s	master passed
+1 💚	compile	2m 48s	master passed
+1 💚	checkstyle	0m 39s	master passed
+1 💚	spotbugs	1m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	2m 35s	the patch passed
+1 💚	javac	2m 35s	the patch passed
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 4s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		43m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 164cdef935b4 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `35aa57e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-19T13:51:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 42s	master passed
+1 💚	compile	0m 41s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	compile	0m 40s	the patch passed
+1 💚	javac	0m 40s	the patch passed
+1 💚	shadedjars	3m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	173m 44s	hbase-server in the patch passed.
		191m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 506c337fc0d0 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `35aa57e`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/testReport/
Max. process+thread count	3503 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-19T14:16:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 17s	master passed
+1 💚	compile	0m 52s	master passed
+1 💚	shadedjars	4m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 59s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	4m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	192m 59s	hbase-server in the patch passed.
		215m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9a53d5a5af1e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `35aa57e`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/testReport/
Max. process+thread count	2546 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-04-21T06:45:58Z

This will cause we write extra data in WAL.

Maybe a more lightweight solution is to call RegionReplicationSink.add even when writeFlushWalMarker is false?

comnetwork · 2022-04-21T08:34:22Z

@Apache9 , RegionReplicationSink.add is invoked by MultiVersionConcurrencyControl.complete(WriteEntry), so it seems not very elegant and somewhat tricky to not write WAL but still invoke RegionReplicationSink.add.

I think an alternative is we could add an overload MemStoreFlusher.requestFlush to accept the writeFlushRequestWalMarker paramter which is only used by RegionReplicationSink, just some modifications for MemStoreFlusher, I think seems it is more suitable than doing some trick to not write WAL but still invoke RegionReplicationSink.add?

Apache9 · 2022-04-21T08:38:40Z

@Apache9 , RegionReplicationSink.add is invoked by MultiVersionConcurrencyControl.complete(WriteEntry), so it seems not very elegant and somewhat tricky to not write WAL but still invoke RegionReplicationSink.add.

I think we could add an overload MemStoreFlusher.requestFlush to accept the writeFlushRequestWalMarker paramter，just some modifications for {{MemStoreFlusher}}, I think seems it is more suitable than doing some trick to not write WAL but still invoke RegionReplicationSink.add?

I think it is OK to not write the WAL but still add it to RegionReplicationSink.

A problem for the old implementation of region replication is that, if users use SKIP_WAL, then we can not do region replication any more. WIth the current approach, since we do not need to read WAL from the file, it is OK for us to send out WAL even if we do not want to write the WAL to file.

This one could a start. Later we could also try to see if the actual data WAL can be replicated when SKIP_WAL is used.

Thanks.

Apache9 · 2022-04-21T08:49:34Z

OK, checked the code again, the problem here is that, if we do not write WAL, then we will not have a MVCC.WriteEntry then we can not use WriteEntry.attachCompletionAction trick.

This is a problem. Let me think if there is a way to fix this.

Thanks.

comnetwork · 2022-04-21T08:57:32Z

@Apache9, thank you very much , ok, I think we could also add a MVCC entry to maintain the MVCC order to invoke the RegionReplicationSink.add?

Apache9 · 2022-04-28T14:54:20Z

Oh, at least for calling writeFlushRequestMarkerToWAL, we do have a MVCC.WriteEntry...

So let's pass it in to the method and also add the WALEntry to RegionReplicationSink.

And for the normal updates, we will not build the WALEntry, and we will create a MVCC WriteEntry when applying updates to memstore, in MutationBatchOperation.writeMiniBatchOperationsToMemStore. FWIW, we always need a MVCC WriteEntry to finish a write operation. So I think it is possible to also replicate the edits to secondary replicas even if we set SKIP_WAL. Anyway, should be another issue.

Thanks.

comnetwork · 2022-04-29T07:48:12Z

@Apache9 ,thank you very much for reply.

Oh, at least for calling writeFlushRequestMarkerToWAL, we do have a MVCC.WriteEntry...

So let's pass it in to the method and also add the WALEntry to RegionReplicationSink.

You mean we use the following line 2793 outside the writeFlushRequestMarkerToWAL?

2792       if (wal != null) {
2793              writeEntry = mvcc.begin();
2794               long flushOpSeqId = writeEntry.getWriteNumber();
2795               FlushResultImpl flushResult =
2796                   new FlushResultImpl(FlushResult.Result.CANNOT_FLUSH_MEMSTORE_EMPTY, flushOpSeqId,
2797                         "Nothing to flush", writeFlushRequestMarkerToWAL(wal, writeFlushWalMarker));
2798              mvcc.completeAndWait(writeEntry);
2799               // Set to null so we don't complete it again down in finally block.
2800              writeEntry = null;
2801              return new PrepareFlushResult(flushResult, myseqid);

comnetwork · 2022-04-29T08:00:04Z

And for the normal updates, we will not build the WALEntry, and we will create a MVCC WriteEntry when applying updates to memstore, in MutationBatchOperation.writeMiniBatchOperationsToMemStore. FWIW, we always need a MVCC WriteEntry to finish a write operation. So I think it is possible to also replicate the edits to secondary replicas even if we set SKIP_WAL. Anyway, should be another issue.

@Apache9 , I open a new jira HBASE-26993 to try to work on this problem.

Apache-HBase · 2022-04-29T10:50:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 56s	master passed
+1 💚	compile	2m 55s	master passed
+1 💚	checkstyle	0m 42s	master passed
+1 💚	spotbugs	1m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 0s	the patch passed
+1 💚	compile	3m 3s	the patch passed
+1 💚	javac	3m 3s	the patch passed
+1 💚	checkstyle	0m 43s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 48s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		37m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 1381c595d6ba 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebfac21`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	67 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-29T13:36:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 33s	master passed
+1 💚	compile	0m 36s	master passed
+1 💚	shadedjars	4m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 20s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	4m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	184m 57s	hbase-server in the patch passed.
		203m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 33d6176d7a0c 5.4.0-1068-aws #72~18.04.1-Ubuntu SMP Thu Mar 3 08:49:49 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebfac21`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/testReport/
Max. process+thread count	2598 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-04-29T13:42:46Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

   * @return whether WAL write was successful
   */
-  private boolean writeFlushRequestMarkerToWAL(WAL wal, boolean writeFlushWalMarker) {
+  private boolean writeCanNotFlushMarkerToWAL(WriteEntry flushOpSeqIdMVCCEntry, WAL wal,


Good. The new method name is better.

Apache-HBase · 2022-04-29T13:56:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 54s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	3m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	3m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	199m 26s	hbase-server in the patch passed.
		218m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 73c3ea812a81 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebfac21`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/testReport/
Max. process+thread count	2684 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-29T14:33:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 28s	master passed
+1 💚	compile	2m 33s	master passed
+1 💚	checkstyle	0m 43s	master passed
+1 💚	spotbugs	1m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 7s	the patch passed
+1 💚	compile	2m 54s	the patch passed
+1 💚	javac	2m 54s	the patch passed
+1 💚	checkstyle	0m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 53s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 42s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		36m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux cff7943dc703 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebfac21`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-29T17:07:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 39s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 23s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	3m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	173m 26s	hbase-server in the patch passed.
		189m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c211c360404c 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebfac21`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/testReport/
Max. process+thread count	2941 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-04-29T17:23:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 28s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 13s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	shadedjars	3m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	189m 31s	hbase-server in the patch passed.
		206m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4355
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0a8a867acd47 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ebfac21`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/testReport/
Max. process+thread count	3119 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4355/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-26960 Another case for unnecessary replication suspending in Re…

71ff33d

…gionReplicationSink

comnetwork requested a review from Apache9 April 20, 2022 02:27

not set writeFlushMarker to false

1313486

add comments

05049b7

Apache9 approved these changes Apr 29, 2022

View reviewed changes

comnetwork merged commit f5a566e into apache:master Apr 30, 2022

HBASE-26960 Another case for unnecessary replication suspending in Re… #4355

HBASE-26960 Another case for unnecessary replication suspending in Re… #4355

Uh oh!

Conversation

comnetwork commented Apr 19, 2022

Uh oh!

Apache-HBase commented Apr 19, 2022

Uh oh!

Apache-HBase commented Apr 19, 2022

Uh oh!

Apache-HBase commented Apr 19, 2022

Uh oh!

Apache9 commented Apr 21, 2022

Uh oh!

comnetwork commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache9 commented Apr 21, 2022

Uh oh!

Apache9 commented Apr 21, 2022

Uh oh!

comnetwork commented Apr 21, 2022

Uh oh!

Apache9 commented Apr 28, 2022

Uh oh!

comnetwork commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

comnetwork commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Apr 29, 2022

Uh oh!

Apache-HBase commented Apr 29, 2022

Uh oh!

Apache9 Apr 29, 2022

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Apr 29, 2022

Uh oh!

Apache-HBase commented Apr 29, 2022

Uh oh!

Apache-HBase commented Apr 29, 2022

Uh oh!

Apache-HBase commented Apr 29, 2022

Uh oh!

Uh oh!

comnetwork commented Apr 21, 2022 •

edited

Loading

comnetwork commented Apr 29, 2022 •

edited

Loading

comnetwork commented Apr 29, 2022 •

edited

Loading