HBASE-26630 TableSnapshotInputFormat terminates in the middle #4215

hyeongseok85 · 2022-03-14T03:02:32Z

https://issues.apache.org/jira/browse/HBASE-26630

When using SingleColumnValueFilter in TableSnapshotInputFormat, there was a problem that the job was terminated in the middle

…ormat, there was a problem that the job was terminated in the middle

anoopsjohn · 2022-03-14T03:22:55Z

hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java

+      moreValues = scanner.nextRaw(values);
+    } while (values.isEmpty() && moreValues);
+
+    if (!moreValues) {


We will see empty result (values) but still more rows when the scan met RPC timeout value? Will it be possible to have UT here?

Scan is not an RPC timeout situation. After scannerContext.returnImmediately() is called in storeScanner, it is returned as true by scannerContext.checkTimeLimit(limitScope) in RegionScannerImpl.

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java#L563

Apache-HBase · 2022-03-14T03:57:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 5s	master passed
+1 💚	compile	3m 35s	master passed
+1 💚	checkstyle	0m 53s	master passed
+1 💚	spotbugs	2m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
+1 💚	compile	3m 33s	the patch passed
+1 💚	javac	3m 33s	the patch passed
+1 💚	checkstyle	0m 49s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 58s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		46m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4215
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 1d1a48b5339e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c3d0cc7`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T09:06:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	0m 47s	master passed
+1 💚	shadedjars	4m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 11s	the patch passed
+1 💚	compile	0m 49s	the patch passed
+1 💚	javac	0m 49s	the patch passed
+1 💚	shadedjars	4m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
-1 ❌	unit	335m 23s	hbase-server in the patch failed.
		355m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3a405489018e 5.4.0-1054-aws #57~18.04.1-Ubuntu SMP Thu Jul 15 03:21:36 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c3d0cc7`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/testReport/
Max. process+thread count	2745 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T09:18:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	4m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 43s	the patch passed
+1 💚	javac	0m 43s	the patch passed
+1 💚	shadedjars	4m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	348m 43s	hbase-server in the patch failed.
		368m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2a60a6475c8d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c3d0cc7`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/testReport/
Max. process+thread count	2850 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4215/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-26630 When using SingleColumnValueFilter in TableSnapshotInputF…

6180e56

…ormat, there was a problem that the job was terminated in the middle

anoopsjohn reviewed Mar 14, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-26630 TableSnapshotInputFormat terminates in the middle #4215

HBASE-26630 TableSnapshotInputFormat terminates in the middle #4215

hyeongseok85 commented Mar 14, 2022

Uh oh!

anoopsjohn Mar 14, 2022

Uh oh!

hyeongseok85 Mar 15, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Uh oh!

HBASE-26630 TableSnapshotInputFormat terminates in the middle #4215

Are you sure you want to change the base?

HBASE-26630 TableSnapshotInputFormat terminates in the middle #4215

Conversation

hyeongseok85 commented Mar 14, 2022

Uh oh!

anoopsjohn Mar 14, 2022

Choose a reason for hiding this comment

Uh oh!

hyeongseok85 Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Apache-HBase commented Mar 14, 2022

Uh oh!

Uh oh!