HBASE-26797 HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta #4161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning hbase 2.x meta
bbeaudreault
commented
Mar 3, 2022
| @@ -220,6 +220,7 @@ private static Result getClosestRowOrBefore(final Table metaTable, final TableNa | |||
| throws IOException { | |||
| byte[] searchRow = HRegionInfo.createRegionName(userTableName, row, HConstants.NINES, false); | |||
| Scan scan = Scan.createGetClosestRowOrBeforeReverseScan(searchRow); | |||
| scan.addFamily(HConstants.CATALOG_FAMILY); | |||
There was a problem hiding this comment.
The real error comes from ConnectionManager, but I tried to audit all reads against meta table and this was the only other one (that I could find) which did not have a family specified. I figured I should add it while I'm here even if we haven't hit an issue with this yet.
|
🎊 +1 overall
This message was automatically generated. |
apurtell
approved these changes
Mar 4, 2022
|
Thanks for the review, I'll add that tomorrow. |
|
@apurtell done -- I'm assuming that's for added protection against a future regression, given the lack of a test. But correct me if I'm wrong, for my own edification. |
|
💔 -1 overall
This message was automatically generated. |
bbeaudreault
force-pushed
the
HBASE-26797
branch
from
1a42a24 to
870b815
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Correct, its so we know not to remove them without thought toward this issue since there isn't a test for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it really hard to add a test case for this. I think i'd need to modify meta to add a dummy extra CF and then put a bad row in there and validate that it gets ignored by these reads. That should be straightforward, but alters to meta are disallowed in a few places. I could probably add some sort of internal-only config to disable those checks for the purpose of test, or maybe a setter which sets a volatile value? It's hard to access them from the TestingUtility, but maybe doable. Let me know if you'd like me to go through those efforts to test this, but I think it might not be worth it?