Skip to content

HBASE-26673 Implement a shell command for change SFT implementation #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions hbase-shell/src/main/ruby/hbase/admin.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1825,6 +1825,18 @@ def to_server_names(server_names)
java.util.Arrays.asList(server_names)
end
end

#----------------------------------------------------------------------------------------------
# Change table's sft
def modify_table_sft(tableName, sft)
@admin.modifyTableStoreFileTracker(tableName, sft)
end

#----------------------------------------------------------------------------------------------
# Change table column family's sft
def modify_table_family_sft(tableName, family_bytes, sft)
@admin.modifyColumnFamilyStoreFileTracker(tableName, family_bytes, sft)
end
end
# rubocop:enable Metrics/ClassLength
end
9 changes: 9 additions & 0 deletions hbase-shell/src/main/ruby/shell.rb
Original file line number Diff line number Diff line change
Expand Up @@ -625,3 +625,12 @@ def self.exception_handler(hide_traceback)
get_namespace_rsgroup
]
)

Shell.load_command_group(
'storefiletracker',
full_name: 'StoreFileTracker',
commands: %w[
change_sft
change_sft_all
]
)
50 changes: 50 additions & 0 deletions hbase-shell/src/main/ruby/shell/commands/change_sft.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
#
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

module Shell
module Commands
class ChangeSft < Command
def help
<<-EOF
Change table's or table column family's sft. Examples:

hbase> change_sft 't1','FILE'
hbase> change_sft 't2','cf1','FILE'
EOF
end

def command(*args)
arg_length = args.length
if arg_length == 2
tableName = TableName.valueOf(args[0])
sft = args[1]
admin.modify_table_sft(tableName, sft)
elsif arg_length == 3
tableName = TableName.valueOf(args[0])
family = args[1]
family_bytes = family.to_java_bytes
sft = args[2]
admin.modify_table_family_sft(tableName, family_bytes, sft)
else
raise(ArgumentError, 'Argument length should be two or three.')
end
end
end
end
end
58 changes: 58 additions & 0 deletions hbase-shell/src/main/ruby/shell/commands/change_sft_all.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
#
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

module Shell
module Commands
class ChangeSftAll < Command
def help
<<-EOF
Change all of the tables's sft matching the given regex:

hbase> change_sft_all 't.*','FILE'
hbase> change_sft_all 'ns:.*','FILE'
hbase> change_sft_all 'ns:t.*','FILE'
EOF
end

def command(*args)
arg_length = args.length
if arg_length == 2
tableRegex = args[0]
tableList = admin.list(tableRegex)
count = tableList.size
sft = args[1]
tableList.each do |table|
formatter.row([table])
end
puts "\nChange the above #{count} tables's sft (y/n)?" unless count == 0
answer = 'n'
answer = gets.chomp unless count == 0
puts "No tables matched the regex #{tableRegex}" if count == 0
return unless answer =~ /y.*/i
tableList.each do |table|
tableName = TableName.valueOf(table)
admin.modify_table_sft(tableName, sft)
end
else
raise(ArgumentError, 'Argument length should be two.')
end
end
end
end
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.hadoop.hbase.client;

import org.apache.hadoop.hbase.HBaseClassTestRule;
import org.apache.hadoop.hbase.testclassification.ClientTests;
import org.apache.hadoop.hbase.testclassification.LargeTests;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.experimental.categories.Category;

@Category({ ClientTests.class, LargeTests.class })
public class TestChangeSftShell extends AbstractTestShell {
@ClassRule
public static final HBaseClassTestRule CLASS_RULE =
HBaseClassTestRule.forClass(TestChangeSftShell.class);

@BeforeClass
public static void setUpBeforeClass() throws Exception {
setUpConfig();

TEST_UTIL.startMiniCluster(3);

setUpJRubyRuntime();
}

@Override
protected String getIncludeList() {
return "sftchange_shell_test.rb";
}
}
56 changes: 56 additions & 0 deletions hbase-shell/src/test/ruby/shell/sftchange_shell_test.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
#
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

require 'hbase_constants'
require 'hbase_shell'

class SftChangeTest < Test::Unit::TestCase
def setup
@hbase = ::Hbase::Hbase.new($TEST_CLUSTER.getConfiguration)
@shell = Shell::Shell.new(@hbase)
connection = $TEST_CLUSTER.getConnection
@admin = connection.getAdmin
end

define_test "Change table's sft" do
table = 'test_table1'
family = 'f1'
change_sft = 'FILE'
@shell.command('create', table, family)
@shell.command('change_sft', table, change_sft)
table_sft = @admin.getDescriptor(TableName.valueOf(table)).getValue('hbase.store.file-tracker.impl')
assert_equal(change_sft, table_sft)
@shell.command(:disable, table)
@shell.command(:drop, table)
end

define_test "Change table column family's sft" do
table = 'test_table2'
family = 'f1'
change_sft = 'FILE'
@shell.command('create', table, family)
@shell.command('change_sft', table, family, change_sft)
family_bytes = family.to_java_bytes
cfd = @admin.getDescriptor(TableName.valueOf(table)).getColumnFamily(family_bytes)
table_family_sft = cfd.getConfigurationValue('hbase.store.file-tracker.impl')
assert_equal(change_sft, table_family_sft)
@shell.command(:disable, table)
@shell.command(:drop, table)
end
end