HBASE-26469 correct HBase shell exit behavior to match code passed to exit #4018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Thanks for this fix, @busbey!
Do you think any of the rubocop warnings make sense? https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4018/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
|
yeah most of them do, even if most are in relocated old code. I'll see which of them I can correct before merging. some of the IRB interactions might be v specific due to the quirks of that library. |
busbey
added a commit
that referenced
this pull request
Jan 14, 2022
… exit (#4018) * refactors how we handle running the passed in initialization script to make use of IRB sessions directly instead of reimplementing things ourselves * simplify how we initialize our IRB config * insert a shim for capturing exit codes passed via user calls to exit * make use of user provided exit code unless we're reading stdin in interactive mode This changes the exit code of the shell * a 0 return code, or no return code, passed to a call to exit from stdin in non-interactive mode will now exit cleanly. in prior versions this would have exitted with an error and non-zero exit code. * for other combinations of passing in an initilization script or reading from stdin with using the non-interactive flag, the exit code being 0 or non-0 should now line up with releases prior to 2.4.z, which is a change in behavior compared to 2.4.z. Signed-off-by: Peter Somogyi <psomogyi@apache.org>
busbey
added a commit
that referenced
this pull request
Jan 15, 2022
… exit (#4018) * refactors how we handle running the passed in initialization script to make use of IRB sessions directly instead of reimplementing things ourselves * simplify how we initialize our IRB config * insert a shim for capturing exit codes passed via user calls to exit * make use of user provided exit code unless we're reading stdin in interactive mode This changes the exit code of the shell * a 0 return code, or no return code, passed to a call to exit from stdin in non-interactive mode will now exit cleanly. in prior versions this would have exitted with an error and non-zero exit code. * for other combinations of passing in an initilization script or reading from stdin with using the non-interactive flag, the exit code being 0 or non-0 should now line up with releases prior to 2.4.z, which is a change in behavior compared to 2.4.z. Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 821e6a3)
busbey
added a commit
that referenced
this pull request
Jan 15, 2022
… exit (#4018) * refactors how we handle running the passed in initialization script to make use of IRB sessions directly instead of reimplementing things ourselves * simplify how we initialize our IRB config * insert a shim for capturing exit codes passed via user calls to exit * make use of user provided exit code unless we're reading stdin in interactive mode This changes the exit code of the shell * a 0 return code, or no return code, passed to a call to exit from stdin in non-interactive mode will now exit cleanly. in prior versions this would have exitted with an error and non-zero exit code. * for other combinations of passing in an initilization script or reading from stdin with using the non-interactive flag, the exit code being 0 or non-0 should now line up with releases prior to 2.4.z, which is a change in behavior compared to 2.4.z. Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 821e6a3)
busbey
added a commit
that referenced
this pull request
Jan 15, 2022
… exit (#4018) * refactors how we handle running the passed in initialization script to make use of IRB sessions directly instead of reimplementing things ourselves * simplify how we initialize our IRB config * insert a shim for capturing exit codes passed via user calls to exit * make use of user provided exit code unless we're reading stdin in interactive mode This changes the exit code of the shell. Note that the below can be summarized as lining up with behavior from earlier HBase releases. This behavior changes in future 2.5+ releases of HBase and you should see the jira for more details. * exit called in an initialization script will result in a non-zero exit code iff a non-zero code is passed to the exit call. * when reading user input from stdin, a call to exit will result in a 0 exit code if the shell is interactive, and a non-zero exit code if the shell is non-interactive. any optional code passed to the call to exit won't change wether the exit code is zero or non-zero. Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 821e6a3)
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
… exit (apache#4018) * refactors how we handle running the passed in initialization script to make use of IRB sessions directly instead of reimplementing things ourselves * simplify how we initialize our IRB config * insert a shim for capturing exit codes passed via user calls to exit * make use of user provided exit code unless we're reading stdin in interactive mode This changes the exit code of the shell. Note that the below can be summarized as lining up with behavior from earlier HBase releases. This behavior changes in future 2.5+ releases of HBase and you should see the jira for more details. * exit called in an initialization script will result in a non-zero exit code iff a non-zero code is passed to the exit call. * when reading user input from stdin, a call to exit will result in a 0 exit code if the shell is interactive, and a non-zero exit code if the shell is non-interactive. any optional code passed to the call to exit won't change wether the exit code is zero or non-zero. Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit 821e6a3) (cherry picked from commit 8b370f7) Change-Id: Id2a201e3355ea70cac5ed4d9dc66042e7cd4ed55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For previous discussion see HBASE-26469 and the draft PR #3901
Based on those discussions, this patch
exitfor comparison to previously provided summaries of return codes, this patch results in: