HBASE-26556 IT and Chaos Monkey improvements #3932
Merged
+155
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8e26c27c2f2f5600406c25de6fceb598c980f1d5
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
taklwu
reviewed
Dec 10, 2021
Contributor
taklwu
left a comment
taklwu
left a comment
There was a problem hiding this comment.
LGTM, just one nit comment for javac and checkstyle
| @Override | ||
| protected Action[] getHeavyWeightedActions() { | ||
| String actions = this.properties.getProperty(HEAVY_ACTIONS); | ||
| if( actions==null||actions.isEmpty() ){ |
Contributor
There was a problem hiding this comment.
[nit] javac and checkstyle seems failing, please see if you can fix it.
joshelser
approved these changes
Dec 10, 2021
Member
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
Spelling errors to fix.
Could you also consider adding some documentation as to how one would use the new policy? https://hbase.apache.org/book.html#maven.build.commands.integration.tests.destructive Ok to me if that is done separately
| private long rollingBatchSuspendRSSleepTime; | ||
| private float rollingBatchSuspendtRSRatio; | ||
|
|
||
| protected Action[] getLightWeigthedActions(){ |
Member
There was a problem hiding this comment.
Suggested change
| protected Action[] getLightWeigthedActions(){ | |
| protected Action[] getLightWeightedActions(){ |
...it/src/test/java/org/apache/hadoop/hbase/chaos/factories/SlowDeterministicMonkeyFactory.java
Outdated
Show resolved
Hide resolved
...java/org/apache/hadoop/hbase/chaos/factories/ConfigurableSlowDeterministicMonkeyFactory.java
Show resolved
Hide resolved
Change-Id: If75dc3fa225cf9359e92bac0579bf46cbc3cf2ca
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
joshelser
approved these changes
Dec 14, 2021
Member
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
Re-reviewed after last update. Looks good to me. We can update docs with how to use in follow-on.
Contributor
Author
Thanks @joshelser . Yeah, was just waiting the qa run before replying to you, I will submit an update to docs in another PR. |
wchevreuil
added a commit
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Tak Lon (Stephen) Wu <taklwu@apache.org> (cherry picked from commit a36d41a)
wchevreuil
added a commit
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Tak Lon (Stephen) Wu <taklwu@apache.org> (cherry picked from commit a36d41a)
wchevreuil
added a commit
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Tak Lon (Stephen) Wu <taklwu@apache.org> (cherry picked from commit a36d41a)
wchevreuil
added a commit
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Tak Lon (Stephen) Wu <taklwu@apache.org> (cherry picked from commit a36d41a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.