Skip to content

HBASE-26434 Compact L0 files for cold regions using StripeCompactionPolicy #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022
Merged

HBASE-26434 Compact L0 files for cold regions using StripeCompactionPolicy #3830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions ...rc/main/java/org/apache/hadoop/hbase/regionserver/compactions/StripeCompactionPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ public StripeCompactionRequest selectCompaction(StripeInformationProvider si,
List<HStoreFile> l0Files = si.getLevel0Files();

// See if we need to make new stripes.
boolean shouldCompactL0 = this.config.getLevel0MinFiles() <= l0Files.size();
boolean shouldCompactL0 =
this.config.getLevel0MinFiles() <= l0Files.size() || allL0FilesExpired(si);
if (stripeCount == 0) {
if (!shouldCompactL0) {
return null; // nothing to do.
Expand Down Expand Up @@ -167,7 +168,7 @@ public boolean needsCompactions(StripeInformationProvider si, List<HStoreFile> f
return filesCompacting.isEmpty()
&& (StoreUtils.hasReferences(si.getStorefiles())
|| (si.getLevel0Files().size() >= this.config.getLevel0MinFiles())
|| needsSingleStripeCompaction(si) || hasExpiredStripes(si));
|| needsSingleStripeCompaction(si) || hasExpiredStripes(si) || allL0FilesExpired(si));
}

@Override
Expand Down Expand Up @@ -368,7 +369,25 @@ private StripeCompactionRequest selectExpiredMergeCompaction(
return result;
}

private boolean isStripeExpired(ImmutableList<HStoreFile> storeFiles) {
protected boolean hasExpiredStripes(StripeInformationProvider si) {
// Find if exists a stripe where all files have expired, if any.
ArrayList<ImmutableList<HStoreFile>> stripes = si.getStripes();
for (ImmutableList<HStoreFile> stripe : stripes) {
if (allFilesExpired(stripe)) {
return true;
}
}
return false;
}

protected boolean allL0FilesExpired(StripeInformationProvider si) {
return allFilesExpired(si.getLevel0Files());
}

private boolean allFilesExpired(final List<HStoreFile> storeFiles) {
if (storeFiles == null || storeFiles.isEmpty()) {
return false;
}
long cfTtl = this.storeConfigInfo.getStoreFileTtl();
if (cfTtl == Long.MAX_VALUE) {
return false; // minversion might be set, cannot delete old files
Expand All @@ -384,17 +403,6 @@ private boolean isStripeExpired(ImmutableList<HStoreFile> storeFiles) {
return true;
}

protected boolean hasExpiredStripes(StripeInformationProvider si) {
// Find if exists a stripe where all files have expired, if any.
ArrayList<ImmutableList<HStoreFile>> stripes = si.getStripes();
for (ImmutableList<HStoreFile> stripe : stripes) {
if (isStripeExpired(stripe)) {
return true;
}
}
return false;
}

private static long getTotalKvCount(final Collection<HStoreFile> candidates) {
long totalSize = 0;
for (HStoreFile storeFile : candidates) {
Expand Down
42 changes: 42 additions & 0 deletions ...est/java/org/apache/hadoop/hbase/regionserver/compactions/TestStripeCompactionPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.hadoop.hbase.regionserver.compactions;

import static org.apache.hadoop.hbase.regionserver.StripeStoreConfig.MAX_FILES_KEY;
import static org.apache.hadoop.hbase.regionserver.StripeStoreConfig.MIN_FILES_KEY;
import static org.apache.hadoop.hbase.regionserver.StripeStoreFileManager.OPEN_KEY;
import static org.apache.hadoop.hbase.regionserver.compactions.CompactionConfiguration.HBASE_HSTORE_COMPACTION_MAX_SIZE_KEY;
import static org.junit.Assert.assertEquals;
Expand All @@ -38,13 +39,15 @@
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Iterator;
import java.util.List;
import java.util.OptionalLong;

import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.Path;
import org.apache.hadoop.hbase.Cell;
Expand Down Expand Up @@ -91,6 +94,7 @@
import org.junit.runners.Parameterized.Parameter;
import org.junit.runners.Parameterized.Parameters;
import org.mockito.ArgumentMatcher;

import org.apache.hbase.thirdparty.com.google.common.collect.ImmutableList;
import org.apache.hbase.thirdparty.com.google.common.collect.Lists;

Expand Down Expand Up @@ -539,6 +543,44 @@ public void testSingleStripeDropDeletes() throws Exception {
true);
}

@Test
public void testCheckExpiredL0Compaction() throws Exception {
Configuration conf = HBaseConfiguration.create();
int minL0 = 100;
conf.setInt(StripeStoreConfig.MIN_FILES_L0_KEY, minL0);
conf.setInt(MIN_FILES_KEY, 4);

ManualEnvironmentEdge edge = new ManualEnvironmentEdge();
long now = defaultTtl + 2;
edge.setValue(now);
EnvironmentEdgeManager.injectEdge(edge);
HStoreFile expiredFile = createFile(10), notExpiredFile = createFile(10);
when(expiredFile.getReader().getMaxTimestamp()).thenReturn(now - defaultTtl - 1);
when(notExpiredFile.getReader().getMaxTimestamp()).thenReturn(now - defaultTtl + 1);
List<HStoreFile> expired = Lists.newArrayList(expiredFile, expiredFile);
List<HStoreFile> mixed = Lists.newArrayList(expiredFile, notExpiredFile);

StripeCompactionPolicy policy =
createPolicy(conf, defaultSplitSize, defaultSplitCount, defaultInitialCount, true);
// Merge expired if there are eligible stripes.
StripeCompactionPolicy.StripeInformationProvider si =
createStripesWithFiles(null, new ArrayList<>(), mixed);
assertFalse(policy.needsCompactions(si, al()));

List<HStoreFile> largeMixed = new ArrayList<>();
for (int i = 0; i < minL0 - 1; i++) {
largeMixed.add(i % 2 == 0 ? notExpiredFile : expiredFile);
}
si = createStripesWithFiles(null, new ArrayList<>(), largeMixed);
assertFalse(policy.needsCompactions(si, al()));

si = createStripesWithFiles(null, new ArrayList<>(), expired);
assertFalse(policy.needsSingleStripeCompaction(si));
assertFalse(policy.hasExpiredStripes(si));
assertTrue(policy.allL0FilesExpired(si));
assertTrue(policy.needsCompactions(si, al()));
}

/********* HELPER METHODS ************/
private static StripeCompactionPolicy createPolicy(
Configuration conf) throws Exception {
Expand Down