Skip to content

HBASE-26284 Add HBase Thrift API to get all table names along with wh… #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2021
Merged

HBASE-26284 Add HBase Thrift API to get all table names along with wh… #3693

merged 5 commits into from
Oct 11, 2021

Conversation

horvathdora
Copy link
Contributor

…ether it is enabled or not

nkalmar
nkalmar approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, original issue is hue dropping too many request because it goes through tables one by one to see if they are enabled or not. This could help this issue by having only 1 thrift api call instead of 1+number of user tables.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 4m 15s master passed
+1 💚 compile 8m 52s master passed
+1 💚 checkstyle 2m 19s master passed
+1 💚 spotbugs 13m 8s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 7s the patch passed
+1 💚 compile 8m 51s the patch passed
+1 💚 javac 8m 51s the patch passed
-0 ⚠️ checkstyle 2m 17s root: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️ whitespace 0m 0s The patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ whitespace 0m 0s The patch 153 line(s) with tabs.
+1 💚 hadoopcheck 24m 10s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 14m 25s the patch passed
_ Other Tests _
-1 ❌ asflicense 0m 37s The patch generated 1 ASF License warnings.
94m 13s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3693
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux b01171777665 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4614c7b
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 22s master passed
+1 💚 compile 3m 1s master passed
+1 💚 shadedjars 8m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 54s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 13s the patch passed
+1 💚 compile 2m 59s the patch passed
+1 💚 javac 2m 59s the patch passed
-1 ❌ shadedjars 0m 12s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 57s the patch passed
_ Other Tests _
+1 💚 unit 183m 40s root in the patch passed.
219m 24s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 743b0e069a3f 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4614c7b
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/testReport/
Max. process+thread count 6332 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 54s master passed
+1 💚 compile 2m 38s master passed
+1 💚 shadedjars 8m 15s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 38s the patch passed
+1 💚 compile 2m 38s the patch passed
+1 💚 javac 2m 38s the patch passed
-1 ❌ shadedjars 0m 11s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 59s the patch passed
_ Other Tests _
-1 ❌ unit 370m 6s root in the patch failed.
401m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux a80e5492d662 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 4614c7b
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/testReport/
Max. process+thread count 5278 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 5m 34s master passed
+1 💚 compile 11m 28s master passed
+1 💚 checkstyle 2m 46s master passed
+1 💚 spotbugs 14m 17s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 4m 9s the patch passed
+1 💚 compile 8m 51s the patch passed
+1 💚 javac 8m 51s the patch passed
-0 ⚠️ checkstyle 2m 16s root: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️ whitespace 0m 0s The patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ whitespace 0m 0s The patch 153 line(s) with tabs.
+1 💚 hadoopcheck 20m 13s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 13m 54s the patch passed
_ Other Tests _
-1 ❌ asflicense 0m 36s The patch generated 1 ASF License warnings.
95m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3693
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 14c63fca34d6 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e6508f6
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil requested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@wchevreuil wchevreuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me, just a small nit comment inline. But it seems there are some undesired files probably committed by mistake in this PR:

  1. test.txt
  2. There's a bunch of files auto generated by the thrift compiler, can we also remove those from this PR?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 24s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 5m 2s master passed
+1 💚 compile 3m 21s master passed
+1 💚 shadedjars 9m 8s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 31s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 4m 48s the patch passed
+1 💚 compile 3m 25s the patch passed
+1 💚 javac 3m 25s the patch passed
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 28s the patch passed
_ Other Tests _
+1 💚 unit 262m 54s root in the patch passed.
303m 31s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3b3955553670 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e6508f6
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/testReport/
Max. process+thread count 4299 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 3s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 4m 4s master passed
+1 💚 compile 2m 52s master passed
+1 💚 shadedjars 9m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 6s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 4m 4s the patch passed
+1 💚 compile 2m 52s the patch passed
+1 💚 javac 2m 52s the patch passed
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 5s the patch passed
_ Other Tests _
-1 ❌ unit 366m 26s root in the patch failed.
405m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 635fa87b548c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e6508f6
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/testReport/
Max. process+thread count 3392 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 4m 10s master passed
+1 💚 compile 8m 55s master passed
+1 💚 checkstyle 2m 17s master passed
+1 💚 spotbugs 13m 9s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 4m 7s the patch passed
+1 💚 compile 8m 49s the patch passed
+1 💚 javac 8m 49s the patch passed
-0 ⚠️ checkstyle 2m 18s root: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️ whitespace 0m 0s The patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ whitespace 0m 0s The patch 153 line(s) with tabs.
+1 💚 hadoopcheck 20m 17s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 13m 53s the patch passed
_ Other Tests _
-1 ❌ asflicense 0m 34s The patch generated 1 ASF License warnings.
89m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3693
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 2d69674ad3d9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 5m 2s master passed
+1 💚 compile 3m 22s master passed
+1 💚 shadedjars 9m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 29s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 4m 52s the patch passed
+1 💚 compile 3m 24s the patch passed
+1 💚 javac 3m 24s the patch passed
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 31s the patch passed
_ Other Tests _
+1 💚 unit 260m 29s root in the patch passed.
299m 30s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 47f4e76605f9 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/testReport/
Max. process+thread count 4230 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 54s master passed
+1 💚 compile 2m 38s master passed
+1 💚 shadedjars 8m 10s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 59s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 38s the patch passed
+1 💚 compile 2m 37s the patch passed
+1 💚 javac 2m 37s the patch passed
-1 ❌ shadedjars 0m 12s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 59s the patch passed
_ Other Tests _
-1 ❌ unit 333m 38s root in the patch failed.
364m 33s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 06c31958366e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/testReport/
Max. process+thread count 4473 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 5m 9s master passed
+1 💚 compile 10m 9s master passed
+1 💚 checkstyle 2m 33s master passed
+1 💚 spotbugs 15m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 5m 22s the patch passed
+1 💚 compile 11m 29s the patch passed
+1 💚 javac 11m 29s root generated 0 new + 1633 unchanged - 1 fixed = 1633 total (was 1634)
-0 ⚠️ checkstyle 2m 51s root: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️ whitespace 0m 0s The patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ whitespace 0m 0s The patch 153 line(s) with tabs.
+1 💚 hadoopcheck 27m 20s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 18m 18s the patch passed
_ Other Tests _
-1 ❌ asflicense 0m 44s The patch generated 1 ASF License warnings.
113m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3693
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 834a0ef5d133 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 127 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 5m 3s master passed
+1 💚 compile 3m 28s master passed
+1 💚 shadedjars 9m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 29s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 48s the patch passed
+1 💚 compile 3m 21s the patch passed
+1 💚 javac 3m 21s the patch passed
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 29s the patch passed
_ Other Tests _
+1 💚 unit 263m 24s root in the patch passed.
302m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2f39934fb2f8 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/testReport/
Max. process+thread count 4533 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 4m 10s master passed
+1 💚 compile 2m 50s master passed
+1 💚 shadedjars 9m 0s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 5s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 8s the patch passed
+1 💚 compile 2m 56s the patch passed
+1 💚 javac 2m 56s the patch passed
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 3s the patch passed
_ Other Tests _
+1 💚 unit 434m 16s root in the patch passed.
468m 0s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9e3cae47b628 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/testReport/
Max. process+thread count 4039 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
Copy link
Contributor

Can we also remove the below generated class from the PR?

hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 4m 12s master passed
+1 💚 compile 8m 49s master passed
+1 💚 checkstyle 2m 16s master passed
+1 💚 spotbugs 13m 5s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 50s root in the patch failed.
-1 ❌ compile 7m 10s root in the patch failed.
-0 ⚠️ javac 7m 10s root in the patch failed.
-0 ⚠️ checkstyle 2m 16s root: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️ whitespace 0m 0s The patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ whitespace 0m 0s The patch 153 line(s) with tabs.
-1 ❌ hadoopcheck 2m 56s The patch causes 14 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 5m 55s The patch causes 14 errors with Hadoop v3.2.1.
-1 ❌ hadoopcheck 8m 55s The patch causes 14 errors with Hadoop v3.3.0.
-1 ❌ spotbugs 0m 22s hbase-thrift in the patch failed.
-1 ❌ spotbugs 0m 22s hbase-examples in the patch failed.
-1 ❌ spotbugs 8m 40s root in the patch failed.
_ Other Tests _
-1 ❌ asflicense 0m 32s The patch generated 1 ASF License warnings.
64m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3693
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux ed4d9ea67a70 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-compile-root.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/whitespace-tabs.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-spotbugs-hbase-examples.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-spotbugs-root.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 1s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 5m 1s master passed
+1 💚 compile 3m 24s master passed
+1 💚 shadedjars 9m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 29s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
-1 ❌ mvninstall 4m 27s root in the patch failed.
-1 ❌ compile 2m 45s root in the patch failed.
-0 ⚠️ javac 2m 45s root in the patch failed.
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 30s the patch passed
_ Other Tests _
-1 ❌ unit 259m 52s root in the patch failed.
297m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux d5c1aa674911 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/testReport/
Max. process+thread count 4211 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 20s master passed
+1 💚 compile 2m 50s master passed
+1 💚 shadedjars 8m 58s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 6s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 49s root in the patch failed.
-1 ❌ compile 2m 11s root in the patch failed.
-0 ⚠️ javac 2m 11s root in the patch failed.
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 6s the patch passed
_ Other Tests _
-1 ❌ unit 429m 16s root in the patch failed.
461m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux b67770246371 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / cbebf85
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/testReport/
Max. process+thread count 4023 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@nkalmar
Copy link
Contributor

nkalmar commented Oct 4, 2021

Saw previous commits having thrift modification included the generated classes as well. This way we won't have the new API in sync with the committed generated code. (Although why have generated code in the first place - I guess we don't want to force everyone to install Thrift?).
Anyway, generated code removed, PTAL @wchevreuil

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 4m 10s master passed
+1 💚 compile 8m 52s master passed
+1 💚 checkstyle 2m 18s master passed
+1 💚 spotbugs 13m 14s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 50s root in the patch failed.
-1 ❌ compile 7m 6s root in the patch failed.
-0 ⚠️ javac 7m 6s root in the patch failed.
-0 ⚠️ checkstyle 2m 18s root: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️ whitespace 0m 0s The patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ whitespace 0m 0s The patch 153 line(s) with tabs.
-1 ❌ hadoopcheck 2m 58s The patch causes 14 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 5m 59s The patch causes 14 errors with Hadoop v3.2.1.
-1 ❌ hadoopcheck 9m 4s The patch causes 14 errors with Hadoop v3.3.0.
-1 ❌ spotbugs 0m 22s hbase-thrift in the patch failed.
-1 ❌ spotbugs 0m 23s hbase-examples in the patch failed.
-1 ❌ spotbugs 8m 38s root in the patch failed.
_ Other Tests _
-1 ❌ asflicense 0m 32s The patch generated 1 ASF License warnings.
64m 27s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3693
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux e57a15b85017 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f65b769
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-compile-root.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/whitespace-tabs.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-javac-3.3.0.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-examples.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-spotbugs-root.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 5m 18s master passed
+1 💚 compile 3m 33s master passed
+1 💚 shadedjars 9m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 30s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
-1 ❌ mvninstall 4m 30s root in the patch failed.
-1 ❌ compile 2m 47s root in the patch failed.
-0 ⚠️ javac 2m 47s root in the patch failed.
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 24s the patch passed
_ Other Tests _
-1 ❌ unit 261m 3s root in the patch failed.
299m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 99a446cdae92 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f65b769
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/testReport/
Max. process+thread count 4139 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/6/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
Copy link
Contributor

Saw previous commits having thrift modification included the generated classes as well. This way we won't have the new API in sync with the committed generated code. (Although why have generated code in the first place - I guess we don't want to force everyone to install Thrift?). Anyway, generated code removed, PTAL @wchevreuil

I believe you're right, @nkalmar , and removing those generated classes is what causing the build failures now. @horvathdora , would you mind put those back, so that the build passes? Sorry for having confused you.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for branch
+1 💚 mvninstall 4m 7s master passed
+1 💚 compile 8m 46s master passed
+1 💚 checkstyle 2m 16s master passed
+1 💚 spotbugs 13m 7s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 5s the patch passed
+1 💚 compile 8m 51s the patch passed
+1 💚 javac 8m 51s root generated 0 new + 1633 unchanged - 1 fixed = 1633 total (was 1634)
-0 ⚠️ checkstyle 2m 22s root: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)
-0 ⚠️ whitespace 0m 0s The patch has 176 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️ whitespace 0m 0s The patch 153 line(s) with tabs.
+1 💚 hadoopcheck 20m 11s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 13m 52s the patch passed
_ Other Tests _
-1 ❌ asflicense 0m 34s The patch generated 1 ASF License warnings.
89m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3693
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 631f3f83ac72 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f65b769
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/whitespace-tabs.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 126 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 47s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 5m 49s master passed
+1 💚 compile 3m 57s master passed
+1 💚 shadedjars 9m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 39s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 59s the patch passed
+1 💚 compile 3m 26s the patch passed
+1 💚 javac 3m 26s the patch passed
-1 ❌ shadedjars 0m 10s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 30s the patch passed
_ Other Tests _
+1 💚 unit 262m 12s root in the patch passed.
304m 36s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7a824cbfd4ee 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f65b769
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/testReport/
Max. process+thread count 4231 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 56s master passed
+1 💚 compile 2m 38s master passed
+1 💚 shadedjars 8m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 0s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 43s the patch passed
+1 💚 compile 2m 34s the patch passed
+1 💚 javac 2m 34s the patch passed
-1 ❌ shadedjars 0m 11s patch has 7 errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 2s the patch passed
_ Other Tests _
-1 ❌ unit 359m 26s root in the patch failed.
391m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 92bcd812b04c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / f65b769
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/testReport/
Max. process+thread count 5596 (vs. ulimit of 30000)
modules C: hbase-thrift hbase-examples . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3693/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
Copy link
Contributor

recheck

@wchevreuil
Copy link
Contributor

Looks fine for me, all UTs and shaded module builds are passing for me locally.

@wchevreuil
Copy link
Contributor

rebuild

@wchevreuil wchevreuil merged commit ce44e16 into apache:master Oct 11, 2021
horvathdora added a commit to horvathdora/hbase that referenced this pull request Oct 12, 2021
@horvathdora
HBASE-26284 Add HBase Thrift API to get all table names along with wh… (
4f13932 
apache#3693)

Signed-off-by: Norbert Kalmar <nkalmar@cloudera.com>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@horvathdora horvathdora mentioned this pull request Oct 12, 2021
Merged
wchevreuil pushed a commit that referenced this pull request Oct 18, 2021
@horvathdora
HBASE-26284 Add HBase Thrift API to get all table names along with wh… (
6d0777a 
#3693) (#3745)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil pushed a commit that referenced this pull request Oct 18, 2021
@horvathdora @wchevreuil
HBASE-26284 Add HBase Thrift API to get all table names along with wh… (
533f535 
#3693) (#3745)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 6d0777a)
wchevreuil pushed a commit that referenced this pull request Oct 18, 2021
@horvathdora @wchevreuil
HBASE-26284 Add HBase Thrift API to get all table names along with wh… (
dd40fd7 
#3693) (#3745)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 6d0777a)
wchevreuil pushed a commit that referenced this pull request Oct 28, 2021
@horvathdora @wchevreuil
HBASE-26284 Add HBase Thrift API to get all table names along with wh… (
385e0d6 
#3693) (#3745)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@horvathdora @stoty
HBASE-26284 Add HBase Thrift API to get all table names along with wh… (
1554268 
apache#3693) (apache#3745)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
(cherry picked from commit 6d0777a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchevreuil wchevreuil wchevreuil requested changes

@nkalmar nkalmar nkalmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@horvathdora @Apache-HBase @wchevreuil @nkalmar