-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-26281 DBB got from BucketCache would be freed unexpectedly befo… #3680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
return null; | ||
}); | ||
} | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I move putIntoBackingMap
from WriterThread
to BucketCache
to facilitate test.
LOG.warn("Failed allocation for " + (re == null ? "" : re.getKey()) + "; " + fle); | ||
// Presume can't add. Too big? Move index on. Entry will be cleared from ramCache below. | ||
bucketEntries[index] = null; | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I move doDrain
from WriterThread
to BucketCache
to facilitate test.
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is a bit difficult to fully understand but I read your description on jira and it is reasonable, and the test is good.
So I give a +1 here.
Let's see if we could pass all the UTs.
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Please fix the checkstyle issue @comnetwork , then I will merge it~ Thanks. |
@Apache9 , sorry for ignore the checkstyle issues.Fix it. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…re RPC completed (#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed (#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed (#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed (apache#3680)
… unexpectedly before RPC completed (apache#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed (apache#3680) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…re RPC completed