HBASE-26278 Add preRequestCompaction method for AccessController #3677

nyl3532016 · 2021-09-11T07:36:37Z

After HBASE-26089, We support RegionCoprocessor on compactionServer, except CoreCoprocessor(including AccessController), But now AccessController invoke preCompact to check permission. If we enable Compaction offload, this check will not work(preCompact heppen on compactionserver, but compactionServer not support AccessController). So the check should always happen on RegionServer, before selectFile.

Apache-HBase · 2021-09-11T08:31:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	4m 33s	HBASE-25714 passed
+1 💚	compile	3m 34s	HBASE-25714 passed
+1 💚	checkstyle	1m 9s	HBASE-25714 passed
+1 💚	spotbugs	2m 19s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 9s	the patch passed
+1 💚	compile	3m 47s	the patch passed
+1 💚	javac	3m 47s	the patch passed
-0 ⚠️	checkstyle	1m 15s	hbase-server: The patch generated 3 new + 119 unchanged - 0 fixed = 122 total (was 119)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 5s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		54m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 17d52bd2490f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-11T10:30:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	4m 29s	HBASE-25714 passed
+1 💚	compile	1m 12s	HBASE-25714 passed
+1 💚	shadedjars	7m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 18s	the patch passed
+1 💚	compile	1m 12s	the patch passed
+1 💚	javac	1m 12s	the patch passed
+1 💚	shadedjars	7m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	141m 34s	hbase-server in the patch passed.
		172m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 90810ad52577 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/testReport/
Max. process+thread count	4293 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-11T10:36:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	3m 55s	HBASE-25714 passed
+1 💚	compile	1m 1s	HBASE-25714 passed
+1 💚	shadedjars	7m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	7m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	149m 28s	hbase-server in the patch passed.
		178m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bcd9bf32de62 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/testReport/
Max. process+thread count	4810 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-11T15:03:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	3m 38s	HBASE-25714 passed
+1 💚	compile	3m 10s	HBASE-25714 passed
+1 💚	checkstyle	1m 5s	HBASE-25714 passed
+1 💚	spotbugs	2m 1s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	compile	3m 15s	the patch passed
+1 💚	javac	3m 15s	the patch passed
+1 💚	checkstyle	1m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 49s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 20s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		46m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d265d4dcc803 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-11T17:13:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	4m 50s	HBASE-25714 passed
+1 💚	compile	1m 18s	HBASE-25714 passed
+1 💚	shadedjars	8m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	8m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	143m 2s	hbase-server in the patch passed.
		176m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b3d832085bbd 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/testReport/
Max. process+thread count	4122 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-11T17:15:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	3m 58s	HBASE-25714 passed
+1 💚	compile	1m 3s	HBASE-25714 passed
+1 💚	shadedjars	7m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	7m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	149m 3s	hbase-server in the patch passed.
		178m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7ddf2bc7597a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/testReport/
Max. process+thread count	4490 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java

Apache-HBase · 2021-09-13T07:49:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	3m 48s	HBASE-25714 passed
+1 💚	compile	3m 16s	HBASE-25714 passed
+1 💚	checkstyle	1m 5s	HBASE-25714 passed
+1 💚	spotbugs	2m 6s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	3m 15s	the patch passed
+1 💚	javac	3m 15s	the patch passed
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 51s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		51m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 108d78359acd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-13T09:52:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	4m 47s	HBASE-25714 passed
+1 💚	compile	1m 16s	HBASE-25714 passed
+1 💚	shadedjars	7m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	shadedjars	7m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	143m 17s	hbase-server in the patch failed.
		174m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dd42939caaa7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/testReport/
Max. process+thread count	4276 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-13T11:07:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	4m 24s	HBASE-25714 passed
+1 💚	compile	1m 5s	HBASE-25714 passed
+1 💚	shadedjars	8m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	8m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	217m 52s	hbase-server in the patch passed.
		249m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 51911255979c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/testReport/
Max. process+thread count	3379 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-21T10:52:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	3m 47s	HBASE-25714 passed
+1 💚	compile	3m 11s	HBASE-25714 passed
+1 💚	checkstyle	1m 9s	HBASE-25714 passed
+1 💚	spotbugs	2m 5s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	3m 11s	the patch passed
+1 💚	javac	3m 11s	the patch passed
+1 💚	checkstyle	1m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 12s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		46m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 148c508aef3d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-21T12:59:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	5m 3s	HBASE-25714 passed
+1 💚	compile	1m 22s	HBASE-25714 passed
+1 💚	shadedjars	7m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 17s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	7m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	141m 6s	hbase-server in the patch passed.
		173m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 423e2062af08 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/testReport/
Max. process+thread count	4026 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-21T13:17:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-25714 Compile Tests _
+1 💚	mvninstall	4m 19s	HBASE-25714 passed
+1 💚	compile	1m 9s	HBASE-25714 passed
+1 💚	shadedjars	9m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	HBASE-25714 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	shadedjars	8m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	158m 39s	hbase-server in the patch failed.
		191m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3677
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3d7c406f4e8d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-25714 / `20b7c8b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/testReport/
Max. process+thread count	4693 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3677/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

HBASE-26278 Add preRequestCompaction method for AccessController

3e97415

modify style

87d521f

nyl3532016 requested a review from Apache9 September 11, 2021 14:16

Apache9 reviewed Sep 13, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java Outdated Show resolved Hide resolved

modify cp position

3ecc75b

modify cp position

d0653bd

Apache9 approved these changes Oct 2, 2021

View reviewed changes

nyl3532016 merged commit e3553ad into apache:HBASE-25714 Oct 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-26278 Add preRequestCompaction method for AccessController #3677

HBASE-26278 Add preRequestCompaction method for AccessController #3677

Uh oh!

nyl3532016 commented Sep 11, 2021 •

edited

Loading

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Uh oh!

Apache-HBase commented Sep 13, 2021

Uh oh!

Apache-HBase commented Sep 13, 2021

Uh oh!

Apache-HBase commented Sep 13, 2021

Uh oh!

Apache-HBase commented Sep 21, 2021

Uh oh!

Apache-HBase commented Sep 21, 2021

Uh oh!

Apache-HBase commented Sep 21, 2021

Uh oh!

Uh oh!

HBASE-26278 Add preRequestCompaction method for AccessController #3677

HBASE-26278 Add preRequestCompaction method for AccessController #3677

Uh oh!

Conversation

nyl3532016 commented Sep 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Apache-HBase commented Sep 11, 2021

Uh oh!

Uh oh!

Apache-HBase commented Sep 13, 2021

Uh oh!

Apache-HBase commented Sep 13, 2021

Uh oh!

Apache-HBase commented Sep 13, 2021

Uh oh!

Apache-HBase commented Sep 21, 2021

Uh oh!

Apache-HBase commented Sep 21, 2021

Uh oh!

Apache-HBase commented Sep 21, 2021

Uh oh!

Uh oh!

nyl3532016 commented Sep 11, 2021 •

edited

Loading