SEEK_NEXT_USING_HINT is ignored on reversed Scans [HBASE-26232] #3639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, and add tests to validate this behavior.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Aug 28, 2021
| @@ -737,7 +737,10 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws | |||
|
|
|||
| case SEEK_NEXT_USING_HINT: | |||
| Cell nextKV = matcher.getNextKeyHint(cell); | |||
| if (nextKV != null && comparator.compare(nextKV, cell) > 0) { | |||
| if (nextKV != null && | |||
| ((!scan.isReversed() && comparator.compare(nextKV, cell) > 0) | |||
There was a problem hiding this comment.
Let's only do one compare and record the result and use it in the if condition? Here we are on the critial read path, so let's try to avoid extra compare as much as possible.
There was a problem hiding this comment.
Java's && short-circuits, so the comparison is only ever actually run once. If the isReversed check (either the normal or the negated) fails, we don't do the associated comparison.
However, I agree that it would be clearer that only one comparison is performed if we store the result. Updated.
I also removed the extraneous @throws doc tags; they were left over when copying from TestFuzzyRowFilterEndToEnd.
P. S. Do you know why GitHub says there were test failures, but the linked "details" page doesn't report any (besides a known failure)?
There was a problem hiding this comment.
OK, thank you for making it more clear.
On the broken PR state, it is because this issue
https://issues.apache.org/jira/browse/SUREFIRE-1821
We enable flaky rerun feature and once there are some flaky tests, the xml report will be broken and fail the report generation stage of the jenkins job, which will finally lead a broken state here.
Still trying to solve the problem but not a blocker for merging here.
...between the current row and the hint when seeking. Also, clean up extraneous doc annotations that explain nothing.
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Aug 28, 2021
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed UTs are related? |
Yes, my mistake. I accidentally moved the comparison before the null check when separating it out. Fixed. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
pushed a commit
that referenced
this pull request
Aug 29, 2021
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9
pushed a commit
that referenced
this pull request
Aug 29, 2021
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Apache9
pushed a commit
that referenced
this pull request
Aug 29, 2021
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix and tests for [HBASE-26232]