HBASE-25853 Backport HBASE-22120 "Replace HTrace with OpenTelemetry" to branch-2 #3637
+2,495
−1,597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se and try to make use of OpenTelemetry" to branch-2 (#3529) 1/17 commits of HBASE-22120 Signed-off-by: Peter Somogyi <psomogyi@apache.org>
… rpc client" to branch-2 (#3543) 2/17 commits of HBASE-22120 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…tracing without directly depending on opentelemetry-sdk" to branch-2 (#3552) 3/17 commits of HBASE-22120, original commit#57960fa8fa7228d65b1a4adc8e9b5b1a8158824d Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
#3556) 4/17 commits of HBASE-22120, original commit 805b2ae Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
#3561) 5/17 commits of HBASE-22120, original commit dcb78bd and merged conflicts after rebasing on HBASE-26150 with commit 63d4970 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…acing rpc call at client side" to branch-2 (#3589) 6/17 commits of HBASE-22120, original commit ae2c62f Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
#3594) 7/17 commits of HBASE-22120, original commit 03e12bf Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…branch-2 (#3597) 8/17 commits of HBASE-22120, original commit 2be2c63 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…RpcClient" to branch-2 (#3607) 9/17 commits of HBASE-22120, original commit bb8c496 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
… branch-2 (#3608) 10/17 commits of HBASE-22120, original commit f6ff519 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…#3618) 11/17 commits of HBASE-22120, original commit 8d68f8c Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…branch-2 (#3620) 12/17 commits of HBASE-22120, original commits 8399293 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…t for RegionScanner.next" to branch-2 (#3623) 13/17 commits of HBASE-22120, original commit 7f90c22 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…r tracing after upgrading opentelemtry to 1.0.0" to branch-2 (#3624) 14/17 commits of HBASE-22120, original commit 8df9beb Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…branch-2 (#3628) 15/17 commits of HBASE-22120, original commit b714889 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…and view tracing with OpenTelemetry" to branch-2 (#3629) 16/17 commits of HBASE-22120, original commit be4503d Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org>
…ncConnectionImpl.getHbck is incorrect" to branch-2 (#3631) 17/17 commits of HBASE-22120, original commit f36e153 Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
…ing after HBASE-22120 merged" into branch-2 (#3634) move opentelemetry jars to client-facing-thirdparty add opentelemetry jars when init map reduce job dependencies original commit 8d2a0ef Co-authored-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.org>
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
the failed test |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Oh my reply is missing? Or maybe I just forgot to hit the comment button to send it out... There is a difference between master and branch-2 is that branch-2 still have a separated sync client implementation which is not built upon the async client, so we should also implement tracing for the sync client. I think I have raised this point before but I can not recall what is final plan... So we want to backport all the commits from master to branch-2 first, and then implement tracing for sync client on branch-2? Just want to confirm the plan, I do not mean you must implement tracing for sync client in this PR. Thanks. |
@Apache9 right, I saw that comment about sync client and created a followup tasks/story HBASE-26141 for implementing trace support for sync client. and yeah, these set of commits for HBASE-25853 just first backport everything. |
|
OK, got it. Let's open a VOTE thread in the dev list. The merge back of a feature branch should get at least 3 +1s from committers. No worry, you already have mine :) Thanks. |
|
will do ! and thanks for your help on reviewing all those commits. |
|
yetus hadoop3 unit tests passed in second run, and TestInfoServersACL didn't showup. rerunning another time for yetus hadoop2 unit tests but the test report of second run did not find anything related to this change. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
since hadoop3 unit tests passed once , I only look at the latest failure in hadoop2, those unrelated tests are Also, I got 3 +1s from the vote thread and will wait for another day before merging. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
with 3 +1s (@Apache9 @petersomogyi @apurtell ) and 1 +0 (@ndimiduk) from committers, rebase and merge into branch-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.