HBASE-26180 Introduce a initial refresh interval for RpcConnectionReg… #3601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bharathv
reviewed
Aug 23, 2021
| if (refreshNow) { | ||
| return minTimeBetweenRefreshesMs; | ||
| } | ||
| if (firstRefresh) { |
There was a problem hiding this comment.
I think this works ok for a large cluster once we populate the stubs of all the bootstrap nodes. But for a smaller cluster (<=10), populateStubs() returns everything. So its likely that even after the first refresh, all the subsequent refreshes hit the same bunch of nodes at the same time.
It looks to me like the right way to fix this is to add jitter to the refreshTime? jitter is a random sleep between (0, n) so that we spread out the calls, this is for all the refreshes and not just the first refresh, WDYT?
There was a problem hiding this comment.
I think jitter is used to solve another problem? It is always good to add a jitter to periodically requests to reduce the possibility to request at the same time.
For the purpose of this issue, let me just paste the description here first to see it can help you to understand better
Introduce a initial refresh interval for RpcConnectionRegistry so we can get the new list soon once we connect to the cluster.
As end users could configure any nodes in a cluster as the initial bootstrap nodes, it is possible that different end users will configure the same machine which makes the machine over load. So we should have a shorter delay for the initial refresh, to let users quickly switch to the bootstrap nodes we want them to connect to.
Free feel to ask if you have other concerns.
There was a problem hiding this comment.
Oh, sorry interpreted it as something else totally. I thought you were talking about what if all requests hit the servers at the same time and suggested jitter, my bad!
bharathv
reviewed
Aug 24, 2021
| if (refreshNow) { | ||
| return minTimeBetweenRefreshesMs; | ||
| } | ||
| if (firstRefresh) { |
There was a problem hiding this comment.
Oh, sorry interpreted it as something else totally. I thought you were talking about what if all requests hit the servers at the same time and suggested jitter, my bad!
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistry.java
Show resolved
Hide resolved
| return minTimeBetweenRefreshesMs; | ||
| } | ||
| if (firstRefresh) { | ||
| return initialDelayMs; |
There was a problem hiding this comment.
One minor edge case is initialDelayMs > periodicRefreshMs (like in a misconfiguration), that needs to be handled ?
(or) we can make initialDelayMs = periodicRefreshMs/4 or something like that, essentially a f(periodicRefreshMs) rather than a separate config, whatever works for you, I don't have a preference.
There was a problem hiding this comment.
I think a new config option is needed, but the default value could be periodicRefreshMs/4 or /5, if users explicitly set it, we will use the value set by users. WDYT?
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Any other concerns? @bharathv Thanks. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
added a commit
that referenced
this pull request
Aug 25, 2021
…istry (#3601) Signed-off-by: Xin Sun <ddupgs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…istry