HBASE-26154: Provide exception metric for quota exceeded and throttling #3544

bbeaudreault · 2021-07-29T22:10:03Z

See https://issues.apache.org/jira/browse/HBASE-26154

Also adds a debug log for unknown exceptions, which we've also found helpful.

Apache-HBase · 2021-07-29T23:04:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 38s	branch-2 passed
+1 💚	compile	5m 4s	branch-2 passed
+1 💚	checkstyle	2m 11s	branch-2 passed
+1 💚	spotbugs	4m 21s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	5m 5s	the patch passed
+1 💚	javac	5m 5s	the patch passed
+1 💚	checkstyle	2m 14s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	5m 2s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 53s	The patch does not generate ASF License warnings.
		53m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux f1a95297a123 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T01:07:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 16s	branch-2 passed
+1 💚	compile	2m 25s	branch-2 passed
+1 💚	shadedjars	7m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 9s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	2m 27s	the patch passed
+1 💚	javac	2m 27s	the patch passed
+1 💚	shadedjars	7m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 3s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 28s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 31s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	133m 0s	hbase-server in the patch passed.
+1 💚	unit	6m 16s	hbase-thrift in the patch passed.
		176m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 88257a4bce35 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/testReport/
Max. process+thread count	3846 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T01:14:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 43s	branch-2 passed
+1 💚	compile	2m 5s	branch-2 passed
+1 💚	shadedjars	6m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	2m 6s	the patch passed
+1 💚	javac	2m 6s	the patch passed
+1 💚	shadedjars	6m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 27s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	143m 21s	hbase-server in the patch passed.
+1 💚	unit	7m 42s	hbase-thrift in the patch passed.
		183m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4f1e49bd38b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/testReport/
Max. process+thread count	4029 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T02:14:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 34s	branch-2 passed
+1 💚	compile	5m 10s	branch-2 passed
+1 💚	checkstyle	2m 16s	branch-2 passed
+1 💚	spotbugs	4m 53s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	5m 51s	the patch passed
+1 💚	javac	5m 51s	the patch passed
+1 💚	checkstyle	2m 21s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	5m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 48s	The patch does not generate ASF License warnings.
		58m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux a4cc0021f03a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T04:11:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 57s	branch-2 passed
+1 💚	compile	2m 21s	branch-2 passed
+1 💚	shadedjars	7m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 5s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	shadedjars	7m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 31s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	132m 29s	hbase-server in the patch passed.
+1 💚	unit	6m 7s	hbase-thrift in the patch passed.
		174m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ade57f0c3beb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/testReport/
Max. process+thread count	3713 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T04:21:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	branch-2 passed
+1 💚	compile	2m 5s	branch-2 passed
+1 💚	shadedjars	6m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	2m 5s	the patch passed
+1 💚	javac	2m 5s	the patch passed
+1 💚	shadedjars	6m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 26s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 27s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	145m 7s	hbase-server in the patch passed.
+1 💚	unit	7m 34s	hbase-thrift in the patch passed.
		184m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1e5d19cbad5a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/testReport/
Max. process+thread count	3916 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

pankaj72981

A minor comment, else LGTM.

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java

bbeaudreault · 2021-07-30T11:31:37Z

Thank you both for the review. I resolved the one comment, so this is ready for merge once the build succeeds.

I think this should apply cleanly to branch-2.4 if you'd be willing as part of the merge.

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java

pankaj72981 · 2021-07-30T12:17:45Z

Do you mind raising PR for master branch? We apply changes first to master branch if applicable and then backport, the only exception to this practice are for changes that are not applicable to the newer release lines

Apache-HBase · 2021-07-30T12:27:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 3s	branch-2 passed
+1 💚	compile	5m 4s	branch-2 passed
+1 💚	checkstyle	2m 22s	branch-2 passed
+1 💚	spotbugs	4m 34s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	5m 3s	the patch passed
+1 💚	javac	5m 3s	the patch passed
+1 💚	checkstyle	2m 21s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	5m 11s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		56m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 00e340b7bb62 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault · 2021-07-30T12:32:11Z

@pankaj72981 I've submitted #3545 for master and #3546 for branch 2.4

Apache-HBase · 2021-07-30T14:33:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 47s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 30s	branch-2 passed
+1 💚	compile	2m 36s	branch-2 passed
+1 💚	shadedjars	7m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 11s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	2m 33s	the patch passed
+1 💚	javac	2m 33s	the patch passed
+1 💚	shadedjars	7m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 34s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	136m 36s	hbase-server in the patch passed.
+1 💚	unit	6m 20s	hbase-thrift in the patch passed.
		182m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ec920d3ba491 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/testReport/
Max. process+thread count	3784 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T14:40:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s	branch-2 passed
+1 💚	compile	2m 11s	branch-2 passed
+1 💚	shadedjars	6m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	2m 22s	the patch passed
+1 💚	javac	2m 22s	the patch passed
+1 💚	shadedjars	6m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 24s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 28s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	149m 39s	hbase-server in the patch passed.
+1 💚	unit	7m 30s	hbase-thrift in the patch passed.
		190m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 48c0354ee1d0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f049301`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/testReport/
Max. process+thread count	3553 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T16:35:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 17s	branch-2 passed
+1 💚	compile	6m 16s	branch-2 passed
+1 💚	checkstyle	2m 40s	branch-2 passed
+1 💚	spotbugs	5m 18s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	6m 5s	the patch passed
+1 💚	javac	6m 5s	the patch passed
+1 💚	checkstyle	2m 39s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 28s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	6m 24s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 49s	The patch does not generate ASF License warnings.
		67m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 42ea85dc4a69 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f3c0227`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T18:31:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 39s	branch-2 passed
+1 💚	compile	2m 8s	branch-2 passed
+1 💚	shadedjars	6m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 22s	the patch passed
+1 💚	compile	2m 5s	the patch passed
+1 💚	javac	2m 5s	the patch passed
+1 💚	shadedjars	6m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 26s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 27s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	143m 53s	hbase-server in the patch passed.
+1 💚	unit	6m 54s	hbase-thrift in the patch passed.
		183m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 48bcd13e881b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f3c0227`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/testReport/
Max. process+thread count	3710 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-30T18:45:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 48s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 28s	branch-2 passed
+1 💚	compile	2m 30s	branch-2 passed
+1 💚	shadedjars	7m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 11s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s	the patch passed
+1 💚	compile	2m 24s	the patch passed
+1 💚	javac	2m 24s	the patch passed
+1 💚	shadedjars	7m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 33s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	142m 23s	hbase-server in the patch passed.
+1 💚	unit	5m 48s	hbase-thrift in the patch passed.
		187m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3fd052b9eb1a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f3c0227`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/testReport/
Max. process+thread count	3984 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…cThrottlingException

Apache-HBase · 2021-07-31T15:21:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 58s	branch-2 passed
+1 💚	compile	5m 7s	branch-2 passed
+1 💚	checkstyle	2m 21s	branch-2 passed
+1 💚	spotbugs	4m 29s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	5m 6s	the patch passed
+1 💚	javac	5m 6s	the patch passed
+1 💚	checkstyle	2m 17s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 4s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	5m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		56m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 43feb8471c57 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f7baa19`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-31T17:20:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 15s	branch-2 passed
+1 💚	compile	2m 22s	branch-2 passed
+1 💚	shadedjars	7m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 7s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 56s	the patch passed
+1 💚	compile	2m 23s	the patch passed
+1 💚	javac	2m 23s	the patch passed
+1 💚	shadedjars	7m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 5s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 30s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 31s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	132m 29s	hbase-server in the patch passed.
+1 💚	unit	6m 6s	hbase-thrift in the patch passed.
		175m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6027fe1f3a91 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f7baa19`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/testReport/
Max. process+thread count	3745 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-31T17:30:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 16s	branch-2 passed
+1 💚	compile	2m 4s	branch-2 passed
+1 💚	shadedjars	7m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 46s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 55s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	shadedjars	6m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 27s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	0m 27s	hbase-hadoop2-compat in the patch passed.
+1 💚	unit	143m 38s	hbase-server in the patch passed.
+1 💚	unit	7m 27s	hbase-thrift in the patch passed.
		185m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3544
JIRA Issue	HBASE-26154
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2fafad97c783 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `f7baa19`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/testReport/
Max. process+thread count	3817 (vs. ulimit of 12500)
modules	C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3544/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault force-pushed the exceptions_upstream branch from e0515c3 to 454f2e0 Compare July 29, 2021 22:10

sunhelly approved these changes Jul 30, 2021

View reviewed changes

pankaj72981 reviewed Jul 30, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java Outdated Show resolved Hide resolved

bbeaudreault force-pushed the exceptions_upstream branch from 454f2e0 to 40e70ba Compare July 30, 2021 11:29

pankaj72981 reviewed Jul 30, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java Outdated Show resolved Hide resolved

bbeaudreault force-pushed the exceptions_upstream branch from 40e70ba to 32bc937 Compare July 30, 2021 11:57

pankaj72981 approved these changes Jul 30, 2021

View reviewed changes

This was referenced Jul 30, 2021

HBASE-26154: Adds exception metrics for QuotaExceededException and RpcThrottlingException #3545

Merged

HBASE-26154: Adds exception metrics for QuotaExceededException and RpcThrottlingException #3546

Merged

HBASE-26154: Adds exception metrics for QuotaExceededException and Rp…

766f9c3

…cThrottlingException

bbeaudreault force-pushed the exceptions_upstream branch from 32bc937 to 766f9c3 Compare July 31, 2021 14:24

pankaj72981 merged commit aa3b07f into apache:branch-2 Aug 2, 2021

bbeaudreault deleted the exceptions_upstream branch August 2, 2021 11:41

HBASE-26154: Provide exception metric for quota exceeded and throttling #3544

HBASE-26154: Provide exception metric for quota exceeded and throttling #3544

Uh oh!

Conversation

bbeaudreault commented Jul 29, 2021

Uh oh!

Apache-HBase commented Jul 29, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

pankaj72981 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bbeaudreault commented Jul 30, 2021

Uh oh!

Uh oh!

pankaj72981 commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

bbeaudreault commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 30, 2021

Uh oh!

Apache-HBase commented Jul 31, 2021

Uh oh!

Apache-HBase commented Jul 31, 2021

Uh oh!

Apache-HBase commented Jul 31, 2021

Uh oh!

Uh oh!