Skip to content

HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves #3536

wants to merge 3 commits into from

Conversation

bbeaudreault
Copy link
Contributor

@bbeaudreault bbeaudreault commented Jul 27, 2021 •
edited
Loading

See https://issues.apache.org/jira/browse/HBASE-26147

I considered adding another overload of the existing balance() methods, but I felt there already existed a lot of overloads there between the deprecated balancer() methods and the force boolean. Adding a separate dryRunBalance() method seemed like the cleanest and most intuitive way to add this new functionality in a backwards compatible way.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from 9a6544b to 6520805 Compare July 27, 2021 21:52
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 44s branch-2 passed
+1 💚 compile 9m 1s branch-2 passed
+1 💚 checkstyle 2m 53s branch-2 passed
+1 💚 spotbugs 7m 46s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 6m 42s the patch passed
+1 💚 cc 6m 42s the patch passed
+1 💚 javac 6m 42s the patch passed
-0 ⚠️ checkstyle 0m 38s hbase-client: The patch generated 2 new + 151 unchanged - 0 fixed = 153 total (was 151)
-0 ⚠️ checkstyle 1m 21s hbase-server: The patch generated 4 new + 107 unchanged - 0 fixed = 111 total (was 107)
-0 ⚠️ rubocop 0m 2s The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 11s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 6s the patch passed
+1 💚 spotbugs 8m 27s the patch passed
_ Other Tests _
-1 ❌ asflicense 1m 1s The patch generated 1 ASF License warnings.
71m 36s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 8ac81ddfdce3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d470b25
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 96 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 4s branch-2 passed
+1 💚 compile 3m 19s branch-2 passed
+1 💚 shadedjars 6m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 8s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 47s the patch passed
+1 💚 compile 3m 21s the patch passed
+1 💚 javac 3m 21s the patch passed
-1 ❌ shadedjars 5m 31s patch has 10 errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 7s the patch passed
_ Other Tests _
+1 💚 unit 0m 45s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 40s hbase-client in the patch passed.
+1 💚 unit 148m 12s hbase-server in the patch passed.
+1 💚 unit 6m 27s hbase-thrift in the patch passed.
+1 💚 unit 7m 13s hbase-shell in the patch passed.
200m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux a500893300e6 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d470b25
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/testReport/
Max. process+thread count 3686 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 46s Docker mode activated.
-0 ⚠️ yetus 0m 9s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 5m 46s branch-2 passed
+1 💚 compile 4m 45s branch-2 passed
+1 💚 shadedjars 9m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 11s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 5m 34s the patch passed
+1 💚 compile 4m 36s the patch passed
+1 💚 javac 4m 36s the patch passed
-1 ❌ shadedjars 7m 35s patch has 10 errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 1s the patch passed
_ Other Tests _
+1 💚 unit 1m 6s hbase-protocol-shaded in the patch passed.
+1 💚 unit 3m 0s hbase-client in the patch passed.
+1 💚 unit 150m 46s hbase-server in the patch passed.
+1 💚 unit 6m 23s hbase-thrift in the patch passed.
+1 💚 unit 7m 15s hbase-shell in the patch passed.
217m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9de502d8d5f7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d470b25
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/testReport/
Max. process+thread count 4244 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from 6520805 to eca1e48 Compare July 28, 2021 16:39
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 58s branch-2 passed
+1 💚 compile 7m 14s branch-2 passed
+1 💚 checkstyle 2m 56s branch-2 passed
+1 💚 spotbugs 7m 46s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 43s the patch passed
+1 💚 compile 7m 11s the patch passed
+1 💚 cc 7m 11s the patch passed
+1 💚 javac 7m 11s the patch passed
-0 ⚠️ checkstyle 0m 35s hbase-client: The patch generated 2 new + 151 unchanged - 0 fixed = 153 total (was 151)
-0 ⚠️ checkstyle 1m 16s hbase-server: The patch generated 4 new + 107 unchanged - 0 fixed = 111 total (was 107)
-0 ⚠️ rubocop 0m 3s The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 52s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 2m 46s the patch passed
+1 💚 spotbugs 8m 18s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
71m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux ce774313b86d 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d470b25
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 16s branch-2 passed
+1 💚 compile 3m 27s branch-2 passed
+1 💚 shadedjars 6m 48s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 28s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 4m 2s the patch passed
+1 💚 compile 3m 27s the patch passed
+1 💚 javac 3m 27s the patch passed
+1 💚 shadedjars 6m 48s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 26s the patch passed
_ Other Tests _
+1 💚 unit 0m 52s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 52s hbase-client in the patch passed.
+1 💚 unit 132m 59s hbase-server in the patch passed.
+1 💚 unit 6m 47s hbase-thrift in the patch passed.
+1 💚 unit 7m 8s hbase-shell in the patch passed.
188m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 434d45fa8f3d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d470b25
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/testReport/
Max. process+thread count 4124 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 3m 41s branch-2 passed
+1 💚 compile 3m 16s branch-2 passed
+1 💚 shadedjars 6m 16s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 12s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 39s the patch passed
+1 💚 compile 3m 17s the patch passed
+1 💚 javac 3m 17s the patch passed
+1 💚 shadedjars 6m 18s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 43s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 47s hbase-client in the patch passed.
+1 💚 unit 156m 21s hbase-server in the patch passed.
+1 💚 unit 6m 37s hbase-thrift in the patch passed.
+1 💚 unit 7m 17s hbase-shell in the patch passed.
209m 7s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux d04e8c71b767 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d470b25
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/testReport/
Max. process+thread count 3456 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser
joshelser requested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. I think we could take this good idea and make it a great idea though :)

@bbeaudreault
Copy link
Contributor Author

@joshelser I pushed a commit which addresses most of your feedback. Thanks again! I have not addressed the interface changes, pending your thoughts on my recent comments. Happy to address those and squash all the commits once we come to a decision.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from eca1e48 to 787c350 Compare August 5, 2021 22:04
@bbeaudreault
Copy link
Contributor Author

I just pushed a commit which makes the changes we talked about in the Admin and RSGroupAdmin interfaces. I still need to update the shell, will do that tomorrow.

Overall I like how this came out, as I said I used a factory for now because we really don't have enough arguments to justify a builder. One thing I don't love is the duplication between hmaster and rsgroup, but that seems to be the name of the game with rsgroup for now. It caused a little bit of funkiness in order to handle the more strict RSGroupAdminServer interface though (i.e. the private BalanceRequest.forRunMode method).

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 56s branch-2 passed
+1 💚 compile 7m 53s branch-2 passed
+1 💚 checkstyle 3m 11s branch-2 passed
+1 💚 spotbugs 8m 17s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 44s the patch passed
+1 💚 compile 7m 49s the patch passed
+1 💚 cc 7m 49s the patch passed
-0 ⚠️ javac 0m 54s hbase-rsgroup generated 6 new + 185 unchanged - 6 fixed = 191 total (was 191)
-0 ⚠️ checkstyle 0m 40s hbase-client: The patch generated 12 new + 402 unchanged - 1 fixed = 414 total (was 403)
-0 ⚠️ checkstyle 1m 15s hbase-server: The patch generated 3 new + 107 unchanged - 0 fixed = 110 total (was 107)
-0 ⚠️ checkstyle 0m 11s hbase-rsgroup: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
-0 ⚠️ rubocop 0m 27s The patch generated 16 new + 673 unchanged - 3 fixed = 689 total (was 676)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 49s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 10s the patch passed
+1 💚 spotbugs 9m 16s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 3s The patch does not generate ASF License warnings.
76m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 2172bbf1cda7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for branch
+1 💚 mvninstall 4m 8s branch-2 passed
+1 💚 compile 3m 56s branch-2 passed
+1 💚 shadedjars 6m 45s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 48s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 3m 54s the patch passed
+1 💚 javac 3m 54s the patch passed
+1 💚 shadedjars 6m 46s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 49s the patch passed
_ Other Tests _
+1 💚 unit 0m 51s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 46s hbase-client in the patch passed.
+1 💚 unit 133m 49s hbase-server in the patch passed.
+1 💚 unit 6m 50s hbase-thrift in the patch passed.
-1 ❌ unit 3m 8s hbase-rsgroup in the patch failed.
-1 ❌ unit 7m 5s hbase-shell in the patch failed.
194m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux a086c63719d3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/testReport/
Max. process+thread count 4238 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 3m 23s branch-2 passed
+1 💚 compile 3m 27s branch-2 passed
+1 💚 shadedjars 6m 2s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 19s the patch passed
+1 💚 compile 3m 25s the patch passed
+1 💚 javac 3m 25s the patch passed
+1 💚 shadedjars 6m 3s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 23s the patch passed
_ Other Tests _
+1 💚 unit 0m 41s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 42s hbase-client in the patch passed.
-1 ❌ unit 145m 49s hbase-server in the patch failed.
+1 💚 unit 6m 34s hbase-thrift in the patch passed.
-1 ❌ unit 3m 50s hbase-rsgroup in the patch failed.
-1 ❌ unit 7m 21s hbase-shell in the patch failed.
202m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 23cbc4fc89ca 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/testReport/
Max. process+thread count 4168 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from 8f4808a to 850b042 Compare August 6, 2021 17:22
@bbeaudreault bbeaudreault requested a review from joshelser August 6, 2021 17:23
@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch 2 times, most recently from ec09f26 to ee1dec2 Compare August 6, 2021 18:06
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 36s Maven dependency ordering for branch
+1 💚 mvninstall 4m 51s branch-2 passed
+1 💚 compile 9m 40s branch-2 passed
+1 💚 checkstyle 3m 33s branch-2 passed
+1 💚 spotbugs 10m 3s branch-2 passed
-0 ⚠️ patch 1m 39s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 39s the patch passed
+1 💚 compile 9m 2s the patch passed
+1 💚 cc 9m 2s the patch passed
-0 ⚠️ javac 1m 2s hbase-rsgroup generated 10 new + 181 unchanged - 10 fixed = 191 total (was 191)
-0 ⚠️ checkstyle 0m 47s hbase-client: The patch generated 10 new + 387 unchanged - 1 fixed = 397 total (was 388)
-0 ⚠️ checkstyle 1m 25s hbase-server: The patch generated 4 new + 97 unchanged - 0 fixed = 101 total (was 97)
-0 ⚠️ checkstyle 0m 15s hbase-rsgroup: The patch generated 7 new + 2 unchanged - 0 fixed = 9 total (was 2)
-0 ⚠️ rubocop 0m 35s The patch generated 20 new + 657 unchanged - 3 fixed = 677 total (was 660)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 15m 31s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 44s the patch passed
+1 💚 spotbugs 10m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 8s The patch does not generate ASF License warnings.
90m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux f3575e338ffe 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from ee1dec2 to 8bedb53 Compare August 6, 2021 19:55
@bbeaudreault
Copy link
Contributor Author

bbeaudreault commented Aug 6, 2021 •
edited
Loading

@joshelser @clarax This is ready for another look. To summarize the changes:

  • All of the interface changes have been combined into the new commit I just added. I'll squash everything into 1 commit once we are done here.
  • New class BalanceRequest (public/evolving), with 2 public factory methods, and 1 public builder method.
    • Create the BalancerRequest with either BalanceRequest#execute() or BalancerRequest#dryRun()
    • Once you have a BalancerRequest, you can optionally enable the old force mode with request#ignoreRegionsInTransition(). I thought it would be good to clarify what force means here, whereas a boolean is rather opaque.
    • As a result, both normal and dryRun can be modified with ignoreRegionsInTransition. This actually seems reasonable, and simplifies some things.
  • Similarly, I updated the hbase shell to have a single balance command. Previously you could execute the balance command with a "force" argument, now you can also specify a "dry_run" argument. You can also combine them, like with the BalanceRequest. I added a 'ignore_rit' option as replacement for 'force' in the future.
  • Both changes have also been applied to the RSGroup balance command.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2 passed
+1 💚 compile 3m 54s branch-2 passed
+1 💚 shadedjars 6m 50s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 49s branch-2 passed
-0 ⚠️ patch 10m 45s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 3m 55s the patch passed
+1 💚 javac 3m 55s the patch passed
+1 💚 shadedjars 6m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 49s the patch passed
_ Other Tests _
+1 💚 unit 0m 52s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 55s hbase-client in the patch passed.
+1 💚 unit 134m 15s hbase-server in the patch passed.
+1 💚 unit 6m 40s hbase-thrift in the patch passed.
+1 💚 unit 3m 3s hbase-rsgroup in the patch passed.
+1 💚 unit 7m 3s hbase-shell in the patch passed.
194m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux c6a9402a5afb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/testReport/
Max. process+thread count 4110 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 44s branch-2 passed
+1 💚 compile 3m 25s branch-2 passed
+1 💚 shadedjars 6m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 28s branch-2 passed
-0 ⚠️ patch 9m 34s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 3m 26s the patch passed
+1 💚 javac 3m 26s the patch passed
+1 💚 shadedjars 6m 5s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 42s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 39s hbase-client in the patch passed.
+1 💚 unit 144m 8s hbase-server in the patch passed.
+1 💚 unit 6m 29s hbase-thrift in the patch passed.
+1 💚 unit 3m 18s hbase-rsgroup in the patch passed.
+1 💚 unit 7m 15s hbase-shell in the patch passed.
200m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 9914e2a4cea2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/testReport/
Max. process+thread count 4265 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 18s branch-2 passed
+1 💚 compile 3m 24s branch-2 passed
+1 💚 shadedjars 5m 58s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 24s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 59s root in the patch failed.
-1 ❌ compile 0m 23s hbase-client in the patch failed.
-1 ❌ compile 0m 37s hbase-server in the patch failed.
-1 ❌ compile 0m 27s hbase-thrift in the patch failed.
-1 ❌ compile 0m 22s hbase-rsgroup in the patch failed.
-0 ⚠️ javac 0m 23s hbase-client in the patch failed.
-0 ⚠️ javac 0m 37s hbase-server in the patch failed.
-0 ⚠️ javac 0m 27s hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 22s hbase-rsgroup in the patch failed.
-1 ❌ shadedjars 2m 55s patch has 52 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 25s hbase-client generated 16 new + 3 unchanged - 0 fixed = 19 total (was 3)
-0 ⚠️ javadoc 0m 36s hbase-server generated 4 new + 21 unchanged - 0 fixed = 25 total (was 21)
-0 ⚠️ javadoc 0m 32s hbase-thrift generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
-0 ⚠️ javadoc 0m 22s hbase-rsgroup generated 17 new + 0 unchanged - 0 fixed = 17 total (was 0)
_ Other Tests _
+1 💚 unit 0m 41s hbase-protocol-shaded in the patch passed.
-1 ❌ unit 0m 23s hbase-client in the patch failed.
-1 ❌ unit 0m 39s hbase-server in the patch failed.
-1 ❌ unit 0m 28s hbase-thrift in the patch failed.
-1 ❌ unit 0m 21s hbase-rsgroup in the patch failed.
-1 ❌ unit 2m 33s hbase-shell in the patch failed.
32m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux b1dce07a601f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-thrift.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-rsgroup.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-thrift.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-rsgroup.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-thrift.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/testReport/
Max. process+thread count 2413 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 20s branch-2 passed
+1 💚 compile 3m 56s branch-2 passed
+1 💚 shadedjars 6m 50s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 54s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 13s root in the patch failed.
-1 ❌ compile 0m 26s hbase-client in the patch failed.
-1 ❌ compile 0m 40s hbase-server in the patch failed.
-1 ❌ compile 0m 30s hbase-thrift in the patch failed.
-1 ❌ compile 0m 24s hbase-rsgroup in the patch failed.
-0 ⚠️ javac 0m 26s hbase-client in the patch failed.
-0 ⚠️ javac 0m 40s hbase-server in the patch failed.
-0 ⚠️ javac 0m 30s hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 24s hbase-rsgroup in the patch failed.
-1 ❌ shadedjars 3m 18s patch has 52 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-client in the patch failed.
-0 ⚠️ javadoc 0m 23s hbase-server in the patch failed.
-0 ⚠️ javadoc 0m 19s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 18s hbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚 unit 0m 52s hbase-protocol-shaded in the patch passed.
-1 ❌ unit 0m 26s hbase-client in the patch failed.
-1 ❌ unit 0m 41s hbase-server in the patch failed.
-1 ❌ unit 0m 31s hbase-thrift in the patch failed.
-1 ❌ unit 0m 24s hbase-rsgroup in the patch failed.
-1 ❌ unit 2m 5s hbase-shell in the patch failed.
35m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux ac3b538dbd01 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-rsgroup.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-rsgroup.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/testReport/
Max. process+thread count 2299 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 59s branch-2 passed
+1 💚 compile 7m 56s branch-2 passed
+1 💚 checkstyle 3m 13s branch-2 passed
+1 💚 spotbugs 8m 11s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 2s root in the patch failed.
-1 ❌ compile 0m 25s hbase-client in the patch failed.
-1 ❌ compile 0m 41s hbase-server in the patch failed.
-1 ❌ compile 0m 29s hbase-thrift in the patch failed.
-1 ❌ compile 0m 21s hbase-rsgroup in the patch failed.
-0 ⚠️ cc 0m 25s hbase-client in the patch failed.
-0 ⚠️ cc 0m 41s hbase-server in the patch failed.
-0 ⚠️ cc 0m 29s hbase-thrift in the patch failed.
-0 ⚠️ cc 0m 21s hbase-rsgroup in the patch failed.
-0 ⚠️ javac 0m 25s hbase-client in the patch failed.
-0 ⚠️ javac 0m 41s hbase-server in the patch failed.
-0 ⚠️ javac 0m 29s hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 21s hbase-rsgroup in the patch failed.
-0 ⚠️ checkstyle 0m 39s hbase-client: The patch generated 9 new + 402 unchanged - 1 fixed = 411 total (was 403)
-0 ⚠️ checkstyle 1m 14s hbase-server: The patch generated 3 new + 107 unchanged - 0 fixed = 110 total (was 107)
-0 ⚠️ checkstyle 0m 11s hbase-rsgroup: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
-0 ⚠️ rubocop 0m 34s The patch generated 53 new + 680 unchanged - 3 fixed = 733 total (was 683)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌ hadoopcheck 1m 31s The patch causes 52 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 3m 1s The patch causes 52 errors with Hadoop v3.2.1.
-1 ❌ hbaseprotoc 0m 22s hbase-client in the patch failed.
-1 ❌ hbaseprotoc 0m 37s hbase-server in the patch failed.
-1 ❌ hbaseprotoc 0m 28s hbase-thrift in the patch failed.
-1 ❌ hbaseprotoc 0m 20s hbase-rsgroup in the patch failed.
-1 ❌ spotbugs 0m 21s hbase-client in the patch failed.
-1 ❌ spotbugs 0m 35s hbase-server in the patch failed.
-1 ❌ spotbugs 0m 25s hbase-thrift in the patch failed.
-1 ❌ spotbugs 0m 19s hbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
47m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux c99c783def07 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f0f519
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-rsgroup.txt
cc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
cc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
cc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt
cc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-rsgroup.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/whitespace-eol.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hbaseprotoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
hbaseprotoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt
hbaseprotoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-rsgroup.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-rsgroup.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch 2 times, most recently from 42d3dff to f89b5b6 Compare August 7, 2021 00:34
@bbeaudreault
HBASE-26147: Add dry_run_balancer and related Admin interfaces for ru…
4edd432 
…nning the balancer without executing any region moves
@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from c049fe3 to 4edd432 Compare August 23, 2021 17:11
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 17s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 35s branch-2 passed
+1 💚 compile 7m 41s branch-2 passed
+1 💚 checkstyle 3m 12s branch-2 passed
+1 💚 spotbugs 7m 55s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 22s the patch passed
+1 💚 compile 7m 38s the patch passed
+1 💚 cc 7m 38s the patch passed
-0 ⚠️ javac 0m 53s hbase-rsgroup generated 6 new + 185 unchanged - 6 fixed = 191 total (was 191)
-0 ⚠️ checkstyle 0m 42s hbase-client: The patch generated 6 new + 387 unchanged - 1 fixed = 393 total (was 388)
-0 ⚠️ checkstyle 1m 10s hbase-server: The patch generated 8 new + 181 unchanged - 1 fixed = 189 total (was 182)
-0 ⚠️ checkstyle 0m 41s hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 13s hbase-rsgroup: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
-0 ⚠️ rubocop 0m 26s The patch generated 44 new + 657 unchanged - 3 fixed = 701 total (was 660)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 11m 42s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 16s the patch passed
+1 💚 spotbugs 8m 43s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 18s The patch does not generate ASF License warnings.
73m 3s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 7358aa322dcf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 6ad7eb8
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 96 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 8s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 35s branch-2 passed
+1 💚 compile 3m 27s branch-2 passed
+1 💚 shadedjars 6m 3s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 27s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 22s the patch passed
+1 💚 compile 3m 25s the patch passed
+1 💚 javac 3m 25s the patch passed
+1 💚 shadedjars 6m 2s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 42s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 37s hbase-client in the patch passed.
+1 💚 unit 144m 25s hbase-server in the patch passed.
+1 💚 unit 6m 57s hbase-thrift in the patch passed.
+1 💚 unit 3m 23s hbase-rsgroup in the patch passed.
+1 💚 unit 7m 21s hbase-shell in the patch passed.
200m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux e08925fdc574 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 6ad7eb8
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/testReport/
Max. process+thread count 4219 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
Copy link
Contributor Author

Hey all, here's an update:

  • I've rolled all of the original commits into 1 commit, and included fixes for @ndimiduk's latest review.
  • I've also added a new commit which adds a BalanceResponse object, as we discussed. I am not sure I'll have time to come back to balancer improvements before 2.5.0, and I wanted to make sure we at least lock in the new IA.Evolving interface in case 2.5.0 ships before I or anyone else can get to it. In this PR, I do not want to go too crazy imagining all of the cool things we can add to the response. The new object has 3 fields: isBalancerRan, getMovesCalculated, getMovesExecuted. I actually think these on there own are useful for operators, so it seems like an OK starting place.

I'm not able to run the full test suite right now, so will be keeping an eye on the jenkins build and update if any tests fail. I didn't add an explicit testBalancerResponses test, but I did include assertions about the new fields in some existing tests.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 43s branch-2 passed
+1 💚 compile 4m 7s branch-2 passed
+1 💚 shadedjars 7m 32s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 56s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 32s the patch passed
+1 💚 compile 4m 7s the patch passed
+1 💚 javac 4m 7s the patch passed
+1 💚 shadedjars 7m 32s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 54s the patch passed
_ Other Tests _
+1 💚 unit 0m 57s hbase-protocol-shaded in the patch passed.
+1 💚 unit 3m 12s hbase-client in the patch passed.
+1 💚 unit 202m 49s hbase-server in the patch passed.
+1 💚 unit 7m 44s hbase-thrift in the patch passed.
+1 💚 unit 4m 5s hbase-rsgroup in the patch passed.
+1 💚 unit 8m 18s hbase-shell in the patch passed.
270m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 65d124ada2a9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 6ad7eb8
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/testReport/
Max. process+thread count 2760 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 7s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 3m 56s branch-2 passed
+1 💚 compile 7m 52s branch-2 passed
+1 💚 checkstyle 3m 12s branch-2 passed
+1 💚 spotbugs 8m 19s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 3m 37s the patch passed
+1 💚 compile 7m 54s the patch passed
+1 💚 cc 7m 54s the patch passed
-0 ⚠️ javac 0m 55s hbase-rsgroup generated 14 new + 177 unchanged - 14 fixed = 191 total (was 191)
-0 ⚠️ checkstyle 0m 41s hbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️ checkstyle 1m 17s hbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️ checkstyle 0m 45s hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 12s hbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️ rubocop 0m 31s The patch generated 47 new + 656 unchanged - 4 fixed = 703 total (was 660)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 12m 57s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 9s the patch passed
+1 💚 spotbugs 9m 11s the patch passed
_ Other Tests _
-1 ❌ asflicense 1m 5s The patch generated 1 ASF License warnings.
75m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 7aa3468b653a 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 6ad7eb8
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/whitespace-eol.txt
asflicense https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 50s branch-2 passed
+1 💚 compile 4m 8s branch-2 passed
+1 💚 shadedjars 7m 32s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 52s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 4m 29s the patch passed
+1 💚 compile 4m 8s the patch passed
+1 💚 javac 4m 8s the patch passed
-1 ❌ shadedjars 3m 42s patch has 10 errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 52s the patch passed
_ Other Tests _
+1 💚 unit 0m 56s hbase-protocol-shaded in the patch passed.
+1 💚 unit 3m 21s hbase-client in the patch passed.
-1 ❌ unit 204m 48s hbase-server in the patch failed.
+1 💚 unit 7m 51s hbase-thrift in the patch passed.
-1 ❌ unit 4m 6s hbase-rsgroup in the patch failed.
-1 ❌ unit 8m 18s hbase-shell in the patch failed.
268m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux a8ab896740f4 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 6ad7eb8
Default Java AdoptOpenJDK-11.0.10+9
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/testReport/
Max. process+thread count 2855 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 59s branch-2 passed
+1 💚 compile 3m 28s branch-2 passed
+1 💚 shadedjars 6m 35s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 17s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 46s the patch passed
+1 💚 compile 3m 23s the patch passed
+1 💚 javac 3m 23s the patch passed
-1 ❌ shadedjars 3m 14s patch has 10 errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 17s the patch passed
_ Other Tests _
+1 💚 unit 0m 43s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 54s hbase-client in the patch passed.
-1 ❌ unit 220m 23s hbase-server in the patch failed.
+1 💚 unit 8m 0s hbase-thrift in the patch passed.
-1 ❌ unit 4m 49s hbase-rsgroup in the patch failed.
-1 ❌ unit 7m 8s hbase-shell in the patch failed.
277m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3dab6ac1a5cb 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 6ad7eb8
Default Java AdoptOpenJDK-1.8.0_282-b08
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/testReport/
Max. process+thread count 2569 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from 7995e64 to e20b5f7 Compare August 24, 2021 12:10
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 13s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 3m 43s branch-2 passed
+1 💚 compile 7m 56s branch-2 passed
+1 💚 checkstyle 3m 9s branch-2 passed
+1 💚 spotbugs 8m 20s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 41s the patch passed
+1 💚 compile 7m 51s the patch passed
+1 💚 cc 7m 51s the patch passed
-0 ⚠️ javac 0m 54s hbase-rsgroup generated 14 new + 177 unchanged - 14 fixed = 191 total (was 191)
-0 ⚠️ checkstyle 0m 39s hbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️ checkstyle 1m 17s hbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️ checkstyle 0m 44s hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 12s hbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️ rubocop 0m 30s The patch generated 50 new + 656 unchanged - 4 fixed = 706 total (was 660)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 12m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 10s the patch passed
+1 💚 spotbugs 9m 13s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
75m 56s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 58143f247837 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d8fb978
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 86 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 3m 24s branch-2 passed
+1 💚 compile 3m 24s branch-2 passed
+1 💚 shadedjars 6m 25s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 3m 30s the patch passed
+1 💚 compile 3m 27s the patch passed
+1 💚 javac 3m 27s the patch passed
+1 💚 shadedjars 6m 21s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 44s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 47s hbase-client in the patch passed.
+1 💚 unit 146m 40s hbase-server in the patch passed.
+1 💚 unit 6m 57s hbase-thrift in the patch passed.
-1 ❌ unit 3m 31s hbase-rsgroup in the patch failed.
-1 ❌ unit 7m 13s hbase-shell in the patch failed.
204m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 06113b81d516 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d8fb978
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/testReport/
Max. process+thread count 3740 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault bbeaudreault force-pushed the dry_run_balancer_upstream branch from e20b5f7 to 279d251 Compare August 24, 2021 17:19
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 41s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 5m 27s branch-2 passed
+1 💚 compile 5m 4s branch-2 passed
+1 💚 shadedjars 9m 20s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 47s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 5m 34s the patch passed
+1 💚 compile 4m 56s the patch passed
+1 💚 javac 4m 56s the patch passed
+1 💚 shadedjars 9m 22s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 21s the patch passed
_ Other Tests _
+1 💚 unit 1m 3s hbase-protocol-shaded in the patch passed.
+1 💚 unit 3m 21s hbase-client in the patch passed.
+1 💚 unit 231m 55s hbase-server in the patch passed.
+1 💚 unit 9m 27s hbase-thrift in the patch passed.
-1 ❌ unit 5m 45s hbase-rsgroup in the patch failed.
-1 ❌ unit 7m 15s hbase-shell in the patch failed.
311m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux fc157ee9504a 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / d8fb978
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/testReport/
Max. process+thread count 2802 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
+1 💚 mvninstall 4m 38s branch-2 passed
+1 💚 compile 9m 34s branch-2 passed
+1 💚 checkstyle 3m 45s branch-2 passed
+1 💚 spotbugs 10m 10s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 17s the patch passed
+1 💚 compile 9m 33s the patch passed
+1 💚 cc 9m 33s the patch passed
-0 ⚠️ javac 1m 2s hbase-rsgroup generated 12 new + 179 unchanged - 12 fixed = 191 total (was 191)
-0 ⚠️ checkstyle 0m 48s hbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️ checkstyle 1m 26s hbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️ checkstyle 0m 50s hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 15s hbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️ rubocop 0m 43s The patch generated 50 new + 656 unchanged - 4 fixed = 706 total (was 660)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 15m 55s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 48s the patch passed
+1 💚 spotbugs 11m 37s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 13s The patch does not generate ASF License warnings.
93m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 7c5c3289e7dc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5dad395
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 96 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 23s branch-2 passed
+1 💚 compile 4m 4s branch-2 passed
+1 💚 shadedjars 6m 51s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 47s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 4m 7s the patch passed
+1 💚 compile 3m 57s the patch passed
+1 💚 javac 3m 57s the patch passed
+1 💚 shadedjars 6m 59s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 51s the patch passed
_ Other Tests _
+1 💚 unit 0m 53s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 29s hbase-client in the patch passed.
+1 💚 unit 134m 18s hbase-server in the patch passed.
+1 💚 unit 6m 8s hbase-thrift in the patch passed.
+1 💚 unit 3m 46s hbase-rsgroup in the patch passed.
+1 💚 unit 7m 57s hbase-shell in the patch passed.
196m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6cad95254a5c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5dad395
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/testReport/
Max. process+thread count 3852 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 55s branch-2 passed
+1 💚 compile 3m 26s branch-2 passed
+1 💚 shadedjars 6m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 19s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 3m 45s the patch passed
+1 💚 compile 3m 26s the patch passed
+1 💚 javac 3m 26s the patch passed
+1 💚 shadedjars 6m 39s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 15s the patch passed
_ Other Tests _
+1 💚 unit 0m 42s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 33s hbase-client in the patch passed.
+1 💚 unit 221m 10s hbase-server in the patch passed.
+1 💚 unit 7m 33s hbase-thrift in the patch passed.
+1 💚 unit 4m 56s hbase-rsgroup in the patch passed.
+1 💚 unit 7m 17s hbase-shell in the patch passed.
281m 0s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1182ea171bf9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 5dad395
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/testReport/
Max. process+thread count 2557 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
Copy link
Contributor Author

@joshelser @ndimiduk fyi this is ready for review again. Tests are now passing.

joshelser
joshelser approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions around javadoc on public classes. Given the magnitude of this patch (and my tardiness on reviews), I'm OK to defer that to a follow-on.

The documentation and new tests included in this already is excellent. Wonderful work.

I like how the BalancerRequest/Response worked out on the API. I almost left a comment about re-using BalancerRequest on the BalanceRSGroupRequest (rather than duplicating the attributes), but decided against it.

@bbeaudreault
Copy link
Contributor Author

Thanks for the reviews everyone. I discussed with @joshelser and will submit a separate PR for documentation improvements since this one already has a long and storied past.

If someone could merge, that'd be great. Unfortunately it does not apply cleanly to master, so I will work on a PR for that now.

@bbeaudreault bbeaudreault mentioned this pull request Aug 26, 2021
Closed
@bbeaudreault
Copy link
Contributor Author

Soo, in the master port PR Duo asked that I remove the InterfaceStability annotations. I didn't realize those were not supposed to be on IA.Public. I just pushed a commit here to do that as well, and as part of that I addressed @joshelser's feedback about docs. Hopefully we're good now! :)

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 3m 51s branch-2 passed
+1 💚 compile 8m 28s branch-2 passed
+1 💚 checkstyle 3m 21s branch-2 passed
+1 💚 spotbugs 8m 42s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 35s the patch passed
+1 💚 compile 8m 32s the patch passed
+1 💚 cc 8m 32s the patch passed
-0 ⚠️ javac 0m 59s hbase-rsgroup generated 12 new + 179 unchanged - 12 fixed = 191 total (was 191)
-0 ⚠️ checkstyle 0m 43s hbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️ checkstyle 1m 14s hbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️ checkstyle 0m 42s hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️ checkstyle 0m 14s hbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️ rubocop 0m 27s The patch generated 50 new + 656 unchanged - 4 fixed = 706 total (was 660)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 12m 30s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 hbaseprotoc 3m 29s the patch passed
+1 💚 spotbugs 9m 50s the patch passed
_ Other Tests _
+1 💚 asflicense 1m 21s The patch does not generate ASF License warnings.
78m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 14f9dc81c71a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3b1482e
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 96 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 53s Docker mode activated.
-0 ⚠️ yetus 0m 7s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 41s branch-2 passed
+1 💚 compile 3m 27s branch-2 passed
+1 💚 shadedjars 6m 7s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 24s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 18s the patch passed
+1 💚 compile 3m 23s the patch passed
+1 💚 javac 3m 23s the patch passed
+1 💚 shadedjars 6m 1s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 25s the patch passed
_ Other Tests _
+1 💚 unit 0m 45s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 32s hbase-client in the patch passed.
+1 💚 unit 145m 14s hbase-server in the patch passed.
+1 💚 unit 7m 35s hbase-thrift in the patch passed.
+1 💚 unit 3m 55s hbase-rsgroup in the patch passed.
+1 💚 unit 7m 20s hbase-shell in the patch passed.
206m 7s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 0cf785622332 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3b1482e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/testReport/
Max. process+thread count 4113 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 51s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 mvninstall 4m 34s branch-2 passed
+1 💚 compile 4m 16s branch-2 passed
+1 💚 shadedjars 7m 42s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 58s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 4m 48s the patch passed
+1 💚 compile 4m 15s the patch passed
+1 💚 javac 4m 15s the patch passed
+1 💚 shadedjars 7m 37s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 57s the patch passed
_ Other Tests _
+1 💚 unit 0m 59s hbase-protocol-shaded in the patch passed.
+1 💚 unit 2m 40s hbase-client in the patch passed.
+1 💚 unit 144m 3s hbase-server in the patch passed.
+1 💚 unit 6m 20s hbase-thrift in the patch passed.
+1 💚 unit 4m 3s hbase-rsgroup in the patch passed.
+1 💚 unit 8m 12s hbase-shell in the patch passed.
210m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3536
JIRA Issue HBASE-26147
Optional Tests javac javadoc unit shadedjars compile
uname Linux 23e91798c123 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 3b1482e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/testReport/
Max. process+thread count 3715 (vs. ulimit of 12500)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelser
Copy link
Member

Flakiness on TestFSHLogProvider. Passed on rerun.

@joshelser joshelser closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack left review comments

@clarax clarax clarax left review comments

@ndimiduk ndimiduk ndimiduk approved these changes

@joshelser joshelser joshelser approved these changes

@apurtell apurtell apurtell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bbeaudreault @Apache-HBase @clarax @ndimiduk @joshelser @saintstack @apurtell