Skip to content

HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related … #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2021
Merged

HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related … #3478

merged 2 commits into from
Jul 19, 2021

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jul 13, 2021

…classes in hbase-server and mark them as IA.LimitedPrivate

@Apache9 Apache9 self-assigned this Jul 13, 2021
@Apache9
Copy link
Contributor Author

Apache9 commented Jul 13, 2021

This is a very big change.

The classes in the new package, org.apache.hadoop.hbase.testing, are all the classes we want to hide from end users, including HBTU and its parent classes, and HBaseCluster and MiniHBaseCluster. All these classes are changed to IA.LimitedPrivate(Phoenix), as I believe Phoenix still needs test some internal stuff of HBase. The DistributedHBaseCluster is kept as is since it is IA.Private.

And then I copied the classes under the new org.apache.hadoop.hbase.testing to org.apache.hadoop.hbase in hbase-testing-module, still keep the IA.Public annotation but mark them all as deprecated, which will be removed in 4.0.0, for keeping compatible. Also modified the HBTU a bit to remove the dependency on junit, by throwing AssertionError directly, as I do not think we should pull in junit as a compile dependency for any libraries...

Thanks.

@Apache9 Apache9 requested review from saintstack and busbey July 13, 2021 11:22
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 15s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 5m 58s master passed
+1 💚 compile 11m 26s master passed
+1 💚 shadedjars 11m 2s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 8m 48s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 48s the patch passed
+1 💚 compile 12m 5s the patch passed
+1 💚 javac 12m 5s the patch passed
+1 💚 shadedjars 11m 13s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 8m 40s the patch passed
_ Other Tests _
+1 💚 unit 2m 22s hbase-common in the patch passed.
+1 💚 unit 1m 39s hbase-client in the patch passed.
+1 💚 unit 0m 50s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 32s hbase-replication in the patch passed.
+1 💚 unit 8m 21s hbase-balancer in the patch passed.
+1 💚 unit 0m 52s hbase-http in the patch passed.
+1 💚 unit 1m 35s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 56s hbase-procedure in the patch passed.
+1 💚 unit 146m 25s hbase-server in the patch passed.
+1 💚 unit 10m 58s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 39s hbase-testing-util in the patch passed.
+1 💚 unit 6m 13s hbase-thrift in the patch passed.
+1 💚 unit 7m 9s hbase-shell in the patch passed.
+1 💚 unit 3m 13s hbase-endpoint in the patch passed.
+1 💚 unit 9m 55s hbase-backup in the patch passed.
+1 💚 unit 1m 14s hbase-it in the patch passed.
-1 ❌ unit 2m 34s hbase-rest in the patch failed.
+1 💚 unit 1m 47s hbase-examples in the patch passed.
+1 💚 unit 1m 21s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 11s hbase-client-project in the patch passed.
+1 💚 unit 1m 12s hbase-shaded-client-project in the patch passed.
298m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 5ca302c0767b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9f21eec
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/testReport/
Max. process+thread count 4817 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 26s Docker mode activated.
-0 ⚠️ yetus 0m 12s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 4m 23s master passed
+1 💚 compile 8m 14s master passed
+1 💚 shadedjars 8m 59s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 27s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 16s the patch passed
+1 💚 compile 8m 18s the patch passed
+1 💚 javac 8m 18s the patch passed
+1 💚 shadedjars 9m 5s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 15s hbase-testing-util generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚 unit 1m 58s hbase-common in the patch passed.
+1 💚 unit 1m 32s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 39s hbase-replication in the patch passed.
+1 💚 unit 8m 45s hbase-balancer in the patch passed.
+1 💚 unit 0m 57s hbase-http in the patch passed.
+1 💚 unit 1m 47s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 22s hbase-procedure in the patch passed.
+1 💚 unit 218m 19s hbase-server in the patch passed.
+1 💚 unit 18m 29s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 55s hbase-testing-util in the patch passed.
+1 💚 unit 9m 34s hbase-thrift in the patch passed.
+1 💚 unit 7m 17s hbase-shell in the patch passed.
+1 💚 unit 3m 33s hbase-endpoint in the patch passed.
+1 💚 unit 13m 40s hbase-backup in the patch passed.
+1 💚 unit 1m 15s hbase-it in the patch passed.
-1 ❌ unit 4m 24s hbase-rest in the patch failed.
+1 💚 unit 2m 50s hbase-examples in the patch passed.
+1 💚 unit 1m 43s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 15s hbase-client-project in the patch passed.
+1 💚 unit 1m 17s hbase-shaded-client-project in the patch passed.
369m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 816f703269e3 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9f21eec
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/testReport/
Max. process+thread count 3106 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 5s Docker mode activated.
-0 ⚠️ yetus 0m 16s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 2s master passed
+1 💚 compile 8m 44s master passed
+1 💚 shadedjars 8m 32s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 29s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 56s root in the patch failed.
-1 ❌ compile 0m 45s hbase-server in the patch failed.
-1 ❌ compile 0m 25s hbase-mapreduce in the patch failed.
-1 ❌ compile 0m 20s hbase-testing-util in the patch failed.
-1 ❌ compile 0m 31s hbase-thrift in the patch failed.
-1 ❌ compile 0m 20s hbase-shell in the patch failed.
-1 ❌ compile 0m 21s hbase-endpoint in the patch failed.
-1 ❌ compile 0m 24s hbase-backup in the patch failed.
-1 ❌ compile 0m 24s hbase-it in the patch failed.
-1 ❌ compile 0m 23s hbase-rest in the patch failed.
-1 ❌ compile 0m 26s hbase-examples in the patch failed.
-1 ❌ compile 0m 13s hbase-shaded-testing-util-tester in the patch failed.
-1 ❌ compile 0m 20s hbase-client-project in the patch failed.
-1 ❌ compile 0m 19s hbase-shaded-client-project in the patch failed.
-0 ⚠️ javac 0m 45s hbase-server in the patch failed.
-0 ⚠️ javac 0m 25s hbase-mapreduce in the patch failed.
-0 ⚠️ javac 0m 20s hbase-testing-util in the patch failed.
-0 ⚠️ javac 0m 31s hbase-thrift in the patch failed.
-0 ⚠️ javac 0m 20s hbase-shell in the patch failed.
-0 ⚠️ javac 0m 21s hbase-endpoint in the patch failed.
-0 ⚠️ javac 0m 24s hbase-backup in the patch failed.
-0 ⚠️ javac 0m 24s hbase-it in the patch failed.
-0 ⚠️ javac 0m 23s hbase-rest in the patch failed.
-0 ⚠️ javac 0m 26s hbase-examples in the patch failed.
-0 ⚠️ javac 0m 13s hbase-shaded-testing-util-tester in the patch failed.
-0 ⚠️ javac 0m 20s hbase-client-project in the patch failed.
-0 ⚠️ javac 0m 19s hbase-shaded-client-project in the patch failed.
-1 ❌ shadedjars 6m 18s patch has 20 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-testing-util generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
_ Other Tests _
+1 💚 unit 1m 50s hbase-common in the patch passed.
+1 💚 unit 1m 14s hbase-client in the patch passed.
+1 💚 unit 0m 44s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 27s hbase-replication in the patch passed.
+1 💚 unit 8m 58s hbase-balancer in the patch passed.
+1 💚 unit 0m 50s hbase-http in the patch passed.
+1 💚 unit 1m 29s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 52s hbase-procedure in the patch passed.
-1 ❌ unit 0m 48s hbase-server in the patch failed.
-1 ❌ unit 0m 25s hbase-mapreduce in the patch failed.
-1 ❌ unit 0m 22s hbase-testing-util in the patch failed.
-1 ❌ unit 0m 35s hbase-thrift in the patch failed.
-1 ❌ unit 0m 21s hbase-shell in the patch failed.
-1 ❌ unit 0m 23s hbase-endpoint in the patch failed.
-1 ❌ unit 0m 24s hbase-backup in the patch failed.
-1 ❌ unit 0m 25s hbase-it in the patch failed.
-1 ❌ unit 0m 25s hbase-rest in the patch failed.
-1 ❌ unit 0m 28s hbase-examples in the patch failed.
-1 ❌ unit 0m 14s hbase-shaded-testing-util-tester in the patch failed.
-1 ❌ unit 0m 21s hbase-client-project in the patch failed.
-1 ❌ unit 0m 19s hbase-shaded-client-project in the patch failed.
85m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 76313ff03f41 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0836695
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-testing-util.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shell.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-endpoint.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-backup.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-it.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-rest.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-examples.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shaded_hbase-shaded-testing-util-tester.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-client-project.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-shaded-client-project.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-mapreduce.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-testing-util.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shell.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-endpoint.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-backup.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-it.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-rest.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-examples.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-shaded_hbase-shaded-testing-util-tester.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-client-project.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-archetypes_hbase-shaded-client-project.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-mapreduce.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-testing-util.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-thrift.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shell.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-endpoint.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-backup.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-it.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-examples.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-shaded_hbase-shaded-testing-util-tester.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-archetypes_hbase-client-project.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-archetypes_hbase-shaded-client-project.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/testReport/
Max. process+thread count 551 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 14s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 5m 13s master passed
+1 💚 compile 10m 19s master passed
+1 💚 shadedjars 10m 52s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 9s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 4s the patch passed
+1 💚 compile 10m 42s the patch passed
+1 💚 javac 10m 42s the patch passed
+1 💚 shadedjars 11m 29s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-testing-util generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚 unit 2m 7s hbase-common in the patch passed.
+1 💚 unit 1m 31s hbase-client in the patch passed.
+1 💚 unit 0m 51s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 30s hbase-replication in the patch passed.
+1 💚 unit 7m 33s hbase-balancer in the patch passed.
+1 💚 unit 0m 57s hbase-http in the patch passed.
+1 💚 unit 1m 44s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 10s hbase-procedure in the patch passed.
+1 💚 unit 160m 19s hbase-server in the patch passed.
+1 💚 unit 12m 21s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 49s hbase-testing-util in the patch passed.
+1 💚 unit 7m 32s hbase-thrift in the patch passed.
+1 💚 unit 7m 19s hbase-shell in the patch passed.
+1 💚 unit 3m 7s hbase-endpoint in the patch passed.
+1 💚 unit 11m 54s hbase-backup in the patch passed.
+1 💚 unit 1m 6s hbase-it in the patch passed.
+1 💚 unit 3m 55s hbase-rest in the patch passed.
+1 💚 unit 1m 58s hbase-examples in the patch passed.
+1 💚 unit 1m 28s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 21s hbase-client-project in the patch passed.
+1 💚 unit 1m 26s hbase-shaded-client-project in the patch passed.
310m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux b7b001c3d2aa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0836695
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/testReport/
Max. process+thread count 5361 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 26s Docker mode activated.
-0 ⚠️ yetus 0m 14s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 6m 0s master passed
+1 💚 compile 10m 51s master passed
+1 💚 shadedjars 11m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 8m 40s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 58s the patch passed
+1 💚 compile 11m 43s the patch passed
+1 💚 javac 11m 43s the patch passed
+1 💚 shadedjars 11m 33s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 8m 52s the patch passed
_ Other Tests _
+1 💚 unit 2m 16s hbase-common in the patch passed.
+1 💚 unit 1m 40s hbase-client in the patch passed.
+1 💚 unit 0m 55s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 46s hbase-replication in the patch passed.
+1 💚 unit 7m 10s hbase-balancer in the patch passed.
+1 💚 unit 0m 58s hbase-http in the patch passed.
+1 💚 unit 2m 9s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 6s hbase-procedure in the patch passed.
-1 ❌ unit 159m 40s hbase-server in the patch failed.
+1 💚 unit 13m 11s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 48s hbase-testing-util in the patch passed.
+1 💚 unit 7m 38s hbase-thrift in the patch passed.
+1 💚 unit 7m 31s hbase-shell in the patch passed.
+1 💚 unit 3m 5s hbase-endpoint in the patch passed.
+1 💚 unit 9m 22s hbase-backup in the patch passed.
+1 💚 unit 1m 28s hbase-it in the patch passed.
+1 💚 unit 3m 41s hbase-rest in the patch passed.
+1 💚 unit 2m 17s hbase-examples in the patch passed.
+1 💚 unit 1m 26s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 19s hbase-client-project in the patch passed.
+1 💚 unit 1m 16s hbase-shaded-client-project in the patch passed.
317m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux a2f27ff28dc7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 0836695
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/testReport/
Max. process+thread count 4838 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 8s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 33s master passed
+1 💚 compile 15m 5s master passed
+1 💚 checkstyle 8m 48s master passed
+1 💚 spotbugs 16m 3s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 28s the patch passed
+1 💚 compile 15m 43s the patch passed
-0 ⚠️ javac 0m 49s hbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️ javac 0m 28s hbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️ javac 3m 34s hbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️ javac 0m 29s hbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️ checkstyle 1m 37s hbase-server: The patch generated 175 new + 1315 unchanged - 173 fixed = 1490 total (was 1488)
-0 ⚠️ checkstyle 0m 18s hbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
-0 ⚠️ whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 20m 46s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
-1 ❌ spotbugs 1m 2s hbase-testing-util generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
_ Other Tests _
+1 💚 asflicense 4m 20s The patch does not generate ASF License warnings.
138m 33s
Reason Tests
FindBugs module:hbase-testing-util
Inconsistent synchronization of org.apache.hadoop.hbase.HBaseTestingUtility.hbaseAdmin; locked 42% of time Unsynchronized access at HBaseTestingUtility.java:42% of time Unsynchronized access at HBaseTestingUtility.java:[line 3045]
org.apache.hadoop.hbase.HBaseTestingUtility.explainTableAvailability(TableName) concatenates strings using + in a loop At HBaseTestingUtility.java:in a loop At HBaseTestingUtility.java:[line 3225]
Write to static field org.apache.hadoop.hbase.HBaseTestingUtility.FS_URI from instance method org.apache.hadoop.hbase.HBaseTestingUtility.setFileSystemURI(String) At HBaseTestingUtility.java:from instance method org.apache.hadoop.hbase.HBaseTestingUtility.setFileSystemURI(String) At HBaseTestingUtility.java:[line 4044]
Write to static field org.apache.hadoop.hbase.MiniHBaseCluster.index from instance method org.apache.hadoop.hbase.MiniHBaseCluster.startMaster() At MiniHBaseCluster.java:from instance method org.apache.hadoop.hbase.MiniHBaseCluster.startMaster() At MiniHBaseCluster.java:[line 551]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3478
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 475fdecf635a 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/whitespace-eol.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-general-check/output/new-spotbugs-hbase-testing-util.html
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

So, a user of these classes who moved to hbase 3.0.0 might have to amend their CLASSPATH but that is all? They might have to add hbase-testing jar to their CLASSPATH?

@saintstack
Copy link
Contributor

Why you thinking the package movement? The HBTU I'd think should be a top-level package rather than a sub-package down in testing?

saintstack
saintstack reviewed Jul 16, 2021
View reviewed changes
@saintstack
Copy link
Contributor

You move the fundamentals HBTU and HBC from top-level into sub-package to send downstreamers the message that these classes are off-limits going forward?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 13s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 4m 0s master passed
+1 💚 compile 8m 40s master passed
+1 💚 shadedjars 8m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 3m 47s the patch passed
+1 💚 compile 8m 50s the patch passed
+1 💚 javac 8m 50s the patch passed
+1 💚 shadedjars 8m 42s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-testing-util generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚 unit 1m 49s hbase-common in the patch passed.
+1 💚 unit 1m 13s hbase-client in the patch passed.
+1 💚 unit 0m 44s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 26s hbase-replication in the patch passed.
+1 💚 unit 8m 57s hbase-balancer in the patch passed.
+1 💚 unit 0m 50s hbase-http in the patch passed.
+1 💚 unit 1m 32s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 51s hbase-procedure in the patch passed.
+1 💚 unit 148m 40s hbase-server in the patch passed.
+1 💚 unit 11m 48s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 40s hbase-testing-util in the patch passed.
+1 💚 unit 6m 29s hbase-thrift in the patch passed.
+1 💚 unit 7m 22s hbase-shell in the patch passed.
+1 💚 unit 3m 42s hbase-endpoint in the patch passed.
+1 💚 unit 9m 52s hbase-backup in the patch passed.
+1 💚 unit 1m 18s hbase-it in the patch passed.
+1 💚 unit 3m 53s hbase-rest in the patch passed.
+1 💚 unit 2m 1s hbase-examples in the patch passed.
+1 💚 unit 1m 34s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 20s hbase-client-project in the patch passed.
+1 💚 unit 1m 11s hbase-shaded-client-project in the patch passed.
282m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 69bdb0460bcc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-testing-util.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/testReport/
Max. process+thread count 5059 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 12s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 4m 50s master passed
+1 💚 compile 10m 7s master passed
+1 💚 shadedjars 9m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 41s the patch passed
+1 💚 compile 9m 54s the patch passed
+1 💚 javac 9m 54s the patch passed
+1 💚 shadedjars 9m 12s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 52s the patch passed
_ Other Tests _
+1 💚 unit 2m 14s hbase-common in the patch passed.
+1 💚 unit 1m 28s hbase-client in the patch passed.
+1 💚 unit 0m 49s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 32s hbase-replication in the patch passed.
+1 💚 unit 8m 20s hbase-balancer in the patch passed.
+1 💚 unit 0m 46s hbase-http in the patch passed.
+1 💚 unit 1m 28s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 45s hbase-procedure in the patch passed.
+1 💚 unit 143m 42s hbase-server in the patch passed.
+1 💚 unit 11m 7s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 36s hbase-testing-util in the patch passed.
+1 💚 unit 6m 17s hbase-thrift in the patch passed.
+1 💚 unit 7m 14s hbase-shell in the patch passed.
+1 💚 unit 3m 13s hbase-endpoint in the patch passed.
+1 💚 unit 10m 8s hbase-backup in the patch passed.
+1 💚 unit 1m 11s hbase-it in the patch passed.
+1 💚 unit 3m 32s hbase-rest in the patch passed.
+1 💚 unit 1m 48s hbase-examples in the patch passed.
+1 💚 unit 1m 18s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 6s hbase-client-project in the patch passed.
+1 💚 unit 1m 6s hbase-shaded-client-project in the patch passed.
284m 11s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 88bc77eae89f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/testReport/
Max. process+thread count 4815 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/5/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 17, 2021

You move the fundamentals HBTU and HBC from top-level into sub-package to send downstreamers the message that these classes are off-limits going forward?

The idea is to copy the HBTU related classes to hbase-testing-util and mark them deprecated, so end users could still use them through all the hbase 3.x lifecycle, and also have plenty of time to switch to the new TestingHBaseCluster, which is enough for most end users.

And for hbase itself, we move the HBTU to another package, so it will not have conflict with the one in hbase-testing-util, and then, since it is not IA.Public again, we could start to purge the uncessary methods, and also do big refactoring on it. And I think Phoenix still needs to make use of this class, as it needs to test something internal to hbase, so I marked the 'new' HBTU as IA.LimitedPrivate, but anyone, I think for an IA.LimitedPrivate class, we are free to change it in minor releases.

You can see some discuss in the parent issue HBASE-13126.

Thanks.

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 17, 2021

So, a user of these classes who moved to hbase 3.0.0 might have to amend their CLASSPATH but that is all? They might have to add hbase-testing jar to their CLASSPATH?

Yes, users need to add hbase-testing-util as a test dependency, but they do not need to change their code in 3.0.0, but in 4.0.0, they have to change their code to make use of the new classes.

@Apache9
Copy link
Contributor Author

Apache9 commented Jul 17, 2021

Why you thinking the package movement? The HBTU I'd think should be a top-level package rather than a sub-package down in testing?

To avoid conflict with the copied ones in hbase-testing-util, we should either move the original one to another package, or rename them. In general, I do not have much intention on which one is better, but for me, I do not have better names for these classes, due to lack of English vocabulary... Do you have any suggestions sir? We could move them back to the top level, but with different names.

Thanks.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 9s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 12s master passed
+1 💚 compile 14m 20s master passed
+1 💚 checkstyle 7m 33s master passed
+1 💚 spotbugs 15m 6s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 33s the patch passed
+1 💚 compile 15m 13s the patch passed
-0 ⚠️ javac 0m 49s hbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️ javac 0m 31s hbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️ javac 3m 25s hbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️ javac 0m 30s hbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️ checkstyle 1m 36s hbase-server: The patch generated 175 new + 1315 unchanged - 173 fixed = 1490 total (was 1488)
-0 ⚠️ checkstyle 0m 18s hbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
-0 ⚠️ whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 20m 14s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 17m 26s the patch passed
_ Other Tests _
+1 💚 asflicense 3m 34s The patch does not generate ASF License warnings.
128m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3478
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 1bf07411b674 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 11s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 27s master passed
+1 💚 compile 9m 15s master passed
+1 💚 shadedjars 8m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 25s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 15s the patch passed
+1 💚 compile 9m 19s the patch passed
+1 💚 javac 9m 19s the patch passed
+1 💚 shadedjars 8m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 17s the patch passed
_ Other Tests _
+1 💚 unit 1m 57s hbase-common in the patch passed.
+1 💚 unit 1m 23s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 28s hbase-replication in the patch passed.
+1 💚 unit 7m 47s hbase-balancer in the patch passed.
+1 💚 unit 0m 46s hbase-http in the patch passed.
+1 💚 unit 1m 25s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 45s hbase-procedure in the patch passed.
-1 ❌ unit 167m 46s hbase-server in the patch failed.
+1 💚 unit 10m 38s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 38s hbase-testing-util in the patch passed.
+1 💚 unit 6m 28s hbase-thrift in the patch passed.
+1 💚 unit 7m 8s hbase-shell in the patch passed.
+1 💚 unit 2m 54s hbase-endpoint in the patch passed.
+1 💚 unit 9m 2s hbase-backup in the patch passed.
+1 💚 unit 1m 13s hbase-it in the patch passed.
+1 💚 unit 3m 49s hbase-rest in the patch passed.
+1 💚 unit 1m 50s hbase-examples in the patch passed.
+1 💚 unit 1m 20s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 8s hbase-client-project in the patch passed.
+1 💚 unit 1m 9s hbase-shaded-client-project in the patch passed.
301m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 754a4bb3de4b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-11.0.10+9
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/testReport/
Max. process+thread count 5022 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 15s Docker mode activated.
-0 ⚠️ yetus 0m 11s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 14s master passed
+1 💚 compile 8m 12s master passed
+1 💚 shadedjars 9m 8s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 2s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 2s the patch passed
+1 💚 compile 8m 18s the patch passed
+1 💚 javac 8m 18s the patch passed
+1 💚 shadedjars 9m 0s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 59s the patch passed
_ Other Tests _
+1 💚 unit 1m 51s hbase-common in the patch passed.
+1 💚 unit 1m 27s hbase-client in the patch passed.
+1 💚 unit 0m 47s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 36s hbase-replication in the patch passed.
+1 💚 unit 12m 5s hbase-balancer in the patch passed.
+1 💚 unit 0m 49s hbase-http in the patch passed.
+1 💚 unit 1m 42s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 9s hbase-procedure in the patch passed.
+1 💚 unit 211m 18s hbase-server in the patch passed.
+1 💚 unit 14m 15s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 35s hbase-testing-util in the patch passed.
+1 💚 unit 9m 14s hbase-thrift in the patch passed.
+1 💚 unit 7m 9s hbase-shell in the patch passed.
+1 💚 unit 3m 20s hbase-endpoint in the patch passed.
+1 💚 unit 12m 54s hbase-backup in the patch passed.
+1 💚 unit 1m 9s hbase-it in the patch passed.
+1 💚 unit 5m 0s hbase-rest in the patch passed.
+1 💚 unit 2m 17s hbase-examples in the patch passed.
+1 💚 unit 1m 27s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 9s hbase-client-project in the patch passed.
+1 💚 unit 1m 5s hbase-shaded-client-project in the patch passed.
357m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux bc766d0e070e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/testReport/
Max. process+thread count 3281 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/6/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 45s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 9s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 4m 33s master passed
+1 💚 compile 17m 42s master passed
+1 💚 checkstyle 8m 42s master passed
+1 💚 spotbugs 16m 44s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 37s the patch passed
+1 💚 compile 17m 49s the patch passed
-0 ⚠️ javac 0m 56s hbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️ javac 0m 31s hbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️ javac 4m 0s hbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️ javac 0m 36s hbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️ checkstyle 1m 46s hbase-server: The patch generated 175 new + 1315 unchanged - 173 fixed = 1490 total (was 1488)
-0 ⚠️ checkstyle 0m 21s hbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 23m 54s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 20m 14s the patch passed
_ Other Tests _
+1 💚 asflicense 4m 2s The patch does not generate ASF License warnings.
147m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3478
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux fbdae27bcddc 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
-0 ⚠️ yetus 0m 12s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 8s master passed
+1 💚 compile 9m 17s master passed
+1 💚 shadedjars 8m 8s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for patch
+1 💚 mvninstall 4m 13s the patch passed
+1 💚 compile 9m 26s the patch passed
+1 💚 javac 9m 26s the patch passed
+1 💚 shadedjars 8m 13s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 27s the patch passed
_ Other Tests _
+1 💚 unit 1m 57s hbase-common in the patch passed.
+1 💚 unit 1m 25s hbase-client in the patch passed.
+1 💚 unit 0m 49s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 27s hbase-replication in the patch passed.
+1 💚 unit 7m 24s hbase-balancer in the patch passed.
+1 💚 unit 0m 45s hbase-http in the patch passed.
+1 💚 unit 1m 26s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 42s hbase-procedure in the patch passed.
+1 💚 unit 135m 57s hbase-server in the patch passed.
+1 💚 unit 10m 12s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 39s hbase-testing-util in the patch passed.
+1 💚 unit 6m 55s hbase-thrift in the patch passed.
+1 💚 unit 7m 13s hbase-shell in the patch passed.
+1 💚 unit 2m 55s hbase-endpoint in the patch passed.
+1 💚 unit 10m 12s hbase-backup in the patch passed.
+1 💚 unit 1m 14s hbase-it in the patch passed.
+1 💚 unit 3m 29s hbase-rest in the patch passed.
+1 💚 unit 1m 46s hbase-examples in the patch passed.
+1 💚 unit 1m 19s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 8s hbase-client-project in the patch passed.
+1 💚 unit 1m 10s hbase-shaded-client-project in the patch passed.
270m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux dee4acc7ceba 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/testReport/
Max. process+thread count 5398 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@saintstack
Copy link
Contributor

To avoid conflict with the copied ones in hbase-testing-util, we should either move the original one to another package, or rename them. In general, I do not have much intention on which one is better, but for me, I do not have better names for these classes, due to lack of English vocabulary... Do you have any suggestions sir? We could move them back to the top level, but with different names.

Thanks for explanation. Suggest you add description on the JIRA repeating the helpful overview you give here pointing at the parent issue's discussion.

On moving the classes to a sub-package though some of these classes are used broadly, given what you are trying to achieve (cleanup, refactor), this is probably the easiest approach. One suggestion I have would be renaming HBaseTestingUtility as TestingUtility and leaving it in the top-level package. The 'HBase' prefix is redundant. Might be working looking at. If it makes more work for you, just ignore.

Meantime, let me +1 this change.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 14s Docker mode activated.
-0 ⚠️ yetus 0m 11s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 4m 15s master passed
+1 💚 compile 8m 13s master passed
+1 💚 shadedjars 9m 5s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 compile 8m 16s the patch passed
+1 💚 javac 8m 16s the patch passed
+1 💚 shadedjars 9m 0s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 2s the patch passed
_ Other Tests _
+1 💚 unit 1m 51s hbase-common in the patch passed.
+1 💚 unit 1m 27s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 37s hbase-replication in the patch passed.
+1 💚 unit 12m 5s hbase-balancer in the patch passed.
+1 💚 unit 0m 48s hbase-http in the patch passed.
+1 💚 unit 1m 42s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 8s hbase-procedure in the patch passed.
+1 💚 unit 211m 25s hbase-server in the patch passed.
+1 💚 unit 14m 20s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 36s hbase-testing-util in the patch passed.
+1 💚 unit 9m 10s hbase-thrift in the patch passed.
+1 💚 unit 7m 4s hbase-shell in the patch passed.
+1 💚 unit 3m 20s hbase-endpoint in the patch passed.
+1 💚 unit 12m 51s hbase-backup in the patch passed.
+1 💚 unit 1m 9s hbase-it in the patch passed.
+1 💚 unit 4m 59s hbase-rest in the patch passed.
+1 💚 unit 2m 17s hbase-examples in the patch passed.
+1 💚 unit 1m 31s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 7s hbase-client-project in the patch passed.
+1 💚 unit 1m 7s hbase-shaded-client-project in the patch passed.
357m 10s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 028047c8c976 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/testReport/
Max. process+thread count 3599 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/7/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …
1952368 
…classes in hbase-server and mark them as IA.LimitedPrivate
@Apache9
Copy link
Contributor Author

Apache9 commented Jul 18, 2021

Thank you @saintstack . Finally I think I found a way to do renaming instead of moving. This is the release note of this issue. PTAL. Shout if you do not think it is good enough.

Copy HBaseCommonTestingUtility, HBaseZKTestingUtility, HBaseTestingUtility, HBaseCluster, MiniHBaseCluster, StartMiniClusterOption to hbase-testing-util, and mark them as Deprecated. They will be removed in 4.0.0. End users should use TestingHBaseCluster for writing UTs in the future.

And in hbase-server and related modules, these classes are renamed.
HBaseCommonTestingUtility -> HBaseCommonTestingUtil
HBaseZKTestingUtility -> HBaseZKTestingUtil
HBaseTestingUtility -> HBaseTestingUtil
HBaseCluster -> HBaseClusterInterface
MiniHBaseCluster -> SingleProcessHBaseCluster
StartMiniClusterOption -> StartTestingClusterOption
And all these classes are marked as IA.LimitedPrivate("Phoenix"), and IS.Evolving. Except Phoenix, other end users should not use them any more.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 8s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 0s master passed
+1 💚 compile 14m 14s master passed
+1 💚 checkstyle 7m 27s master passed
+1 💚 spotbugs 13m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 compile 14m 31s the patch passed
-0 ⚠️ javac 0m 46s hbase-common generated 5 new + 155 unchanged - 4 fixed = 160 total (was 159)
-0 ⚠️ javac 0m 27s hbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
-0 ⚠️ javac 3m 21s hbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️ javac 0m 46s hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
-0 ⚠️ javac 0m 30s hbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
-0 ⚠️ checkstyle 1m 37s hbase-server: The patch generated 92 new + 1460 unchanged - 28 fixed = 1552 total (was 1488)
-0 ⚠️ checkstyle 0m 18s hbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
-0 ⚠️ checkstyle 0m 19s hbase-it: The patch generated 2 new + 119 unchanged - 0 fixed = 121 total (was 119)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 22m 49s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 18m 12s the patch passed
_ Other Tests _
+1 💚 asflicense 3m 31s The patch does not generate ASF License warnings.
129m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3478
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 385d216c7b8c 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-it.txt
Max. process+thread count 87 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
-0 ⚠️ yetus 0m 12s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for branch
+1 💚 mvninstall 4m 45s master passed
+1 💚 compile 9m 22s master passed
+1 💚 shadedjars 8m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 27s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 14s the patch passed
+1 💚 compile 9m 16s the patch passed
+1 💚 javac 9m 16s the patch passed
+1 💚 shadedjars 8m 17s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 22s the patch passed
_ Other Tests _
+1 💚 unit 1m 52s hbase-common in the patch passed.
+1 💚 unit 1m 23s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 29s hbase-replication in the patch passed.
+1 💚 unit 7m 42s hbase-balancer in the patch passed.
+1 💚 unit 0m 45s hbase-http in the patch passed.
+1 💚 unit 1m 25s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 45s hbase-procedure in the patch passed.
+1 💚 unit 137m 57s hbase-server in the patch passed.
+1 💚 unit 10m 19s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 37s hbase-testing-util in the patch passed.
+1 💚 unit 6m 31s hbase-thrift in the patch passed.
+1 💚 unit 7m 6s hbase-shell in the patch passed.
+1 💚 unit 2m 55s hbase-endpoint in the patch passed.
+1 💚 unit 8m 58s hbase-backup in the patch passed.
+1 💚 unit 1m 12s hbase-it in the patch passed.
+1 💚 unit 3m 44s hbase-rest in the patch passed.
+1 💚 unit 1m 48s hbase-examples in the patch passed.
+1 💚 unit 1m 23s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 10s hbase-client-project in the patch passed.
+1 💚 unit 1m 8s hbase-shaded-client-project in the patch passed.
271m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux ed881b40ea4c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/testReport/
Max. process+thread count 5015 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 21s Docker mode activated.
-0 ⚠️ yetus 0m 11s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 1s master passed
+1 💚 compile 8m 11s master passed
+1 💚 shadedjars 9m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 58s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 5s the patch passed
+1 💚 compile 8m 10s the patch passed
+1 💚 javac 8m 10s the patch passed
+1 💚 shadedjars 9m 5s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 2s the patch passed
_ Other Tests _
+1 💚 unit 1m 50s hbase-common in the patch passed.
+1 💚 unit 1m 26s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 36s hbase-replication in the patch passed.
+1 💚 unit 12m 7s hbase-balancer in the patch passed.
+1 💚 unit 0m 49s hbase-http in the patch passed.
+1 💚 unit 1m 41s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 10s hbase-procedure in the patch passed.
+1 💚 unit 212m 12s hbase-server in the patch passed.
+1 💚 unit 14m 22s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 35s hbase-testing-util in the patch passed.
+1 💚 unit 9m 9s hbase-thrift in the patch passed.
+1 💚 unit 7m 4s hbase-shell in the patch passed.
+1 💚 unit 3m 18s hbase-endpoint in the patch passed.
+1 💚 unit 13m 0s hbase-backup in the patch passed.
+1 💚 unit 1m 8s hbase-it in the patch passed.
+1 💚 unit 5m 0s hbase-rest in the patch passed.
+1 💚 unit 2m 18s hbase-examples in the patch passed.
+1 💚 unit 1m 30s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 11s hbase-client-project in the patch passed.
+1 💚 unit 1m 8s hbase-shaded-client-project in the patch passed.
358m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux d31a460201bc 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/testReport/
Max. process+thread count 3213 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/8/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 10s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 59s master passed
+1 💚 compile 14m 18s master passed
+1 💚 checkstyle 7m 30s master passed
+1 💚 spotbugs 13m 38s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 0s the patch passed
+1 💚 compile 14m 23s the patch passed
+1 💚 javac 0m 46s hbase-common generated 0 new + 155 unchanged - 4 fixed = 155 total (was 159)
+1 💚 javac 0m 56s hbase-client in the patch passed.
-0 ⚠️ javac 0m 27s hbase-zookeeper generated 1 new + 96 unchanged - 1 fixed = 97 total (was 97)
+1 💚 javac 0m 23s hbase-replication in the patch passed.
+1 💚 javac 0m 30s hbase-balancer in the patch passed.
+1 💚 javac 0m 28s hbase-http in the patch passed.
+1 💚 javac 0m 26s hbase-asyncfs in the patch passed.
+1 💚 javac 0m 32s hbase-procedure in the patch passed.
-0 ⚠️ javac 3m 16s hbase-server generated 97 new + 96 unchanged - 97 fixed = 193 total (was 193)
-0 ⚠️ javac 0m 47s hbase-mapreduce generated 1 new + 197 unchanged - 1 fixed = 198 total (was 198)
-0 ⚠️ javac 0m 30s hbase-testing-util generated 100 new + 1 unchanged - 0 fixed = 101 total (was 1)
+1 💚 javac 0m 56s hbase-thrift in the patch passed.
+1 💚 javac 0m 23s hbase-shell in the patch passed.
+1 💚 javac 0m 31s hbase-endpoint in the patch passed.
+1 💚 javac 0m 36s hbase-backup in the patch passed.
+1 💚 javac 0m 39s hbase-it in the patch passed.
+1 💚 javac 0m 39s hbase-rest in the patch passed.
+1 💚 javac 0m 35s hbase-examples in the patch passed.
+1 💚 javac 0m 14s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 javac 0m 25s hbase-client-project in the patch passed.
+1 💚 javac 0m 24s hbase-shaded-client-project in the patch passed.
-0 ⚠️ checkstyle 1m 35s hbase-server: The patch generated 13 new + 1445 unchanged - 43 fixed = 1458 total (was 1488)
-0 ⚠️ checkstyle 0m 18s hbase-testing-util: The patch generated 174 new + 0 unchanged - 0 fixed = 174 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 2s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 20m 0s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 17m 26s the patch passed
_ Other Tests _
+1 💚 asflicense 3m 31s The patch does not generate ASF License warnings.
124m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3478
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname Linux 95a515dd5188 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-mapreduce.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-compile-javac-hbase-testing-util.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. Looks great. +1

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 12s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 4m 10s master passed
+1 💚 compile 9m 15s master passed
+1 💚 shadedjars 8m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 24s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 13s the patch passed
+1 💚 compile 9m 16s the patch passed
+1 💚 javac 9m 16s the patch passed
+1 💚 shadedjars 8m 6s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 7m 26s the patch passed
_ Other Tests _
+1 💚 unit 1m 50s hbase-common in the patch passed.
+1 💚 unit 1m 23s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 28s hbase-replication in the patch passed.
+1 💚 unit 7m 42s hbase-balancer in the patch passed.
+1 💚 unit 0m 45s hbase-http in the patch passed.
+1 💚 unit 1m 27s hbase-asyncfs in the patch passed.
+1 💚 unit 1m 45s hbase-procedure in the patch passed.
+1 💚 unit 137m 57s hbase-server in the patch passed.
+1 💚 unit 10m 16s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 34s hbase-testing-util in the patch passed.
+1 💚 unit 6m 25s hbase-thrift in the patch passed.
+1 💚 unit 7m 7s hbase-shell in the patch passed.
+1 💚 unit 2m 56s hbase-endpoint in the patch passed.
+1 💚 unit 9m 5s hbase-backup in the patch passed.
+1 💚 unit 1m 12s hbase-it in the patch passed.
+1 💚 unit 3m 47s hbase-rest in the patch passed.
+1 💚 unit 1m 48s hbase-examples in the patch passed.
+1 💚 unit 1m 19s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 11s hbase-client-project in the patch passed.
+1 💚 unit 1m 11s hbase-shaded-client-project in the patch passed.
270m 35s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux ed24b47c312e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/testReport/
Max. process+thread count 5054 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
-0 ⚠️ yetus 0m 11s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 4m 3s master passed
+1 💚 compile 8m 6s master passed
+1 💚 shadedjars 9m 1s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 5m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 8m 13s the patch passed
+1 💚 javac 8m 13s the patch passed
+1 💚 shadedjars 9m 1s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 6m 1s the patch passed
_ Other Tests _
+1 💚 unit 1m 50s hbase-common in the patch passed.
+1 💚 unit 1m 26s hbase-client in the patch passed.
+1 💚 unit 0m 46s hbase-zookeeper in the patch passed.
+1 💚 unit 0m 36s hbase-replication in the patch passed.
+1 💚 unit 12m 5s hbase-balancer in the patch passed.
+1 💚 unit 0m 49s hbase-http in the patch passed.
+1 💚 unit 1m 40s hbase-asyncfs in the patch passed.
+1 💚 unit 2m 9s hbase-procedure in the patch passed.
+1 💚 unit 212m 1s hbase-server in the patch passed.
+1 💚 unit 14m 11s hbase-mapreduce in the patch passed.
+1 💚 unit 1m 39s hbase-testing-util in the patch passed.
+1 💚 unit 9m 11s hbase-thrift in the patch passed.
+1 💚 unit 7m 5s hbase-shell in the patch passed.
+1 💚 unit 3m 19s hbase-endpoint in the patch passed.
+1 💚 unit 12m 56s hbase-backup in the patch passed.
+1 💚 unit 1m 8s hbase-it in the patch passed.
+1 💚 unit 5m 1s hbase-rest in the patch passed.
+1 💚 unit 2m 15s hbase-examples in the patch passed.
+1 💚 unit 1m 28s hbase-shaded-testing-util-tester in the patch passed.
+1 💚 unit 1m 10s hbase-client-project in the patch passed.
+1 💚 unit 1m 7s hbase-shaded-client-project in the patch passed.
357m 17s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3478
Optional Tests javac javadoc unit shadedjars compile
uname Linux 62ebe8952bb5 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d1bf1
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/testReport/
Max. process+thread count 3458 (vs. ulimit of 30000)
modules C: hbase-common hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded/hbase-shaded-testing-util-tester hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3478/9/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit d30cc27 into apache:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

@busbey busbey Awaiting requested review from busbey

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @saintstack