HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache #3473

YutSean · 2021-07-12T09:05:11Z

https://issues.apache.org/jira/browse/HBASE-26083

…ing CombinedBlockCache

Apache-HBase · 2021-07-12T09:43:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 2s	branch-2 passed
+1 💚	compile	1m 0s	branch-2 passed
+1 💚	shadedjars	6m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 41s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	6m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
-1 ❌	unit	10m 34s	hbase-server in the patch failed.
		37m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 22342c1897df 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3294d32`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/testReport/
Max. process+thread count	741 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-12T09:45:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	5m 1s	branch-2 passed
+1 💚	compile	1m 16s	branch-2 passed
+1 💚	shadedjars	7m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 10s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	6m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	7m 47s	hbase-server in the patch failed.
		39m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1afa350a22de 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3294d32`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/testReport/
Max. process+thread count	783 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

jojochuang · 2021-07-12T12:22:17Z

I don't understand this part of code. But I'm curious: does it mean the bug no longer exist in the master branch?

YutSean · 2021-07-13T03:21:00Z

In the master branch, in ComebinedBlockCache getBlock method, it will check if the block is metablock or not and check it in L1 or L2. This will make the metric work normal.

Apache-HBase · 2021-07-13T04:01:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 55s	branch-2 passed
+1 💚	compile	1m 5s	branch-2 passed
+1 💚	shadedjars	6m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	1m 9s	the patch passed
+1 💚	javac	1m 9s	the patch passed
+1 💚	shadedjars	6m 48s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
-1 ❌	unit	7m 36s	hbase-server in the patch failed.
		34m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c6733539844f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3294d32`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/testReport/
Max. process+thread count	780 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-13T04:08:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 4s	branch-2 passed
+1 💚	compile	1m 1s	branch-2 passed
+1 💚	shadedjars	6m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	compile	0m 59s	the patch passed
+1 💚	javac	0m 59s	the patch passed
+1 💚	shadedjars	6m 31s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	10m 19s	hbase-server in the patch failed.
		42m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a089a6087235 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3294d32`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/testReport/
Max. process+thread count	774 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

anoopsjohn · 2021-07-13T04:35:04Z

In the master branch, in ComebinedBlockCache getBlock method, it will check if the block is metablock or not and check it in L1 or L2. This will make the metric work normal.

There is one thing to note
In master branch also we have,

public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, boolean repeat,
boolean updateCacheMetrics, BlockType blockType) {
if (blockType == null) {
return getBlock(cacheKey, caching, repeat, updateCacheMetrics);
}
boolean metaBlock = isMetaBlock(blockType);
if (metaBlock) {
return l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics);
} else {
return l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics);
}
}

In some code paths, we dont pass a blockType. It will come as null. That time we follow the old method of check for key in cache and call get.
For those flow, the type in BlockCacheKey will also be null. We may have to consider that.

So we can think about another way around? Can we think about containsBlock() deal with metric too? Need to be careful though. Even in master, the metric what we get is not accurate. It may be better than 0% miss rate. But not correct

YutSean · 2021-07-13T05:24:04Z

Added metric update into containsBlock, but it looks ugly....

YutSean · 2021-07-13T05:36:08Z

Have changed to a less ugly way to update the metric in the latest commit. Hope it can pass the UTs.

Apache-HBase · 2021-07-13T08:05:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 53s	branch-2 passed
+1 💚	compile	1m 8s	branch-2 passed
+1 💚	shadedjars	6m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	shadedjars	6m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	133m 16s	hbase-server in the patch passed.
		161m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5111ca4c264e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3294d32`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/3/testReport/
Max. process+thread count	4114 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-13T09:21:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 6s	branch-2 passed
+1 💚	compile	1m 7s	branch-2 passed
+1 💚	shadedjars	6m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 43s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	6m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	209m 9s	hbase-server in the patch passed.
		236m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 70d56c4352da 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `3294d32`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/3/testReport/
Max. process+thread count	2450 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-13T12:28:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 19s	branch-2 passed
+1 💚	compile	1m 11s	branch-2 passed
+1 💚	shadedjars	7m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 4s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	shadedjars	8m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	154m 50s	hbase-server in the patch passed.
		185m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c2d53480a52c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fa8bc25`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/4/testReport/
Max. process+thread count	3429 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-13T13:21:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 40s	branch-2 passed
+1 💚	compile	1m 0s	branch-2 passed
+1 💚	shadedjars	6m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	6m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	211m 42s	hbase-server in the patch passed.
		238m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4ca03ae40315 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `fa8bc25`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/4/testReport/
Max. process+thread count	2425 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java

Apache-HBase · 2021-07-14T07:10:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 59s	branch-2 passed
+1 💚	compile	1m 8s	branch-2 passed
+1 💚	shadedjars	6m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	6m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	145m 39s	hbase-server in the patch passed.
		176m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 96bf3c9d4155 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `12f2a16`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/5/testReport/
Max. process+thread count	4014 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-14T07:23:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 49s	branch-2 passed
+1 💚	compile	1m 13s	branch-2 passed
+1 💚	shadedjars	8m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 25s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	7m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
-1 ❌	unit	157m 45s	hbase-server in the patch failed.
		190m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b697923d274d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `12f2a16`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/5/testReport/
Max. process+thread count	4151 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-15T08:29:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 52s	branch-2 passed
+1 💚	compile	3m 22s	branch-2 passed
+1 💚	checkstyle	1m 8s	branch-2 passed
+1 💚	spotbugs	2m 14s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	compile	3m 20s	the patch passed
+1 💚	javac	3m 20s	the patch passed
+1 💚	checkstyle	1m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 7s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 26s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		41m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux ac648219ede2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `692d384`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-15T11:02:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	3m 46s	branch-2 passed
+1 💚	compile	1m 1s	branch-2 passed
+1 💚	shadedjars	6m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 26s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	5m 57s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	161m 12s	hbase-server in the patch passed.
		187m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e16435ee209f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `692d384`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/testReport/
Max. process+thread count	3733 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-07-15T11:04:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+1 💚	mvninstall	4m 37s	branch-2 passed
+1 💚	compile	1m 15s	branch-2 passed
+1 💚	shadedjars	7m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	branch-2 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 20s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	shadedjars	7m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	142m 5s	hbase-server in the patch passed.
		172m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3473
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b7df8fefb7e5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `692d384`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/testReport/
Max. process+thread count	4055 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3473/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…ing CombinedBlockCache (#3473) Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by Reid Chan <reidchan@apache.org>

HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when us…

613b577

…ing CombinedBlockCache

Fix a logic bug.

87997c7

YutSean closed this Jul 13, 2021

YutSean reopened this Jul 13, 2021

Add metric update in containsBlock method

6c79aea

Refine the metrics update

7e07fd7

YutSean added 2 commits July 13, 2021 13:40

Refine the metrics update

11724fa

trigger QA

2f70542

Reidddddd requested changes Jul 14, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java Outdated Show resolved Hide resolved

Reidddddd requested changes Jul 14, 2021

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java Outdated Show resolved Hide resolved

Refine the L1 miss metric in combinedBC

192b212

YutSean requested a review from Reidddddd July 14, 2021 05:37

Refine the metric update condition

ad2f086

anoopsjohn approved these changes Jul 15, 2021

View reviewed changes

Reidddddd approved these changes Jul 16, 2021

View reviewed changes

Reidddddd merged commit fb01a6c into apache:branch-2 Jul 16, 2021

asfgit pushed a commit that referenced this pull request Jul 16, 2021

HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when us…

5ee1447

…ing CombinedBlockCache (#3473) Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by Reid Chan <reidchan@apache.org>

asfgit pushed a commit that referenced this pull request Jul 16, 2021

HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when us…

ddcd585

…ing CombinedBlockCache (#3473) Signed-off-by Anoop Sam John <anoopsamjohn@apache.org> Signed-off-by Reid Chan <reidchan@apache.org>

HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache #3473

HBASE-26083 In branch-2 & branch-1 L1 miss metric is always 0 when using CombinedBlockCache #3473

Uh oh!

Conversation

YutSean commented Jul 12, 2021

Uh oh!

Apache-HBase commented Jul 12, 2021

Uh oh!

Apache-HBase commented Jul 12, 2021

Uh oh!

jojochuang commented Jul 12, 2021

Uh oh!

YutSean commented Jul 13, 2021

Uh oh!

Apache-HBase commented Jul 13, 2021

Uh oh!

Apache-HBase commented Jul 13, 2021

Uh oh!

anoopsjohn commented Jul 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YutSean commented Jul 13, 2021

Uh oh!

YutSean commented Jul 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Apache-HBase commented Jul 13, 2021

Uh oh!

Apache-HBase commented Jul 13, 2021

Uh oh!

Apache-HBase commented Jul 13, 2021

Uh oh!

Apache-HBase commented Jul 13, 2021

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Jul 14, 2021

Uh oh!

Apache-HBase commented Jul 14, 2021

Uh oh!

Apache-HBase commented Jul 15, 2021

Uh oh!

Apache-HBase commented Jul 15, 2021

Uh oh!

Apache-HBase commented Jul 15, 2021

Uh oh!

Uh oh!

anoopsjohn commented Jul 13, 2021 •

edited

Loading

YutSean commented Jul 13, 2021 •

edited

Loading