HBASE-22624 Should sanity check table configuration when clone snapsh… #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
the-sakthi
reviewed
Jun 27, 2019
| @@ -94,7 +95,7 @@ public void setConf(Configuration conf) { | |||
| String.format("%s.%s", TEST_NAME, LoadTestTool.OPT_COLUMN_FAMILIES), | |||
| StringUtils.join(",", DEFAULT_COLUMN_FAMILIES)); | |||
|
|
|||
| conf.setBoolean("hbase.table.sanity.checks", true); | |||
| conf.setBoolean(TableDescriptorChecker.TABLE_SANITY_CHECKS, true); | |||
There was a problem hiding this comment.
Is this different from other conf.setBoolean("hbase.table.sanity.checks", true) which is removed from other tests like TestAvoidCellReferencesIntoShippedBlocks based on the default value of TableDescriptorChecker.TABLE_SANITY_CHECKS?
There was a problem hiding this comment.
This is in moudle hbase-it. And this may be runed by user directly and with user's hbase-site.xml? So i didn't remove this.
the-sakthi
reviewed
Jun 27, 2019
| */ | ||
| public static void sanityCheck(final Configuration conf, final TableDescriptor td, | ||
| boolean checkCompression, boolean checkEncryption) throws IOException { | ||
| boolean logWarn = false; |
There was a problem hiding this comment.
Can we add a comment here along the lines of: "Setting this to true logs the warning instead of throwing"?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
openinx
reviewed
Jul 2, 2019
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
…ot to a new table
|
💔 -1 overall
This message was automatically generated. |
|
The failed ut should not related. Let me take a try on my local PC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ot to a new table