[HBASE-22606] : BucketCache additional tests #333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wchevreuil Please review. Due to build issue, had to close #324 and create a new PR. Apologies for the same as I could not get why the build was giving -1 for patch even though the branch was already rebased with master. |
saintstack
reviewed
Jun 24, 2019
| @@ -136,7 +135,7 @@ public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf) { | |||
| @Before | |||
| public void setup() throws IOException { | |||
| cache = new MockedBucketCache(ioEngineName, capacitySize, constructedBlockSize, | |||
| constructedBlockSizes, writeThreads, writerQLen, persistencePath); | |||
There was a problem hiding this comment.
Why make persistencePath null?
There was a problem hiding this comment.
Since persistencePath was defined as null and was not getting updated in the file ever after, I thought of removing the declaration and directly putting null
|
|
||
| @Test | ||
| public void testRetrieveFromMMap() throws Exception { | ||
| HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); |
There was a problem hiding this comment.
Do we get a new HBaseTestingUtility per test? If so, why not in the test setup rather than at head of each test?
Also CAPITALIZATION of variables is for statics, not locals as here.
Make a data member named testUtil and create the HTU instance in the @before ?
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
Outdated
Show resolved
Hide resolved
|
@saintstack Thanks for the review. Updated the PR. Please review |
|
🎊 +1 overall
This message was automatically generated. |
the-sakthi
reviewed
Jun 24, 2019
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
Outdated
Show resolved
Hide resolved
the-sakthi
suggested changes
Jun 24, 2019
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
Show resolved
Hide resolved
the-sakthi
reviewed
Jun 24, 2019
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
@jatsakthi Thanks for your review. Updated the PR addressing all comments. Please take a look. Also, additional test for above mentioned scenarios are added: |
the-sakthi
reviewed
Jun 25, 2019
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@jatsakthi @busbey build is failing every time with some InterruptedIOException. Every time different test cases fail with IOE. How should we usually deal with it? |
|
@virajjasani usually the best way is to check if the tests are present in the upstream flakey list. If yes, then we can usually bypass this. Else, you can run the failing tests locally to check if they ought to pass. Thirdly, if it's almost guaranteed that the test failure is unrelated to the changes proposed, in that case, we can ignore the tests failures. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Thanks @jatsakthi |
the-sakthi
approved these changes
Jun 27, 2019
|
@wchevreuil @saintstack Please let me know if this looks good to you |
|
Please review @saintstack @wchevreuil |
wchevreuil
approved these changes
Jul 1, 2019
wchevreuil
approved these changes
Jul 1, 2019
|
lgtm +1 on the latest commits. @jatsakthi @saintstack let me know if you guys have any other remarks, if not, I can squash the commits and merge the PR into master with your "signedoffs". |
|
Please review @saintstack |
|
The changes look good to me @wchevreuil |
|
Could you please take a look on this once @saintstack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.