Skip to content

HBASE-22615 Make TestChoreService more robust to timing #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HBASE-22615 Make TestChoreService more robust to timing #328

wants to merge 1 commit into from

Conversation

busbey
Copy link
Contributor

@busbey busbey commented Jun 21, 2019

  • phrase fudge factor "deltas" in terms of the original period
  • increase the delta allowed for chore timing from 5% to 20%
  • improve some assertions

@busbey
HBASE-22615 Make TestChoreService more robust to timing
03b9972 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Change-Id: I35de83846e1f052a6f534226b6350f7790679e18
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 118 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 303 master passed
+1 compile 24 master passed
+1 checkstyle 25 master passed
+1 shadedjars 301 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 42 master passed
+1 javadoc 21 master passed
_ Patch Compile Tests _
+1 mvninstall 269 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
+1 checkstyle 24 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 279 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 867 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 49 the patch passed
+1 javadoc 19 the patch passed
_ Other Tests _
+1 unit 159 hbase-common in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2857
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-328/1/artifact/out/Dockerfile
GITHUB PR #328
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3c3c7984dc11 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 6d08ffc
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-328/1/testReport/
Max. process+thread count 252 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-328/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor Author

busbey commented Jun 21, 2019

before this change it takes me ~10 runs to get a failure. after it so far I've gotten through 25.

@busbey
Copy link
Contributor Author

busbey commented Jun 22, 2019

have now gotten through 100 additional runs with this patch in place.

Reidddddd
Reidddddd approved these changes Jun 22, 2019
View reviewed changes
Copy link
Contributor

@Reidddddd Reidddddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@the-sakthi
Copy link
Member

+1 from my side as well, Sean!

@busbey
Copy link
Contributor Author

busbey commented Jun 22, 2019

thanks folks!

@asfgit asfgit closed this in 9aee88e Jun 22, 2019
asfgit pushed a commit that referenced this pull request Jun 22, 2019
@busbey
HBASE-22615 Make TestChoreService more robust to timing
23a2f8a 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes #328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
@busbey busbey deleted the HBASE-22615 branch June 22, 2019 06:15
asfgit pushed a commit that referenced this pull request Jun 22, 2019
@busbey
HBASE-22615 Make TestChoreService more robust to timing
8dde7d2 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes #328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
asfgit pushed a commit that referenced this pull request Jun 22, 2019
@busbey
HBASE-22615 Make TestChoreService more robust to timing
360288a 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes #328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
asfgit pushed a commit that referenced this pull request Jun 22, 2019
@busbey
HBASE-22615 Make TestChoreService more robust to timing
19035be 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes #328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
asfgit pushed a commit that referenced this pull request Jun 22, 2019
@busbey
HBASE-22615 Make TestChoreService more robust to timing
044ffa1 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes #328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
asfgit pushed a commit that referenced this pull request Jun 22, 2019
@busbey
HBASE-22615 Make TestChoreService more robust to timing
3ac12ef 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes #328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
asfgit pushed a commit that referenced this pull request Jun 22, 2019
@busbey
HBASE-22615 Make TestChoreService more robust to timing
fda06ed 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes #328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Jul 3, 2019
@busbey @wchevreuil
HBASE-22615 Make TestChoreService more robust to timing
96e3b3f 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes apache#328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
wchevreuil added a commit to wchevreuil/hbase that referenced this pull request Oct 28, 2019
@wchevreuil
Addressing PR comments:
f0cb94f 
1) Could you add a unit test with the recovered edits archiving enabled but has hbase.wal.dir set to a different directory? I think we could still validate your fix by seeing that the recovered.edits are in the hbase.wal.dir directory instead of the normal archive directory.
> Added testArchiveRecoveredEditsReplay on TestHRegion, where recovered edits are created with hbase.region.archive.recovered.edits as true and wal dir set to a different dir in the same FS as root dir;

2) A comment would help here since we're using this method that is for "storeFiles" for something that isn't a storefile.
> Added further explanation for the if structure on line apache#328 of HFileArchive.

3) What happens if I give hbase.wal.dir=hdfs://127.0.0.1:8020/nested/hbase/wals. This logic breaks, right?
> Switched for using Path accordingly.

Checkstyles and Javadoc issues fixed.

Additional UTs added in TestHFuleArchiving, testing for different combinations of wald dir and root dir settings.
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@busbey @Apache9
HBASE-22615 Make TestChoreService more robust to timing
d33f5cb 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes apache#328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@busbey
HBASE-22615 Make TestChoreService more robust to timing
af6c9e8 
* phrase fudge factor "deltas" in terms of the original period
* increase the delta allowed for chore timing from 5% to 20%
* improve some assertions

Closes apache#328

Signed-off-by: Reid Chan <reidchan@apache.org>
Signed-off-by: Sakthi <sakthivel.azhaku@gmail.com>
(cherry picked from commit 9aee88e)
(cherry picked from commit 8dde7d2)

Change-Id: Ife616d4b5124d44471912d370ec443e7feede835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reidddddd Reidddddd Reidddddd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busbey @Apache-HBase @the-sakthi @Reidddddd