[HBASE-22592] : HMaster Construction failure stacktrace to be availab… #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le in .out file - Useful if Logger class is not loaded yet
This was referenced Jun 16, 2019
|
💔 -1 overall
This message was automatically generated. |
|
retest this please |
|
I kicked off another build in case the test failure is unrelated. |
HorizonNet
reviewed
Jun 16, 2019
| @@ -244,6 +244,7 @@ private int startMaster() { | |||
| throw new RuntimeException("HMaster Aborted"); | |||
| } | |||
| } catch (Throwable t) { | |||
| t.printStackTrace(); | |||
There was a problem hiding this comment.
Will the error be present in the log files with this change? Is there a better way to do this, but still using the logger?
There was a problem hiding this comment.
I thought about that but as per the screenshot provided in the description, the Exception provided is not available in log file because Logger is not yet loaded.
Anyways, adding printstacktrace() would ensure that the StackTrace is atleast available in .out file. If the Logger is created and loaded by that time, then it would also be present in .log file based on: LOG.error("Master exiting", t);
|
💔 -1 overall
This message was automatically generated. |
|
Error not relevant. |
revert
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@apurtell please review |
busbey
requested changes
Jun 19, 2019
@busbey I agree we shouldn't print everything to stdout when logger is available. However, the error present in the screenshot was encountered due to a library that contained some incompatible guava method and HBase had classpath setup to use that library. Hence, when HMaster was started, no error was printed to .log or .out file. We had to attach JDB to figure out this Exception. |
|
the current patch prints a stack trace to stdout for any throwable. we know there are lots of ways to bring down the master with a throwable that will have a logger in place. Don't print those to stdout. at a minimum you should be adding a catch block for things that are likely to go wrong in a way that can predate a logger being available in the runtime. The stacktrace in your screen shot shows a problem that should not be possible before the logging system is available (it happens in a catch block in an instance method and the logger is a final static variable that should be initialized already before any instances can be created). So please include a reproduction that ensures proper logging configs. |
|
After updating the dependent library, I am not able to repro this Exception anymore. Tried certain ways but didn't get much progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le in .out file - Useful if Logger class is not loaded yet
An example of Exception(NoSuchMethodError) which is not present in .log/.out files: