HBASE-25518 Support separate child regions to different region servers #3001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Mar 15, 2021
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Patch looks good. Some comments below.
| } | ||
|
|
||
| /** | ||
| * Create round robin assign procedures for the give regions, |
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll change it.
| /** Default value for the balancer period */ | ||
| public static final int DEFAULT_HBASE_BALANCER_PERIOD = 300000; | ||
|
|
||
| /** Config for support separate child regions */ |
Contributor
There was a problem hiding this comment.
I think this config needs more explaination about what it enables. Does it need a default setting too?
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll add more explanation and a default value for it.
| ServerName parentServer) { | ||
| if(env.getMasterConfiguration().getBoolean(HConstants.HBASE_ENABLE_SEPARATE_CHILD_REGIONS, | ||
| false)){ | ||
| // keep daughter one on the parent RS |
Contributor
There was a problem hiding this comment.
s/keep daughter one/keep one daughter/
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll change it.
|
|
||
| @Test | ||
| public void testSplitTableRegionAndSeparateChildRegions() throws Exception { | ||
| cleanupTest(); |
Contributor
There was a problem hiding this comment.
You should make a new test suite with this test in it rather than do this cleanupTest and setupCluster... These methods are for before the test class and after... not for calling in the test as here.
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll change it.
| assertEquals("Table region not correct.", 2, tableRegions.size()); | ||
| Map<RegionInfo, ServerName> regionInfoMap = UTIL.getHBaseCluster().getMaster().getAssignmentManager() | ||
| .getRegionStates().getRegionAssignments(); | ||
| assertNotEquals(regionInfoMap.get(tableRegions.get(0).getRegionInfo()), |
Contributor
There was a problem hiding this comment.
How can you be sure the roundrobin will not assign both daughters to same server?
Contributor
Author
There was a problem hiding this comment.
Because the test cluster has three region servers, and before the round robin assignment, one daughter will be kept on the parent server, which will be excluded from the round robin servers set. At last, the other daughter and its replicas will be assigned to the other two servers. More than one servers in the destination server set will make round robin work well.
sunhelly
force-pushed
the
HBASE-25518
branch
3 times, most recently
from
d5abc17 to
a5f6706
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Shout if you need input on how to fix the licensing issue. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
pushed a commit
that referenced
this pull request
Mar 18, 2021
#3001) Signed-off-by: stack <stack@apache.org>
saintstack
pushed a commit
that referenced
this pull request
Mar 18, 2021
#3001) Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.