HBASE-25476 Enable error prone check in pre commit #2860

Apache9 · 2021-01-08T09:44:14Z

No description provided.

Apache-HBase · 2021-01-08T09:46:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for patch
		_ Other Tests _
		1m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2860
Optional Tests
uname	Linux 05d6156b7cb5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2444d26`
Max. process+thread count	49 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-08T09:46:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for patch
		_ Other Tests _
		1m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2860
Optional Tests
uname	Linux 1ea28f25eca7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2444d26`
Max. process+thread count	53 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-08T09:47:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for patch
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+0 🆗	asflicense	0m 0s	ASF License check generated no output?
		2m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2860
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux 755cfd4e6d70 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2444d26`
Max. process+thread count	52 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/1/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-01-08T11:05:14Z

Add compile and javac plugin back for general check, and also remove the skip-errorprone flag for general check so if there are error prone errors which causes compilation error, the general check will fail.

See this PR for an example.

#2856

Apache-HBase · 2021-01-11T01:55:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for patch
		_ Other Tests _
		1m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2860
Optional Tests
uname	Linux 2a437038d07a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `686b72c`
Max. process+thread count	55 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-11T01:56:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for patch
		_ Other Tests _
		2m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2860
Optional Tests
uname	Linux 0015dc8684bf 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `686b72c`
Max. process+thread count	51 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-11T01:56:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	shelldocs	0m 0s	Shelldocs was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 7s	Maven dependency ordering for patch
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+0 🆗	asflicense	0m 0s	ASF License check generated no output?
		3m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2860
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux 7b0730232927 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `686b72c`
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2860/2/console
versions	git=2.17.1 maven=3.6.3 shellcheck=0.4.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

infraio · 2021-01-11T03:25:29Z

dev-support/Jenkinsfile_GitHub

@@ -168,6 +168,7 @@ pipeline {
                        BUILD_URL_ARTIFACTS = "artifact/${WORKDIR_REL}/${PATCH_REL}"
                        DOCKERFILE = "${WORKDIR}/${DOCKERFILE_REL}"
                        YETUS_DRIVER = "${WORKDIR}/${YETUS_DRIVER_REL}"
+                        SKIP_ERRORPRONE = true


default is enable, so skip for "yetus jdk8 Hadoop3 checks"?

Yes, will skip for jdk8 and jdk11 checks. Only enable it in general check.

infraio

+1

Signed-off-by: Guanghao Zhang <zghao@apache.org>

Apache9 requested a review from busbey January 8, 2021 11:03

Apache9 self-assigned this Jan 8, 2021

HBASE-25476 Enable error prone check in pre commit

80ebabd

asfgit force-pushed the HBASE-25476 branch from c585789 to 80ebabd Compare January 11, 2021 01:52

infraio reviewed Jan 11, 2021

View reviewed changes

infraio approved these changes Jan 13, 2021

View reviewed changes

Apache9 merged commit 13dd54a into master Jan 13, 2021

Apache9 deleted the HBASE-25476 branch January 13, 2021 07:16

Apache9 added a commit that referenced this pull request Jan 13, 2021

HBASE-25476 Enable error prone check in pre commit (#2860)

40629b3

Signed-off-by: Guanghao Zhang <zghao@apache.org>

Apache9 added a commit that referenced this pull request Jan 13, 2021

HBASE-25476 Enable error prone check in pre commit (#2860)

2f6700b

Signed-off-by: Guanghao Zhang <zghao@apache.org>

Apache9 added a commit that referenced this pull request Jan 13, 2021

HBASE-25476 Enable error prone check in pre commit (#2860)

e0cdaad

Signed-off-by: Guanghao Zhang <zghao@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-25476 Enable error prone check in pre commit #2860

HBASE-25476 Enable error prone check in pre commit #2860

Uh oh!

Apache9 commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 8, 2021

Uh oh!

Apache9 commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 11, 2021

Uh oh!

Apache-HBase commented Jan 11, 2021

Uh oh!

Apache-HBase commented Jan 11, 2021

Uh oh!

infraio Jan 11, 2021

Uh oh!

Apache9 Jan 11, 2021

Uh oh!

infraio left a comment

Uh oh!

Uh oh!

HBASE-25476 Enable error prone check in pre commit #2860

HBASE-25476 Enable error prone check in pre commit #2860

Uh oh!

Conversation

Apache9 commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 8, 2021

Uh oh!

Apache9 commented Jan 8, 2021

Uh oh!

Apache-HBase commented Jan 11, 2021

Uh oh!

Apache-HBase commented Jan 11, 2021

Uh oh!

Apache-HBase commented Jan 11, 2021

Uh oh!

infraio Jan 11, 2021

Choose a reason for hiding this comment

Uh oh!

Apache9 Jan 11, 2021

Choose a reason for hiding this comment

Uh oh!

infraio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!