-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb #2858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…e configuration from tableDescriptor
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
final long totalSizeMb = tableRegions.stream() | ||
.mapToLong(this::getRegionSizeMB) | ||
.sum(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just to be sure on the goal here, this is just to avoid this loop always happen, even when totalSizeMb is not been used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is origin goal. If we set NormalizerTargetRegionSize, we use NormalizerTargetRegionSize as avgRegionSize and return. But now I found another serious bug, NormalizerTargetRegionCount and NormalizerTargetRegionSize will never used when log level is not debug.
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, ouch. Good find 👍
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Any further comments/concerns @wchevreuil ? |
…ache#2858) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…ache#2858) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
…ache#2858) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
HBASE-25482
If the table is set NormalizerTargetRegionSize, we take NormalizerTargetRegionSize as avgRegionSize and return it. So the totalSizeMb of table is not always calculated.