HBASE-24640 Purge use of VisibleForTesting

[apurtell]

No description provided.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 3s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 42s	master passed
+1 💚	checkstyle	5m 45s	master passed
+1 💚	spotbugs	10m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 15s	the patch passed
-0 ⚠️	checkstyle	0m 36s	hbase-common: The patch generated 11 new + 375 unchanged - 2 fixed = 386 total (was 377)
-0 ⚠️	checkstyle	0m 39s	hbase-client: The patch generated 8 new + 211 unchanged - 5 fixed = 219 total (was 216)
-0 ⚠️	checkstyle	0m 14s	hbase-replication: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	0m 15s	hbase-http: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)
-0 ⚠️	checkstyle	0m 17s	hbase-procedure: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
-0 ⚠️	checkstyle	1m 48s	hbase-server: The patch generated 112 new + 1041 unchanged - 31 fixed = 1153 total (was 1072)
-0 ⚠️	checkstyle	0m 23s	hbase-mapreduce: The patch generated 1 new + 63 unchanged - 2 fixed = 64 total (was 65)
-0 ⚠️	checkstyle	1m 9s	hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	0m 14s	hbase-endpoint: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 56s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	15m 48s	the patch passed
		_ Other Tests _
+1 💚	asflicense	2m 43s	The patch does not generate ASF License warnings.
		87m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux c9e181bd2e40 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 1cd8f3c
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-replication.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-endpoint.txt
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 13s	master passed
+1 💚	compile	6m 10s	master passed
+1 💚	shadedjars	6m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	6m 12s	the patch passed
+1 💚	javac	6m 12s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 43s	hbase-common in the patch passed.
+1 💚	unit	0m 20s	hbase-metrics-api in the patch passed.
+1 💚	unit	0m 35s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 6s	hbase-client in the patch passed.
+1 💚	unit	0m 43s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 28s	hbase-replication in the patch passed.
+1 💚	unit	0m 22s	hbase-balancer in the patch passed.
+1 💚	unit	0m 43s	hbase-http in the patch passed.
+1 💚	unit	1m 40s	hbase-procedure in the patch passed.
+1 💚	unit	138m 50s	hbase-server in the patch passed.
+1 💚	unit	11m 30s	hbase-mapreduce in the patch passed.
+1 💚	unit	4m 55s	hbase-thrift in the patch passed.
+1 💚	unit	3m 36s	hbase-endpoint in the patch passed.
+1 💚	unit	9m 36s	hbase-backup in the patch passed.
		227m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 85506ae6ccf0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 1cd8f3c
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/testReport/
Max. process+thread count	5025 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 2s	master passed
+1 💚	compile	5m 23s	master passed
+1 💚	shadedjars	7m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 11s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 49s	the patch passed
+1 💚	compile	5m 21s	the patch passed
+1 💚	javac	5m 21s	the patch passed
+1 💚	shadedjars	7m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 36s	hbase-common in the patch passed.
+1 💚	unit	0m 17s	hbase-metrics-api in the patch passed.
+1 💚	unit	0m 36s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 11s	hbase-client in the patch passed.
+1 💚	unit	0m 42s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 34s	hbase-replication in the patch passed.
+1 💚	unit	0m 20s	hbase-balancer in the patch passed.
+1 💚	unit	0m 47s	hbase-http in the patch passed.
+1 💚	unit	1m 55s	hbase-procedure in the patch passed.
+1 💚	unit	206m 0s	hbase-server in the patch passed.
+1 💚	unit	14m 4s	hbase-mapreduce in the patch passed.
+1 💚	unit	5m 8s	hbase-thrift in the patch passed.
+1 💚	unit	3m 0s	hbase-endpoint in the patch passed.
+1 💚	unit	12m 28s	hbase-backup in the patch passed.
		296m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1172f8fcdad0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 1cd8f3c
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/testReport/
Max. process+thread count	3277 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[apurtell]

@Reidddddd Mind adding your +1 here as well so I can merge down the line? Sorry to bother.

[Reidddddd]

+1

[apurtell]

Thanks @Reidddddd !

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 4s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 43s	master passed
+1 💚	checkstyle	5m 59s	master passed
+1 💚	spotbugs	10m 10s	master passed
-0 ⚠️	patch	2m 18s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
-0 ⚠️	checkstyle	0m 34s	hbase-common: The patch generated 11 new + 376 unchanged - 2 fixed = 387 total (was 378)
-0 ⚠️	checkstyle	0m 34s	hbase-client: The patch generated 8 new + 211 unchanged - 5 fixed = 219 total (was 216)
-0 ⚠️	checkstyle	0m 13s	hbase-replication: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	0m 15s	hbase-http: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7)
-0 ⚠️	checkstyle	0m 15s	hbase-procedure: The patch generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
-0 ⚠️	checkstyle	1m 34s	hbase-server: The patch generated 112 new + 1041 unchanged - 31 fixed = 1153 total (was 1072)
-0 ⚠️	checkstyle	0m 21s	hbase-mapreduce: The patch generated 1 new + 63 unchanged - 2 fixed = 64 total (was 65)
-0 ⚠️	checkstyle	0m 57s	hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️	checkstyle	0m 13s	hbase-endpoint: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 14s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	12m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	2m 50s	The patch does not generate ASF License warnings.
		74m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 54b99415c045 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / fc33137
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-replication.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-endpoint.txt
Max. process+thread count	94 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[apurtell]

Aha, now the checkstyle warns show up here as in the branch-1 precommit. These are expected and legacy and related to import order. Let me make a pass over them.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 25s	master passed
+1 💚	compile	6m 23s	master passed
+1 💚	shadedjars	7m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 35s	master passed
-0 ⚠️	patch	15m 33s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 33s	the patch passed
+1 💚	compile	6m 26s	the patch passed
+1 💚	javac	6m 26s	the patch passed
+1 💚	shadedjars	6m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 49s	hbase-common in the patch passed.
+1 💚	unit	0m 20s	hbase-metrics-api in the patch passed.
+1 💚	unit	0m 38s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 13s	hbase-client in the patch passed.
+1 💚	unit	0m 45s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 29s	hbase-replication in the patch passed.
+1 💚	unit	0m 25s	hbase-balancer in the patch passed.
+1 💚	unit	0m 47s	hbase-http in the patch passed.
+1 💚	unit	1m 40s	hbase-procedure in the patch passed.
+1 💚	unit	132m 47s	hbase-server in the patch passed.
+1 💚	unit	9m 42s	hbase-mapreduce in the patch passed.
+1 💚	unit	4m 36s	hbase-thrift in the patch passed.
+1 💚	unit	3m 23s	hbase-endpoint in the patch passed.
+1 💚	unit	9m 21s	hbase-backup in the patch passed.
		222m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 62eace93bd06 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / fc33137
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/testReport/
Max. process+thread count	4911 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[apurtell]

Pushed checkstyle fixes

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 0s	master passed
+1 💚	compile	5m 21s	master passed
+1 💚	shadedjars	7m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 20s	master passed
-0 ⚠️	patch	13m 28s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	compile	5m 55s	the patch passed
+1 💚	javac	5m 55s	the patch passed
+1 💚	shadedjars	7m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 56s	hbase-common in the patch passed.
+1 💚	unit	0m 18s	hbase-metrics-api in the patch passed.
+1 💚	unit	0m 37s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
+1 💚	unit	0m 51s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 36s	hbase-replication in the patch passed.
+1 💚	unit	0m 22s	hbase-balancer in the patch passed.
+1 💚	unit	0m 47s	hbase-http in the patch passed.
+1 💚	unit	2m 11s	hbase-procedure in the patch passed.
+1 💚	unit	206m 40s	hbase-server in the patch passed.
+1 💚	unit	14m 39s	hbase-mapreduce in the patch passed.
+1 💚	unit	5m 18s	hbase-thrift in the patch passed.
+1 💚	unit	3m 7s	hbase-endpoint in the patch passed.
+1 💚	unit	12m 52s	hbase-backup in the patch passed.
		299m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f8dcbaf11b3e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / fc33137
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/testReport/
Max. process+thread count	3746 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 3s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 28s	master passed
+1 💚	checkstyle	5m 38s	master passed
+1 💚	spotbugs	10m 21s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 28s	the patch passed
+1 💚	checkstyle	0m 33s	hbase-common: The patch generated 0 new + 375 unchanged - 3 fixed = 375 total (was 378)
+1 💚	checkstyle	0m 12s	The patch passed checkstyle in hbase-metrics-api
+1 💚	checkstyle	0m 14s	The patch passed checkstyle in hbase-hadoop-compat
+1 💚	checkstyle	0m 34s	hbase-client: The patch generated 0 new + 210 unchanged - 6 fixed = 210 total (was 216)
+1 💚	checkstyle	0m 14s	The patch passed checkstyle in hbase-zookeeper
+1 💚	checkstyle	0m 13s	The patch passed checkstyle in hbase-replication
+1 💚	checkstyle	0m 13s	The patch passed checkstyle in hbase-balancer
+1 💚	checkstyle	0m 15s	The patch passed checkstyle in hbase-http
+1 💚	checkstyle	0m 15s	The patch passed checkstyle in hbase-procedure
-0 ⚠️	checkstyle	1m 30s	hbase-server: The patch generated 3 new + 1036 unchanged - 36 fixed = 1039 total (was 1072)
-0 ⚠️	checkstyle	0m 20s	hbase-mapreduce: The patch generated 1 new + 63 unchanged - 2 fixed = 64 total (was 65)
+1 💚	checkstyle	0m 57s	The patch passed checkstyle in hbase-thrift
+1 💚	checkstyle	0m 14s	The patch passed checkstyle in hbase-endpoint
+1 💚	checkstyle	0m 15s	The patch passed checkstyle in hbase-backup
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	16m 55s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	12m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	2m 47s	The patch does not generate ASF License warnings.
		73m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux f5d7e96c9116 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 4affae5
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-mapreduce.txt
Max. process+thread count	94 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 1s	master passed
+1 💚	compile	6m 10s	master passed
+1 💚	shadedjars	6m 38s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 15s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	6m 9s	the patch passed
-0 ⚠️	javac	0m 25s	hbase-common generated 1 new + 29 unchanged - 1 fixed = 30 total (was 30)
+1 💚	shadedjars	6m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 46s	hbase-common in the patch passed.
+1 💚	unit	0m 18s	hbase-metrics-api in the patch passed.
+1 💚	unit	0m 34s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 10s	hbase-client in the patch passed.
+1 💚	unit	0m 43s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 27s	hbase-replication in the patch passed.
+1 💚	unit	0m 22s	hbase-balancer in the patch passed.
+1 💚	unit	0m 41s	hbase-http in the patch passed.
+1 💚	unit	1m 39s	hbase-procedure in the patch passed.
-1 ❌	unit	149m 30s	hbase-server in the patch failed.
+1 💚	unit	12m 7s	hbase-mapreduce in the patch passed.
+1 💚	unit	4m 50s	hbase-thrift in the patch passed.
+1 💚	unit	3m 38s	hbase-endpoint in the patch passed.
+1 💚	unit	9m 35s	hbase-backup in the patch passed.
		238m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 570f813bf82a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 4affae5
Default Java	AdoptOpenJDK-11.0.6+10
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-hbase-common.txt
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/testReport/
Max. process+thread count	5080 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 2s	master passed
+1 💚	compile	5m 27s	master passed
+1 💚	shadedjars	7m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 6s	the patch passed
+1 💚	compile	5m 41s	the patch passed
-0 ⚠️	javac	0m 24s	hbase-common generated 1 new + 29 unchanged - 1 fixed = 30 total (was 30)
+1 💚	shadedjars	7m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 41s	hbase-common in the patch passed.
+1 💚	unit	0m 18s	hbase-metrics-api in the patch passed.
+1 💚	unit	0m 37s	hbase-hadoop-compat in the patch passed.
+1 💚	unit	1m 13s	hbase-client in the patch passed.
+1 💚	unit	0m 43s	hbase-zookeeper in the patch passed.
+1 💚	unit	0m 39s	hbase-replication in the patch passed.
+1 💚	unit	0m 19s	hbase-balancer in the patch passed.
+1 💚	unit	0m 48s	hbase-http in the patch passed.
+1 💚	unit	1m 58s	hbase-procedure in the patch passed.
+1 💚	unit	220m 12s	hbase-server in the patch passed.
+1 💚	unit	16m 27s	hbase-mapreduce in the patch passed.
+1 💚	unit	5m 24s	hbase-thrift in the patch passed.
+1 💚	unit	3m 24s	hbase-endpoint in the patch passed.
+1 💚	unit	13m 17s	hbase-backup in the patch passed.
		316m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2695
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d26d1f57306f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 4affae5
Default Java	AdoptOpenJDK-1.8.0_232-b09
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/artifact/yetus-jdk8-hadoop3-check/output/diff-compile-javac-hbase-common.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/testReport/
Max. process+thread count	3242 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics-api hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-endpoint hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2695/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[ndimiduk]

Herculean effort here, thank you @apurtell !