Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22484 Javadoc Warnings: Fix warnings coming due to @result tag i… #256

Merged
merged 1 commit into from
Jun 9, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
HBASE-2284 Javadoc Warnings: Fix warnings coming due to @Result tag i…
…n TestCoprocessorWhitelistMasterObserver
  • Loading branch information
murtazahassan123 committed May 27, 2019
commit 84b5b2fd65eac7d94f6e784ea0a65247559072d9
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ public void tearDownTestCoprocessorWhitelistMasterObserver() throws Exception {

/**
* Test a table modification adding a coprocessor path
* which is not whitelisted
* @result An IOException should be thrown and caught
* which is not whitelisted.
* @exception Exception should be thrown and caught
* to show coprocessor is working as desired
* @param whitelistedPaths A String array of paths to add in
* for the whitelisting configuration
Expand Down Expand Up @@ -127,9 +127,8 @@ private static void positiveTestCase(String[] whitelistedPaths,

/**
* Test a table modification adding a coprocessor path
* which is whitelisted
* @result The coprocessor should be added to the table
* descriptor successfully
* which is whitelisted. The coprocessor should be added to
* the table descriptor successfully.
* @param whitelistedPaths A String array of paths to add in
* for the whitelisting configuration
* @param coprocessorPath A String to use as the
Expand Down Expand Up @@ -168,8 +167,8 @@ private static void negativeTestCase(String[] whitelistedPaths,

/**
* Test a table modification adding a coprocessor path
* which is not whitelisted
* @result An IOException should be thrown and caught
* which is not whitelisted.
* @exception Exception should be thrown and caught
* to show coprocessor is working as desired
*/
@Test
Expand All @@ -180,10 +179,9 @@ public void testSubstringNonWhitelisted() throws Exception {

/**
* Test a table creation including a coprocessor path
* which is not whitelisted
* @result Coprocessor should be added to table descriptor
* Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk
* which is not whitelisted. Coprocessor should be added to
* table descriptor. Table is disabled to avoid an IOException due
* to the added coprocessor not actually existing on disk.
*/
@Test
public void testDifferentFileSystemNonWhitelisted() throws Exception {
Expand All @@ -193,10 +191,9 @@ public void testDifferentFileSystemNonWhitelisted() throws Exception {

/**
* Test a table modification adding a coprocessor path
* which is whitelisted
* @result Coprocessor should be added to table descriptor
* Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk
* which is whitelisted. Coprocessor should be added to table
* descriptor. Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk.
*/
@Test
public void testSchemeAndDirectorywhitelisted() throws Exception {
Expand All @@ -206,10 +203,9 @@ public void testSchemeAndDirectorywhitelisted() throws Exception {

/**
* Test a table modification adding a coprocessor path
* which is whitelisted
* @result Coprocessor should be added to table descriptor
* Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk
* which is whitelisted. Coprocessor should be added to table
* descriptor. Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk.
*/
@Test
public void testSchemeWhitelisted() throws Exception {
Expand All @@ -219,10 +215,9 @@ public void testSchemeWhitelisted() throws Exception {

/**
* Test a table modification adding a coprocessor path
* which is whitelisted
* @result Coprocessor should be added to table descriptor
* Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk
* which is whitelisted. Coprocessor should be added to table
* descriptor. Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk.
*/
@Test
public void testDFSNameWhitelistedWorks() throws Exception {
Expand All @@ -232,10 +227,9 @@ public void testDFSNameWhitelistedWorks() throws Exception {

/**
* Test a table modification adding a coprocessor path
* which is whitelisted
* @result Coprocessor should be added to table descriptor
* Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk
* which is whitelisted. Coprocessor should be added to table
* descriptor. Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk.
*/
@Test
public void testDFSNameNotWhitelistedFails() throws Exception {
Expand All @@ -245,10 +239,9 @@ public void testDFSNameNotWhitelistedFails() throws Exception {

/**
* Test a table modification adding a coprocessor path
* which is whitelisted
* @result Coprocessor should be added to table descriptor
* Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk
* which is whitelisted. Coprocessor should be added to table
* descriptor. Table is disabled to avoid an IOException due to
* the added coprocessor not actually existing on disk.
*/
@Test
public void testBlanketWhitelist() throws Exception {
Expand All @@ -258,8 +251,8 @@ public void testBlanketWhitelist() throws Exception {

/**
* Test a table creation including a coprocessor path
* which is not whitelisted
* @result Table will not be created due to the offending coprocessor
* which is not whitelisted. Table will not be created due to the
* offending coprocessor.
*/
@Test
public void testCreationNonWhitelistedCoprocessorPath() throws Exception {
Expand Down Expand Up @@ -303,8 +296,8 @@ public Optional<RegionObserver> getRegionObserver() {

/**
* Test a table creation including a coprocessor path
* which is on the classpath
* @result Table will be created with the coprocessor
* which is on the classpath. Table will be created with the
* coprocessor.
*/
@Test
public void testCreationClasspathCoprocessor() throws Exception {
Expand Down