Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags #2348

Merged
merged 5 commits into from
Sep 3, 2020
Merged

HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags #2348

merged 5 commits into from
Sep 3, 2020

Conversation

esteban
Copy link
Contributor

@esteban esteban commented Sep 3, 2020

Patch adds setHttpOnly(true) and setSecure(true) when creating a new servlet via HttpServer#addInternalServlet

@esteban esteban requested a review from busbey September 3, 2020 15:42
@esteban
Copy link
Contributor Author

esteban commented Sep 3, 2020

Latest commit uses addPrivilegedServlet instead of addUnprivilegedServlet for test.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 22s master passed
+1 💚 compile 0m 19s master passed
+1 💚 shadedjars 7m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 59s the patch passed
+1 💚 compile 0m 20s the patch passed
+1 💚 javac 0m 20s the patch passed
+1 💚 shadedjars 7m 9s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
-1 ❌ unit 0m 42s hbase-http in the patch failed.
27m 18s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux 35c8f62e0615 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 1.8.0_232
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-http.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/testReport/
Max. process+thread count 425 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 3s master passed
+1 💚 compile 0m 23s master passed
+1 💚 shadedjars 7m 34s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-http in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 43s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
+1 💚 shadedjars 7m 30s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-http in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 43s hbase-http in the patch failed.
29m 30s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux cc457b01d1da 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-http.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/testReport/
Max. process+thread count 395 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 43s master passed
+1 💚 checkstyle 0m 16s master passed
+1 💚 spotbugs 0m 35s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 26s the patch passed
-0 ⚠️ checkstyle 0m 14s hbase-http: The patch generated 7 new + 7 unchanged - 0 fixed = 14 total (was 7)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 23s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 40s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
31m 44s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2348
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 0d222aa93197 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 39s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 23s master passed
+1 💚 compile 0m 20s master passed
+1 💚 shadedjars 7m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 3s the patch passed
+1 💚 compile 0m 20s the patch passed
+1 💚 javac 0m 20s the patch passed
+1 💚 shadedjars 7m 10s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s the patch passed
_ Other Tests _
+1 💚 unit 0m 50s hbase-http in the patch passed.
27m 33s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux d830c320b93c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/testReport/
Max. process+thread count 422 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 50s master passed
+1 💚 checkstyle 0m 15s master passed
+1 💚 spotbugs 0m 35s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 23s the patch passed
-0 ⚠️ checkstyle 0m 13s hbase-http: The patch generated 7 new + 7 unchanged - 0 fixed = 14 total (was 7)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 11m 14s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 40s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
28m 14s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2348
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 61270e8fd982 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@esteban
HBASE-19352 Port HADOOP-10379: Protect authentication cookies with th…
45b8c61 
…e HttpOnly and Secure flags

Fixed checkstyle warnings.
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 39s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 3s master passed
+1 💚 compile 0m 23s master passed
+1 💚 shadedjars 7m 28s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-http in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 48s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 shadedjars 7m 29s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-http in the patch failed.
_ Other Tests _
+1 💚 unit 0m 51s hbase-http in the patch passed.
29m 46s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux 13efeeaaa6ea 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/testReport/
Max. process+thread count 362 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/2/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@esteban
HBASE-19352 Port HADOOP-10379: Protect authentication cookies with th…
6122fe7 
…e HttpOnly and Secure flags

Fixed checkstyle warnings. (amend)
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 38s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 58s master passed
+1 💚 compile 0m 18s master passed
+1 💚 shadedjars 7m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 0s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 shadedjars 7m 13s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s the patch passed
_ Other Tests _
+1 💚 unit 0m 50s hbase-http in the patch passed.
26m 50s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux bab2a4d95f4c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/testReport/
Max. process+thread count 420 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 24s master passed
+1 💚 checkstyle 0m 14s master passed
+1 💚 spotbugs 0m 31s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 26s the patch passed
-0 ⚠️ checkstyle 0m 14s hbase-http: The patch generated 7 new + 7 unchanged - 0 fixed = 14 total (was 7)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 9s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 41s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
27m 19s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2348
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 658712ecf262 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 45s master passed
+1 💚 compile 0m 22s master passed
+1 💚 shadedjars 7m 32s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-http in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 47s the patch passed
+1 💚 compile 0m 23s the patch passed
+1 💚 javac 0m 23s the patch passed
+1 💚 shadedjars 7m 31s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-http in the patch failed.
_ Other Tests _
+1 💚 unit 0m 51s hbase-http in the patch passed.
29m 12s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux 204ec28aa570 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/testReport/
Max. process+thread count 356 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/3/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 35s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 0s master passed
+1 💚 compile 0m 19s master passed
+1 💚 shadedjars 7m 13s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 15s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 0m 19s the patch passed
+1 💚 javac 0m 19s the patch passed
+1 💚 shadedjars 7m 16s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
+1 💚 unit 0m 49s hbase-http in the patch passed.
26m 52s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3e82d54b1f35 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/testReport/
Max. process+thread count 424 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 46s master passed
+1 💚 checkstyle 0m 16s master passed
+1 💚 spotbugs 0m 34s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 26s the patch passed
-0 ⚠️ checkstyle 0m 14s hbase-http: The patch generated 7 new + 7 unchanged - 0 fixed = 14 total (was 7)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 11m 16s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 41s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 15s The patch does not generate ASF License warnings.
27m 57s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2348
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 7ab68787f232 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 52s master passed
+1 💚 compile 0m 22s master passed
+1 💚 shadedjars 7m 29s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-http in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 44s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
+1 💚 shadedjars 7m 28s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-http in the patch failed.
_ Other Tests _
+1 💚 unit 0m 51s hbase-http in the patch passed.
29m 7s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2348
Optional Tests javac javadoc unit shadedjars compile
uname Linux a1c687ada596 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a352706
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/testReport/
Max. process+thread count 388 (vs. ulimit of 12500)
modules C: hbase-http U: hbase-http
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2348/4/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@esteban esteban merged commit 19b8a2a into apache:master Sep 3, 2020
esteban added a commit that referenced this pull request Sep 3, 2020
@esteban
Revert " HBASE-19352 Port HADOOP-10379: Protect authentication cookie…
1c1a7be 
…s with the HttpOnly and Secure flags (#2348)"

This reverts commit 19b8a2a.
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@esteban @petersomogyi
HBASE-19352 Port HADOOP-10379: Protect authentication cookies with th…
bc4cb7c 
…e HttpOnly and Secure flags (apache#2348)

HBASE-19352 Port HADOOP-10379: Protect authentication cookies with the HttpOnly and Secure flags

Signed-off-by: Sean Busbey <busbey@apache.org>
(cherry picked from commit 19b8a2a)
Change-Id: I717879b22c591ec1ac3f32614fe2b29e05c4a017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busbey busbey busbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteban @Apache-HBase @busbey