HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table and splitParent region #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
infraio
reviewed
Aug 23, 2020
| private Map<TableName, Map<ServerName, List<RegionInfo>>> getRSGroupAssignmentsByTable( | ||
| String groupName) throws IOException { | ||
| @VisibleForTesting | ||
| Map<TableName, Map<ServerName, List<RegionInfo>>> getRSGroupAssignmentsByTable( |
There was a problem hiding this comment.
This method will be called when balance? Add some comments here?
There was a problem hiding this comment.
This method will be called when balance? Add some comments here?
Yes, only called by balanceRSGroup, triggered in manual way
nyl3532016
force-pushed
the
HBASE-24928
branch
from
6c2b864 to
e9f1e30
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Aug 23, 2020
Comment on lines
+1091
to
+1092
| if (region.isSplitParent()) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This seems an additional check to what PR title talks about. Can you please also add PR description reg this check?
There was a problem hiding this comment.
This seems an additional check to what PR title talks about. Can you please also add PR description reg this check?
Yes, I have amended the PR description
nyl3532016
changed the title
nyl3532016
force-pushed
the
HBASE-24928
branch
from
e9f1e30 to
01b0907
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
approved these changes
Aug 23, 2020
Comment on lines
1070
to
1071
| * Can't let out original since it can change and at least the load balancer | ||
| * wants to iterate this exported list. |
There was a problem hiding this comment.
Maybe for these two lines, we can mention:
Load balancer should iterate over this list because cloned list will ignore disabled table and split parent region cases.
There was a problem hiding this comment.
I have added this comment
…sabled table and splitParent region
nyl3532016
force-pushed
the
HBASE-24928
branch
from
01b0907 to
b7cba89
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.