-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-22389 Revert "HBASE-19275 TestSnapshotFileCache never worked pr… #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note this will actually cause the new test added in HBASE-21070 in TestSnapshotFileCache to fail until HBASE-22190 is backported (I'm opening a different PR for that). I originally missed that it wasn't backported to branch-1, then when I realized it wasn't, I was confused why the test I added was passing which led me to this. |
|
#230 should be merged first since it will cause test failures otherwise (as mentioned previously) |
|
💔 -1 overall
This message was automatically generated. |
apurtell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Also approved #230
…operly" This reverts commit e8e4bea.
|
Reran TestSnapshotFileCache after #230 and confirmed it passes now. Fixed checkstyle. |
|
💔 -1 overall
This message was automatically generated. |
…operly"
This reverts commit e8e4bea.