Skip to content

HBASE-22358 Change rubocop configuration for method length #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2019

Conversation

murtazahassan123
Copy link
Contributor

Changed configuration and analyzed the code and the change in configuration works.

Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending QA.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 57 Docker mode activated.
_ Prechecks _
0 yamllint 0 yamllint was not available.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 1 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 408 master passed
+1 javadoc 49 master passed
_ Patch Compile Tests _
+1 mvninstall 412 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 javadoc 40 the patch passed
_ Other Tests _
+1 unit 486 hbase-shell in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2075
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-227/1/artifact/out/Dockerfile
GITHUB PR #227
Optional Tests dupname asflicense javac javadoc unit yamllint
uname Linux d6a6abbd4f30 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 46fe983
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-227/1/testReport/
Max. process+thread count 2611 (vs. ulimit of 10000)
modules C: hbase-shell U: hbase-shell
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-227/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit 600dfae into apache:master May 9, 2019
@HorizonNet
Copy link
Contributor

Merged to master. Thanks @SyedMurtazaHassan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants