HBASE-24843 Sort the constants in `hbase_constants.rb` #2236

ndimiduk · 2020-08-10T18:38:46Z

Addresses comment from #2215

liuml07

+1

Unless we have a very clear way to categorize those constants in several groups, alphabetical order is usually preferred.

Apache-HBase · 2020-08-10T19:44:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	rubocop	0m 6s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		3m 11s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2236
Optional Tests	dupname asflicense rubocop
uname	Linux b7d4282715a8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c1c2e16`
Max. process+thread count	42 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-10T20:05:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 53s	master passed
+1 💚	javadoc	0m 19s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 37s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 0s	hbase-shell in the patch passed.
		20m 9s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2236
Optional Tests	javac javadoc unit
uname	Linux 11f8b6a38ecc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c1c2e16`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/testReport/
Max. process+thread count	1520 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-10T20:27:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 29s	master passed
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 13s	the patch passed
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
-1 ❌	unit	6m 58s	hbase-shell in the patch failed.
		20m 41s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2236
Optional Tests	javac javadoc unit
uname	Linux 47907e6285dc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c1c2e16`
Default Java	2020-01-14
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/testReport/
Max. process+thread count	1511 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

ndimiduk · 2020-08-11T16:13:35Z

| -1 ❌ | unit | 6m 58s | hbase-shell in the patch failed. |

Hmm weird. mvn clean install -DskipTests && mvn -pl hbase-shell test passes locally. re-kicking the precommit build.

Apache-HBase · 2020-08-11T19:50:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	rubocop	0m 5s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		2m 26s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2236
Optional Tests	dupname asflicense rubocop
uname	Linux 5eddc6e6238f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ea13024`
Max. process+thread count	46 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) rubocop=0.80.0
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-11T20:06:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 57s	master passed
+1 💚	javadoc	0m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 37s	the patch passed
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 6s	hbase-shell in the patch passed.
		17m 38s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2236
Optional Tests	javac javadoc unit
uname	Linux 721eb0bf8f60 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ea13024`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/testReport/
Max. process+thread count	2352 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-11T20:10:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 41s	master passed
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 30s	the patch passed
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 0s	hbase-shell in the patch passed.
		19m 33s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2236
Optional Tests	javac javadoc unit
uname	Linux 934c8e060c8c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ea13024`
Default Java	2020-01-14
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/testReport/
Max. process+thread count	1580 (vs. ulimit of 12500)
modules	C: hbase-shell U: hbase-shell
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2236/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Mingliang Liu <liuml07@apache.org>

ndimiduk requested review from busbey and virajjasani August 10, 2020 18:38

ndimiduk mentioned this pull request Aug 10, 2020

HBASE-24627 Normalize one table at a time #2215

Merged

liuml07 approved these changes Aug 10, 2020

View reviewed changes

virajjasani approved these changes Aug 11, 2020

View reviewed changes

HBASE-24843 Sort the constants in hbase_constants.rb

51d5920

Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Mingliang Liu <liuml07@apache.org>

ndimiduk force-pushed the 24843-sort-hbase_constants.rb branch from cd2f927 to 51d5920 Compare August 11, 2020 20:28

ndimiduk merged commit d2afda3 into apache:master Aug 11, 2020

ndimiduk deleted the 24843-sort-hbase_constants.rb branch August 11, 2020 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-24843 Sort the constants in `hbase_constants.rb` #2236

HBASE-24843 Sort the constants in `hbase_constants.rb` #2236

Uh oh!

ndimiduk commented Aug 10, 2020

Uh oh!

liuml07 left a comment •

edited

Loading

Uh oh!

Apache-HBase commented Aug 10, 2020

Uh oh!

Apache-HBase commented Aug 10, 2020

Uh oh!

Apache-HBase commented Aug 10, 2020

Uh oh!

virajjasani left a comment

Uh oh!

ndimiduk commented Aug 11, 2020

Uh oh!

Apache-HBase commented Aug 11, 2020

Uh oh!

Apache-HBase commented Aug 11, 2020

Uh oh!

Apache-HBase commented Aug 11, 2020

Uh oh!

Uh oh!

HBASE-24843 Sort the constants in hbase_constants.rb #2236

HBASE-24843 Sort the constants in hbase_constants.rb #2236

Uh oh!

Conversation

ndimiduk commented Aug 10, 2020

Uh oh!

liuml07 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Aug 10, 2020

Uh oh!

Apache-HBase commented Aug 10, 2020

Uh oh!

Apache-HBase commented Aug 10, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

ndimiduk commented Aug 11, 2020

Uh oh!

Apache-HBase commented Aug 11, 2020

Uh oh!

Apache-HBase commented Aug 11, 2020

Uh oh!

Apache-HBase commented Aug 11, 2020

Uh oh!

Uh oh!

HBASE-24843 Sort the constants in `hbase_constants.rb` #2236

HBASE-24843 Sort the constants in `hbase_constants.rb` #2236

liuml07 left a comment •

edited

Loading