HBASE-11676 Scan FORMATTER is not applied for columns using non-printable name in shell #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able name in shell - In HBase::Table, the instance variable @converters is used to map column names to converters. This patch fixes how HBase::Table#_get_internal and HBase::Table#_scan_internal generate the column name key used to access @converters. - Refactor parsing of family:qualifier:converter specifications so that the code is more readable and reusable. As part of this change, I added two private methods and marked HBase::Table#set_converter as deprecated for removal in HBase 4.0.0. - Add unit testing for the fixed bug
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 29, 2020
saintstack
pushed a commit
that referenced
this pull request
Jul 29, 2020
…able name in shell (#2161) - In HBase::Table, the instance variable @converters is used to map column names to converters. This patch fixes how HBase::Table#_get_internal and HBase::Table#_scan_internal generate the column name key used to access @converters. - Refactor parsing of family:qualifier:converter specifications so that the code is more readable and reusable. As part of this change, I added two private methods and marked HBase::Table#set_converter as deprecated for removal in HBase 4.0.0. - Add unit testing for the fixed bug Signed-off-by: stack <stack@apache.org>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
…able name in shell (apache#2161) - In HBase::Table, the instance variable @converters is used to map column names to converters. This patch fixes how HBase::Table#_get_internal and HBase::Table#_scan_internal generate the column name key used to access @converters. - Refactor parsing of family:qualifier:converter specifications so that the code is more readable and reusable. As part of this change, I added two private methods and marked HBase::Table#set_converter as deprecated for removal in HBase 4.0.0. - Add unit testing for the fixed bug Signed-off-by: stack <stack@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.apache.org/jira/browse/HBASE-11676
Changelog
names to converters. This patch fixes how HBase::Table#_get_internal and
HBase::Table#_scan_internal generate the column name key used to access
@converters.
code is more readable and reusable. As part of this change, I added two
private methods and marked HBase::Table#set_converter as deprecated for
removal in HBase 4.0.0. I doubt people are using this method, but I kept it
for compatibility.
Testing